Thread: [OSRS] Elvarg [Custom Framework, Dedicated Team]

Page 2 of 24 FirstFirst 123412 ... LastLast
Results 11 to 20 of 231
  1. #11  
    Extreme Donator


    Join Date
    Oct 2010
    Posts
    2,853
    Thanks given
    1,213
    Thanks received
    1,622
    Rep Power
    5000
    Quote Originally Posted by Chivvon View Post
    I would suggest to use another client, nonetheless best of luck #subscribed
    Could you elaborate? Is there something wrong with this client? Seeing how everyone is pointing that out

    Thanks man!
    Reply With Quote  
     

  2. #12  
    Super Donator

    Chivvon's Avatar
    Join Date
    May 2016
    Posts
    487
    Thanks given
    69
    Thanks received
    142
    Rep Power
    285
    Quote Originally Posted by Professor Oak View Post
    Could you elaborate? Is there something wrong with this client? Seeing how everyone is pointing that out

    Thanks man!
    As alot of people pointed out in the rs2 section, here are some main points:
    * Shitty code
    * Memory leaks
    * Feel free to add more to the list as I can't remember everything people said, but these were the main points...

    I would suggest a "clean" rs2 client. (If you can find one)
    EDIT: Or even a OSRS client
    Reply With Quote  
     

  3. Thankful user:


  4. #13  
    Ex Rune-Scaper

    Join Date
    Jun 2008
    Posts
    3,534
    Thanks given
    457
    Thanks received
    1,257
    Rep Power
    990
    Quote Originally Posted by Professor Oak View Post
    Hey thanks for your input, and yes I'm using the latest netty
    Your GIF must be outdated then because the netty used here is 3xx which is extremely old
    Attached image

    Quote Originally Posted by Professor Oak View Post
    Also, it was an interface but that didn't really work with the movement packets, since there are too many parameters... It looked horrible haha.
    Because you're doing it wrong, you don't have to specify any parameters with the movement packets.

    See here

    Another thing you might wanna do is use a parallel game engine. By using a parallel game engine this will process your sychronized tasks a lot faster by taking advantage of available core processors to get the tasks done. This allows for more room if your server slows down so your players don't experience any lag.
    https://github.com/Vult-R/Astraeus-J...nizer.java#L36

    you should make this public on GitHub or something
    Attached image
    Reply With Quote  
     

  5. Thankful user:


  6. #14  
    Extreme Donator


    Join Date
    Oct 2010
    Posts
    2,853
    Thanks given
    1,213
    Thanks received
    1,622
    Rep Power
    5000
    Quote Originally Posted by Free View Post
    Your GIF must be outdated then because the netty used here is 3xx which is extremely old
    Attached image


    Because you're doing it wrong, you don't have to specify any parameters with the movement packets.

    See here

    Another thing you might wanna do is use a parallel game engine. By using a parallel game engine this will process your sychronized tasks a lot faster by taking advantage of available core processors to get the tasks done.
    https://github.com/Vult-R/Astraeus-J...nizer.java#L36
    Hey, oh I thought that was the latest one. I googled around and couldn't find anything newer. Mind landing me a hand?

    I think you've misunderstood, those are the client outgoing packets.
    My server packets do implement a packetlistener interface
    Attached image

    Yeah I'm using a parallel game engine, Swiffy made it. We basically do operations that are asynchronous on a different logic thread.

    Quote Originally Posted by Chivvon View Post
    As alot of people pointed out in the rs2 section, here are some main points:
    * Shitty code
    * Memory leaks
    * Feel free to add more to the list as I can't remember everything people said, but these were the main points...

    I would suggest a "clean" rs2 client. (If you can find one)
    EDIT: Or even a OSRS client
    King, thanks a bunch! Will look for a different one.
    Reply With Quote  
     

  7. #15  
    Super Donator

    Chivvon's Avatar
    Join Date
    May 2016
    Posts
    487
    Thanks given
    69
    Thanks received
    142
    Rep Power
    285
    Quote Originally Posted by Professor Oak View Post
    Hey, oh I thought that was the latest one. I googled around and couldn't find anything newer. Mind landing me a hand?

    I think you've misunderstood, those are the client outgoing packets.
    My server packets do implement a packetlistener interface
    Attached image

    Yeah I'm using a parallel game engine, Swiffy made it. We basically do operations that are asynchronous on a different logic thread.


    King, thanks a bunch! Will look for a different one.
    Alright, hope you'll continue till you're done.
    Reply With Quote  
     

  8. Thankful user:


  9. #16  
    Ex Rune-Scaper

    Join Date
    Jun 2008
    Posts
    3,534
    Thanks given
    457
    Thanks received
    1,257
    Rep Power
    990
    Quote Originally Posted by Professor Oak View Post
    Hey, oh I thought that was the latest one. I googled around and couldn't find anything newer. Mind landing me a hand?
    netty-4.1.5.Final
    Netty: Downloads

    Quote Originally Posted by Professor Oak View Post
    I think you've misunderstood, those are the client outgoing packets.
    Yeah I see what you're doing, you're redoing the client's networking, for a second I thought it was the server.

    Another thing I noticed don't do this.
    Attached image

    Is there a reason why you're not following standard Java conventions?

    OUTPUT_BUFFER streams/buffers are never Immutable so don't uppercase their instances. You only uppercase like that when something is Immutable. (when it cannot be changed)

    This is nitpicking but Java standard naming convention for variables is camelCase so ping_packet_counter is pingPacketCounter. This is totally fine if you don't plan on releasing this but if you do it's gonna be really annoying for others who are used to standard naming conventions.
    Attached image
    Reply With Quote  
     

  10. Thankful users:


  11. #17  
    Registered Member

    Join Date
    Nov 2015
    Age
    27
    Posts
    632
    Thanks given
    114
    Thanks received
    138
    Rep Power
    426
    Looking like you're knowing what you're doing - best of luck on this.
    Reply With Quote  
     

  12. Thankful user:


  13. #18  
    Extreme Donator


    Join Date
    Oct 2010
    Posts
    2,853
    Thanks given
    1,213
    Thanks received
    1,622
    Rep Power
    5000
    Quote Originally Posted by Free View Post
    netty-4.1.5.Final
    Netty: Downloads

    Yeah I see what you're doing, you're redoing the client's networking, for a second I thought it was the server.

    Another thing I noticed don't do this.
    Is there a reason why you're not following standard Java conventions?

    OUTPUT_BUFFER streams/buffers are never Immutable so don't uppercase their instances. You only uppercase like that when something is Immutable. (when it cannot be changed)

    This is nitpicking but Java standard naming convention for variables is camelCase so ping_packet_counter is pingPacketCounter. This is totally fine if you don't plan on releasing this but if you do it's gonna be really annoying for others who are used to standard naming conventions.
    Thanks man!

    Yeah I have it uppercase because I took it from my previous client project where I had a static class with tons of final fields which included that output_buffer.
    Gonna change that, thx!

    I'm going to my girlfriend but will be back tomorrow night, and I'll start with the latest netty and also find a new client to work with.
    Reply With Quote  
     

  14. #19  
    Banned

    Join Date
    Mar 2008
    Posts
    2,595
    Thanks given
    128
    Thanks received
    191
    Rep Power
    0
    Looks like an cool adventure, wish you the best of luck mate.
    Reply With Quote  
     

  15. #20  
    Banned

    Join Date
    Jun 2015
    Posts
    1,517
    Thanks given
    31
    Thanks received
    143
    Rep Power
    0
    a lot of works, Best of luck!
    Reply With Quote  
     

  16. Thankful user:


Page 2 of 24 FirstFirst 123412 ... LastLast

Thread Information
Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)


User Tag List

Similar Threads

  1. Starting a server from scratch?
    By ike izzle in forum Projects
    Replies: 14
    Last Post: 08-02-2009, 03:55 PM
  2. Server from scratch
    By Crazy Man in forum Help
    Replies: 3
    Last Post: 07-11-2009, 02:18 PM
  3. Starting server from scratch
    By w::v::d in forum Help
    Replies: 1
    Last Post: 02-19-2009, 06:16 PM
  4. Making a server from scratch
    By ~ Zymus ~ in forum Help
    Replies: 8
    Last Post: 02-19-2009, 03:39 AM
  5. Going to start a server from scratch.
    By xStanyer in forum RS2 Server
    Replies: 5
    Last Post: 10-30-2008, 09:14 PM
Posting Permissions
  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •