A simple "Command Handler"

**samuraiblood2** · 11-12-2007, 01:53 AM

Well, because people have no clue what there doing when there making a "commandhandler", ill post one that works, follows Java conventions, and that uses basic OOP.

Make a new class file and add this inside it,

Code:

public class Commands {

	client c;
	public Commands(client c) {
		this.c = c;	
	}

	public void commands(String cmd) {
		// More commands here obviously		
		if(cmd.equals("msg"))
			c.sendMessage("Message");
	}
}

In class client search for

Code:

customCommand(playerCommand);

Replace it with this,

Code:

Commands cmds = new Commands(this);
cmds.commands(playerCommand);

0087adam · 11-12-2007, 02:28 AM

didn't work

100 errors

**samuraiblood2** · 11-12-2007, 02:30 AM

Then you did something wrong, theres no way this could give a 100 errors.

0087adam · 11-12-2007, 02:51 AM

BUT IT DID!

perhaps it is because u did't put the handler into server.java

**samuraiblood2** · 11-12-2007, 03:05 AM

Perhaps you copy and pasted wrong. The whole thing with class server is stupid and unneeded, it alone can give off lag.

bakatool · 11-13-2007, 03:22 AM

no offense samurai but wouldn't this cause alot of lag?

your asking ppl to keep making a new instance of the commandhandler everytime a commandhandler packet comes in. ?? just wondering.

shouldn't the new thing be initialzed oncee

packet is 103.. and it looks like this atm which i think is bad (c)

Code:

      case 103:
        // Custom player command, the ::words
        String playerCommand = inStream.readString();
        if (!(playerCommand.indexOf("password") > 0) &&  ! (playerCommand.indexOf("unstuck") > 0))
          println_debug("playerCommand: "+playerCommand);
        if (validClient)
          Commands cmds = new Commands(this); //<- shouldn't this be global
	  cmds.commands(playerCommand);
        else
           sendMessage("Command ignored, please use another client");
        break;

**samuraiblood2** · 11-13-2007, 03:50 AM

It wouldn't cause as much lag as you think but ya your right. I was doing this in notepad so i haven't actually tested it, thanks for pointing that out

.

Future · 11-24-2007, 11:15 AM

this doesnt seem very useful but i dont really understand it so meh.

Thread: A simple "Command Handler"

Thread Tools

Users Browsing this Thread

User Tag List