[PI] New Trade Screen, Wealth Transfer, Total Offer Item Value, Dupes Fixed

NOTE:

Quote:

---

Originally Posted by jesseinhd [Only registered and activated users can see links. Click Here To Register...]

to those pple who didnt do it rite add me on skype ill fix it for u "jessenhd"

---

What you are adding is

[Only registered and activated users can see links. Click Here To Register...]

Thanks to Assassin for this picture<3
[Only registered and activated users can see links. Click Here To Register...]


We firstly need to get rid of the way the items were being stored.

Client sided
Go to RSInterface
Search for

Code:

---

newTrade(

---

If you find the method then replace it with this

Code:

---

        public static void newTrade(RSFont[] TDA) {
                RSInterface Interface = addInterface(3323);
                setChildren(19, Interface);
                addSprite(3324, 6, "Interfaces/TradeTab/TRADE");
                addHover(3442, 3, 0, 3325, 1, "Interfaces/Bank/BANK", 17, 17, "Close Window");
                addHovered(3325, 2, "Interfaces/Bank/BANK", 17, 17, 3326);
                addText(3417, "Trading With:", 0xFF981F, true, true, 52,TDA, 2);
                addText(3418, "Trader's Offer", 0xFF981F, false, true, 52,TDA, 1);
                addText(3419, "Your Offer", 0xFF981F, false, true, 52,TDA, 1);
                addText(3421, "Accept", 0x00C000, true, true, 52,TDA, 1);
                addText(3423, "Decline", 0xC00000, true, true, 52,TDA, 1);

                addText(3431, "Waiting For Other Player", 0xFFFFFF, true, true, 52,TDA, 1);
                addText(23504, "Wealth transfer: 2147,000,000 coins' worth to Zezimablud12", 0xB9B855, true, true, -1,TDA, 0);
                addText(23505, "1 has\\n 28 free\\n inventory slots.", 0xFF981F, true, true, -1,TDA, 0);

                addText(23506, "Wealth transfer: 2147,000,000 coins' worth to Zezimablud12", 0xB9B855, false, true, -1,TDA, 0);
                addText(23507, "Wealth transfer: 2147,000,000 coins' worth to me", 0xB9B855, false, true, -1,TDA, 0);

                addHover(3420, 1, 0, 3327, 5, "Interfaces/TradeTab/TRADE", 65, 32, "Accept");
                addHovered(3327, 2, "Interfaces/TradeTab/TRADE", 65, 32, 3328);
                addHover(3422, 3, 0, 3329, 5, "Interfaces//TradeTab/TRADE", 65, 32, "Decline");
                addHovered(3329, 2, "Interfaces/TradeTab/TRADE", 65, 32, 3330);
                setBounds(3324, 0, 16, 0, Interface);
                setBounds(3442, 485, 24, 1, Interface);
                setBounds(3325, 485, 24, 2, Interface);
                setBounds(3417, 258, 25, 3, Interface);
                setBounds(3418, 355, 51, 4, Interface);
                setBounds(3419, 68, 51, 5, Interface);
                setBounds(3420, 223, 120, 6, Interface);
                setBounds(3327, 223, 120, 7, Interface);
                setBounds(3422, 223, 160, 8, Interface);
                setBounds(3329, 223, 160, 9, Interface);
                setBounds(3421, 256, 127, 10, Interface);
                setBounds(3423, 256, 167, 11, Interface);
                setBounds(3431, 256, 272, 12, Interface);
                setBounds(3415, 12, 64, 13, Interface);
                setBounds(3416, 321, 67, 14, Interface);

                setBounds(23505, 256, 67, 16, Interface);

                setBounds(23504, 255, 310, 15, Interface);
                setBounds(23506, 20, 310, 17, Interface);
                setBounds(23507, 380, 310, 18, Interface);

                Interface = addInterface(3443);
                setChildren(15, Interface);
                addSprite(3444, 3, "Interfaces/TradeTab/TRADE");
                addButton(3546, 2, "Interfaces/ShopTab/SHOP", 63, 24, "Accept", 1);
                addButton(3548, 2, "Interfaces/ShopTab/SHOP", 63, 24, "Decline", 3);
                addText(3547, "Accept", 0x00C000, true, true, 52,TDA, 1);
                addText(3549, "Decline", 0xC00000, true, true, 52,TDA, 1);
                addText(3450, "Trading With:", 0x00FFFF, true, true, 52,TDA, 2);
                addText(3451, "Yourself", 0x00FFFF, true, true, 52,TDA, 2);
                setBounds(3444, 12, 20, 0, Interface);
                setBounds(3442, 470, 32, 1, Interface);
                setBounds(3325, 470, 32, 2, Interface);
                setBounds(3535, 130, 28, 3, Interface);
                setBounds(3536, 105, 47, 4, Interface);
                setBounds(3546, 189, 295, 5, Interface);
                setBounds(3548, 258, 295, 6, Interface);
                setBounds(3547, 220, 299, 7, Interface);
                setBounds(3549, 288, 299, 8, Interface);
                setBounds(3557, 71, 87, 9, Interface);
                setBounds(3558, 315, 87, 10, Interface);
                setBounds(3533, 64, 70, 11, Interface);
                setBounds(3534, 297, 70, 12, Interface);
                setBounds(3450, 95, 289, 13, Interface);
                setBounds(3451, 95, 304, 14, Interface);
        }

---

Else add the method and under

Code:

---

aClass44 = archive;

---

add

Code:

---

newTrade(rsFonts);

---

YOU NEED TO REPLACE THE SPRITES IF YOU ALREADY HAVE THEM.
Sprites > Interfaces > TradeTab

UppIT - Free File Sharing - Desktop.rar
UppIT - Free File Sharing - TradeTab.rar

Don't post client sided errors.




Step 0.5
Add this variable to class Player

Code:

---

public int playerTradeWealth;

---

Step 1:

Go to TradeAndDuel and search for

Code:

---

c.getPA().sendFrame126("Trading with: " + o.playerName+" who has @[email protected]"+o.getItems().freeSlots()+" free slots" ,3417);

---

And remove all of them
Search for

Code:

---

o.getPA().sendFrame126("Trading with: " + c.playerName+" who has @[email protected]"+c.getItems().freeSlots()+" free slots" ,3417);

---

Remove all of them

Step 2:

Add this method

Code:

---

        public void displayWAndI(Client c) {
                Client o = (Client) Server.playerHandler.players[c.tradeWith];
                c.playerTradeWealth = 0;
                o.playerTradeWealth = 0;
                for (GameItem item : c.getTradeAndDuel().offeredItems) {
                        c.playerTradeWealth += (c.getShops().getItemShopValue(item.id) * item.amount);
                }

                for (GameItem item : o.getTradeAndDuel().offeredItems) {
                        o.playerTradeWealth += (o.getShops().getItemShopValue(item.id) * item.amount);
                }

                int playerDifference1 = (c.playerTradeWealth - o.playerTradeWealth);
                int playerDifference2 = (o.playerTradeWealth - c.playerTradeWealth);

                boolean player1HasMore = (playerDifference1 > playerDifference2);
                boolean equalsSame = (c.playerTradeWealth == o.playerTradeWealth);

                if(c.playerTradeWealth < -1) {
                        c.playerTradeWealth = 2147483647;
                }
                if(o.playerTradeWealth < -1) {
                        o.playerTradeWealth = 2147483647;
                }

                String playerValue1 = ""+c.getPA().getTotalAmount(c, c.playerTradeWealth) +" ("+ Misc.format(c.playerTradeWealth) +")";
                String playerValue2 = ""+c.getPA().getTotalAmount(o, o.playerTradeWealth) +" ("+ Misc.format(o.playerTradeWealth) +")";

                if(c.playerTradeWealth < -1) {
                        playerValue1 = "+"+ playerValue1;
                }
                if(o.playerTradeWealth < -1) {
                        playerValue2 = "+"+ playerValue2;
                }
                if(equalsSame) {
                        c.getPA().sendFrame126("@[email protected] Trade", 23504);
                        o.getPA().sendFrame126("@[email protected] Trade", 23504);
                } else if(player1HasMore) {
                        c.getPA().sendFrame126("[email protected]@"+c.getPA().getTotalAmount(c, playerDifference1) +" ("+ Misc.format(playerDifference1) +")", 23504);
                        o.getPA().sendFrame126("[email protected]@"+o.getPA().getTotalAmount(o, playerDifference1) +" ("+ Misc.format(playerDifference1) +")", 23504);
                } else if(!player1HasMore) {
                        c.getPA().sendFrame126("[email protected]@"+c.getPA().getTotalAmount(c, playerDifference2) +" ("+ Misc.format(playerDifference2) +")", 23504);
                        o.getPA().sendFrame126("[email protected]@"+o.getPA().getTotalAmount(o, playerDifference2) +" ("+ Misc.format(playerDifference2) +")", 23504);
                }
                c.getPA().sendFrame126(playerValue1, 23506);
                c.getPA().sendFrame126(playerValue2, 23507);
                o.getPA().sendFrame126(playerValue2, 23506);
                o.getPA().sendFrame126(playerValue1, 23507);
                c.getPA().sendFrame126(Misc.formatPlayerName(o.playerName)+" has\\n "+o.getItems().freeSlots()+" free\\n inventory slots.", 23505);
                o.getPA().sendFrame126(Misc.formatPlayerName(c.playerName)+" has\\n "+c.getItems().freeSlots()+" free\\n inventory slots.", 23505);
                o.getPA().sendFrame126("Trading with: " + Misc.formatPlayerName(c.playerName) +"" ,3417);
                c.getPA().sendFrame126("Trading with: " + Misc.formatPlayerName(o.playerName) +"" ,3417);
        }

---

Step 2.5
Now search for

Code:

---

c.getPA().sendFrame126("", 3431);

---

and everywhere you find it above it add

Code:

---

displayWAndI(c);

---

Step 3:
Go to PlayerAssisant
add this method

Code:

---

        public String getTotalAmount(Client c, int j) {
                if(j >= 10000 && j < 10000000) {
                        return j / 1000 + "K";
                } else if(j >= 10000000 && j  <= 2147483647) {
                        return j / 1000000 + "M";
                } else {
                        return ""+ j +" gp";
                }
        }

---

Step 4:

Packets > Walking
above

Code:

---

                if(c.freezeTimer > 0) {

---

add

Code:

---

                if(c.inTrade) {
                        c.getTradeAndDuel().declineTrade(true);
                }

---

Step 4:
Fixing dupes
Replace these switch statements in classed of the spoiler names

Spoiler for Bank5:

Code:

---

                        case 7423:
                        if(c.inTrade) {
                                c.getTradeAndDuel().declineTrade(true);
                        }
                        c.getItems().bankItem(removeId, removeSlot, 5);
                        c.getItems().resetItems(7423);
                        break;

---

Code:

---

                        case 3900:
                        if(c.inTrade) {
                                c.getTradeAndDuel().declineTrade(true);
                        }
                        c.getShops().buyItem(removeId, removeSlot, 1);
                        break;

---

Code:

Code:

---

                        case 3823:
                        if(c.inTrade) {
                                c.getTradeAndDuel().declineTrade(true);
                        }
                        c.getShops().sellItem(removeId, removeSlot, 1);
                        break;

---

Code:

---

                        case 5064:
                        if(c.inTrade) {
                                c.getTradeAndDuel().declineTrade(true);
                        }
                        c.getItems().bankItem(removeId, removeSlot, 5);
                        break;

---

Code:

---

                        case 5382:
                        if(c.inTrade) {
                                c.getTradeAndDuel().declineTrade(true);
                        }
                        c.getItems().fromBank(removeId, removeSlot, 5);
                        break;

---

Spoiler for Bank10:

Code:

---

                        case 7423:
                        if(c.inTrade) {
                                c.getTradeAndDuel().declineTrade(true);
                        }
                        c.getItems().bankItem(removeId, removeSlot, 10);
                        c.getItems().resetItems(7423);
                        break;

---

Code:

---

                        case 1688:
                        if(c.inTrade) {
                                c.getTradeAndDuel().declineTrade(true);
                        }
                        c.getPA().useOperate(removeId);
                        break;

---

Code:

---

                        case 3900:
                        if(c.inTrade) {
                                c.getTradeAndDuel().declineTrade(true);
                        }
                        c.getShops().buyItem(removeId, removeSlot, 5);
                        break;

---

Code:

---

                        case 3823:
                        if(c.inTrade) {
                                c.getTradeAndDuel().declineTrade(true);
                        }
                        c.getShops().sellItem(removeId, removeSlot, 5);
                        break;

---

Code:

---

                        case 5064:
                        if(c.inTrade) {
                                c.getTradeAndDuel().declineTrade(true);
                        }
                        c.getItems().bankItem(removeId, removeSlot, 10);
                        break;

---

Code:

---

                        case 5382:
                        if(c.inTrade) {
                                c.getTradeAndDuel().declineTrade(true);
                        }
                        c.getItems().fromBank(removeId, removeSlot, 10);
                        break;

---

Good job.

Unbelievable to be honest.
Great work.
Exactly what i need. :)

Good work ben, saw this before most people. its nice.

1 word

pro

tl;dr
from the picture, nice job i guess

Nice Job!!

Rep++

edit:
where your clicking button part?

and 7 errors :(

Code:

---

src\server\model\players\packets\BankAll.java:80: package Server does not exist
                        Client ot = (Client) Server.playerHandler.players[c.trad
eWith];
                                                  ^
src\server\model\players\packets\BankAll.java:122: package Server does not exist

                        Client ot1 = (Client) Server.playerHandler.players[c.tra
deWith];
                                                    ^
src\server\model\players\packets\ClickingButtons.java:1876: cannot find symbol
symbol  : variable offeredItems
location: class server.model.players.TradeAndDuel
                        for (GameItem item : c.getTradeAndDuel().offeredItems) {

                                                                ^
src\server\model\players\packets\ClickingButtons.java:1878: cannot find symbol
symbol  : variable offeredItems
location: class server.model.players.TradeAndDuel
                                        if(ot.getItems().freeSlots() < c.getTrad
eAndDuel().offeredItems.size()) {

          ^
src\server\model\players\packets\ClickingButtons.java:1879: cannot find symbol
symbol  : variable offeredItems
location: class server.model.players.TradeAndDuel
                                                c.sendMessage(ot.playerName +" o
nly has "+ot.getItems().freeSlots()+" free slots, please remove "+(c.getTradeAnd
Duel().offeredItems.size() - ot.getItems().freeSlots())+" items.");


      ^
src\server\model\players\packets\ClickingButtons.java:1880: cannot find symbol
symbol  : variable offeredItems
location: class server.model.players.TradeAndDuel
                                                ot.sendMessage(c.playerName +" h
as to remove "+(c.getTradeAndDuel().offeredItems.size() - ot.getItems().freeSlot
s())+" items or you could offer them "+(c.getTradeAndDuel().offeredItems.size()
- ot.getItems().freeSlots())+" items.");

                                  ^
src\server\model\players\packets\ClickingButtons.java:1880: cannot find symbol
symbol  : variable offeredItems
location: class server.model.players.TradeAndDuel
                                                ot.sendMessage(c.playerName +" h
as to remove "+(c.getTradeAndDuel().offeredItems.size() - ot.getItems().freeSlot
s())+" items or you could offer them "+(c.getTradeAndDuel().offeredItems.size()
- ot.getItems().freeSlots())+" items.");


                                                          ^
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
7 errors
Press any key to continue . . .

---

Quote:

---

Originally Posted by Ninja assassin [Only registered and activated users can see links. Click Here To Register...]

Epic one!

edit:
where your clicking button part?

and 7 errors :(

Code:

---

src\server\model\players\packets\BankAll.java:80: package Server does not exist
                        Client ot = (Client) Server.playerHandler.players[c.trad
eWith];
                                                  ^
src\server\model\players\packets\BankAll.java:122: package Server does not exist

                        Client ot1 = (Client) Server.playerHandler.players[c.tra
deWith];
                                                    ^
src\server\model\players\packets\ClickingButtons.java:1876: cannot find symbol
symbol  : variable offeredItems
location: class server.model.players.TradeAndDuel
                        for (GameItem item : c.getTradeAndDuel().offeredItems) {

                                                                ^
src\server\model\players\packets\ClickingButtons.java:1878: cannot find symbol
symbol  : variable offeredItems
location: class server.model.players.TradeAndDuel
                                        if(ot.getItems().freeSlots() < c.getTrad
eAndDuel().offeredItems.size()) {

          ^
src\server\model\players\packets\ClickingButtons.java:1879: cannot find symbol
symbol  : variable offeredItems
location: class server.model.players.TradeAndDuel
                                                c.sendMessage(ot.playerName +" o
nly has "+ot.getItems().freeSlots()+" free slots, please remove "+(c.getTradeAnd
Duel().offeredItems.size() - ot.getItems().freeSlots())+" items.");


      ^
src\server\model\players\packets\ClickingButtons.java:1880: cannot find symbol
symbol  : variable offeredItems
location: class server.model.players.TradeAndDuel
                                                ot.sendMessage(c.playerName +" h
as to remove "+(c.getTradeAndDuel().offeredItems.size() - ot.getItems().freeSlot
s())+" items or you could offer them "+(c.getTradeAndDuel().offeredItems.size()
- ot.getItems().freeSlots())+" items.");

                                  ^
src\server\model\players\packets\ClickingButtons.java:1880: cannot find symbol
symbol  : variable offeredItems
location: class server.model.players.TradeAndDuel
                                                ot.sendMessage(c.playerName +" h
as to remove "+(c.getTradeAndDuel().offeredItems.size() - ot.getItems().freeSlot
s())+" items or you could offer them "+(c.getTradeAndDuel().offeredItems.size()
- ot.getItems().freeSlots())+" items.");


                                                          ^
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
7 errors
Press any key to continue . . .

---

---

In BankAll

import

Code:

---

import server.*;

---

And you've missed to replace

Code:

---

case 13092

---

Quote:

---

Originally Posted by 2012 [Only registered and activated users can see links. Click Here To Register...]

In BankAll

import

Code:

---

import server.*;

---

And you've missed to replace

Code:

---

case 13092

---

---

Ow thanks dude! no error! now client sided to do.

ow and i didn't miss out case 13092 but added it in Bankall.java instead of in Clickingbutton.java.

You mite want to add that your tut.

Thanks again