Thread: 100% Timed Mutes and Bans (Done the correct way, with correct conventions)

Originally Posted by Daniel

Since all this talk of "correct conventions" is starting to annoy me.
banAssistant should BanAssistant, if you knew the conventions and not just been swept up in the hype.

I guess I mixed the name of class files with variables. Thanks for refreshing my memory then.

Very nice, thanks

Can anyone create Ban command with Uername Case_id Start_date End_date inserting into database?

or just make for me correct insert lines:

My lines:

Code:

            Statement stmt = MySQL.conn.createStatement();
            stmt.execute("INSERT INTO `banned_users` (`Username`, `Case_Id`, `Start_date`, `End_date`) VALUES ('"+p.username+"','"+player+"', '"+today+"', '"+expireDate+"')");

You missed a convention i guess, and a one which you should never forget: Capitalize the first letter of a class (and other first letter if you got more words)
Other then that you might execute your queries in a threadpool, but it looks fine

Originally Posted by netzo

Very nice, thanks

Can anyone create Ban command with Uername Case_id Start_date End_date inserting into database?

or just make for me correct insert lines:

My lines:

Code:

            Statement stmt = MySQL.conn.createStatement();
            stmt.execute("INSERT INTO `banned_users` (`Username`, `Case_Id`, `Start_date`, `End_date`) VALUES ('"+p.username+"','"+player+"', '"+today+"', '"+expireDate+"')");

No, I'm pretty sure that wouldn't work.

And thanks Jonas.

Originally Posted by call me bear

No, I'm pretty sure that wouldn't work.

And thanks Jonas.

My ban code:

Code:

package server.players.Commands;

import java.sql.Statement;

import server.*;
import server.players.*;
import server.players.MiscHandlers.*;

public class BanUser implements Command {
    @Override
    public void execute(client client, String command) {
    if (client.playerRights >= 2) {
                try {
                    String otherPName = command.substring(8);
                    int otherPIndex = PlayerHandler.getPlayerID(otherPName);

                    if (otherPIndex != -1) {
                        client p = (client) server.playerHandler.players[otherPIndex];

            Statement stmt = MySQL.conn.createStatement();
            stmt.execute("INSERT INTO `banned_users` (`Username`, `Case_Id`, `Start_date`, `End_date`) VALUES ('"+p.username+"', '"+player+"', '"+today+"', '"+expireDate+"')");

            p.disconnected = true;
            client.CAM().sendMessage("You have banned "+p.username+"!");
                    } else {
                       client.CAM().sendMessage("The name doesn't exist."); 
                    }
                } catch (Exception e) { 
                    client.CAM().sendMessage("Try entering a name you want to ban..");
                }
            }
    }
}

Just need to edit inserting into db.

thanks so much dude , this looks crazy