[Elvarg v3.2] Anti-leech / exploit fix

Hello everyone!
I have been working on an Elvarg-based server and came across an exploit allowing players to receive donator status by using the :: players command. This is extremely simple, but as I have not seen this anywhere else, I figured I'd post this.

(NOTE: I checked OSRS PK and Elvarg v3.1 and neither have this exploit)

Original code:

Spoiler for Original code:

@Override
public void execute(Player player, String command, String[] parts) {
// DialogueManager.sendStatement(player, "There are currently " + World.getPlayers().size() + " players online.");
player.setDonatorRights(DonatorRights.REGULAR_DONA TOR);

player.getPacketSender().sendRights();
}

Spoiler for In package com.elvarg.game.model.commands.impl;:

@Override
public void execute(Player player, String command, String[] parts) {
player.getPacketSender().sendMessage("There are currently " + World.getPlayers().size() + " players online.");
}

I feel 'almost' idiotic posting this as I don't really believe this is post-worthy, but may be useful to developers.

Maybe post the server you downloaded it from and edit the title so people don't think its all elvarg servers

Quote:

---

Originally Posted by Mark_ [Only registered and activated users can see links. Click Here To Register...]

Maybe post the server you downloaded it from and edit the title so people don't think its all elvarg servers

---

I downloaded it from Professor Oak @ [Only registered and activated users can see links. Click Here To Register...]

As for the title, it says in the title Elvarg v3.2

Quote:

---

Originally Posted by VoidBox [Only registered and activated users can see links. Click Here To Register...]

I downloaded it from Professor Oak @ [Only registered and activated users can see links. Click Here To Register...]

As for the title, it says in the title Elvarg v3.2

---

You said its not in VERSION 3.1 tho ? and on that thread is the version it goes up to

OT: Im sure this will make some people look good job for telling people

Quote:

---

Originally Posted by Mark_ [Only registered and activated users can see links. Click Here To Register...]

You said its not in VERSION 3.1 tho ? and on that thread is the version it goes up to

OT: Im sure this will make some people look good job for telling people

---

Not to sound rude, but I don't believe you actually clicked or read the thread. It goes up to v3.2 and the reason it's not in v3.1 is because that version is using OSRS PK structure(which did not have this exploit).
Thank you though, I felt dumb posting this. Lmao

Good catch. It was in the copy of Elvarg 3.2 that I had as well.

Wouldn't call this an anti-leech or an exploit lol it looks like some debug code that was left behind, nice find though.

Quote:

---

Originally Posted by Professor Oak [Only registered and activated users can see links. Click Here To Register...]

Wouldn't call this an anti-leech or an exploit lol it looks like some debug code that was left behind, nice find though.

---

Yea I figured if you really wanted it to be an exploit or anti-leech you would have made the command do its function + give donator. Just wasn't really sure what to call it. Ultimately could be an exploit if someone doesn't fix it though. Thank you.