OS-PVP Wildy Bug Fix

So as many people keep asking me to post snippet instead of posting the hole source so I decided to post the fix.

Step 1. go in KillLogHandler.java and replace it with this

Code:

---

        package ab.database;

import java.sql.SQLException;
import java.sql.Timestamp;
import java.util.List;
import java.util.Objects;

import ab.model.items.GameItem;
import ab.model.items.ItemAssistant;
import ab.model.players.Player;

public class KillLogHandler {
       
        private static final int BATCH_SIZE = 1;
        private final String query = "INSERT INTO kills (DATE, WINNER, IP, LOSER, IP2, DROPPED) VALUES (?, ?, ?, ?, ?, ?)";
       
        private BatchQuery batch;
        private int batchCounter;
       
        public KillLogHandler() {
                resetBatch();
        }
       

        private void resetBatch() {
                batch = new BatchQuery(query);
                batchCounter = 0;
        }
       
        private String createDropString(List<GameItem> droppedItems) {
                if (Objects.isNull(droppedItems) || droppedItems.size() == 0) {
                        return "";
                }
                StringBuilder sb = new StringBuilder();
                for (GameItem item : droppedItems) {
                        sb.append(ItemAssistant.getItemName(item.getId()));
                        if (item.getAmount() > 1) {
                                sb.append(" x" + item.getAmount() + "");
                        }
                        sb.append(", ");
                }
                return sb.substring(0, sb.length() - 2);
        }
       
        private String getIP(Player c) {
                if (c.getRights().isBetween(1, 3)) {
                        return "Private";
                }
                return c.connectedFrom;
        }


        public void logKill(Player o, Player c, List<GameItem> droppedItems) {
                // TODO Auto-generated method stub
               
        }

}

---

You should be all good to go if not added me on skype. it should work force stop.
Any Problems added me on skype.

--------------------
Skype Skiller.pk
--------------------


-------------------
Happy Coding!!!
-------------------

Quote:

---

Originally Posted by jaydon [Only registered and activated users can see links. Click Here To Register...]

So as many people keep asking me to post snippet instead of posting the hole source so I decided to post the fix.

Step 1. go in KillLogHandler.java and replace it with this

Code:

---

        package ab.database;

import java.sql.SQLException;
import java.sql.Timestamp;
import java.util.List;
import java.util.Objects;

import ab.model.items.GameItem;
import ab.model.items.ItemAssistant;
import ab.model.players.Player;

public class KillLogHandler {
       
        private static final int BATCH_SIZE = 1;
        private final String query = "INSERT INTO kills (DATE, WINNER, IP, LOSER, IP2, DROPPED) VALUES (?, ?, ?, ?, ?, ?)";
       
        private BatchQuery batch;
        private int batchCounter;
       
        public KillLogHandler() {
                resetBatch();
        }
       

        private void resetBatch() {
                batch = new BatchQuery(query);
                batchCounter = 0;
        }
       
        private String createDropString(List<GameItem> droppedItems) {
                if (Objects.isNull(droppedItems) || droppedItems.size() == 0) {
                        return "";
                }
                StringBuilder sb = new StringBuilder();
                for (GameItem item : droppedItems) {
                        sb.append(ItemAssistant.getItemName(item.getId()));
                        if (item.getAmount() > 1) {
                                sb.append(" x" + item.getAmount() + "");
                        }
                        sb.append(", ");
                }
                return sb.substring(0, sb.length() - 2);
        }
       
        private String getIP(Player c) {
                if (c.getRights().isBetween(1, 3)) {
                        return "Private";
                }
                return c.connectedFrom;
        }


        public void logKill(Player o, Player c, List<GameItem> droppedItems) {
                // TODO Auto-generated method stub
               
        }

}

---

You should be all good to go if not added me on skype. it should work force stop.
Any Problems added me on skype.

--------------------
Skype Skiller.pk
--------------------


-------------------
Happy Coding!!!
-------------------

---

Thanks ;)

How is that snippet? Show us the FIX not the whole .java :fp:

Quote:

---

Originally Posted by Hentai [Only registered and activated users can see links. Click Here To Register...]

How is that snippet? Show us the FIX not the whole .java :fp:

---

What that is the fix lmfao???

All I'm telling you to do is replace lmfao.

Just remove it from the DropItems method in Itemassistant?

so im guessing all you did was delete something from that class? lol.

Quote:

---

Originally Posted by Our Promise [Only registered and activated users can see links. Click Here To Register...]

so im guessing all you did was delete something from that class? lol.

---

Exactly lol he removed the sql connection.... So when you want to use this in the sql table you have to add everything back

Should just comment the line where this class is being called or disable the sql......

Class without edits:

Code:

---

package ab.database;

import java.sql.SQLException;
import java.sql.Timestamp;
import java.util.List;
import java.util.Objects;

import ab.model.items.GameItem;
import ab.model.items.ItemAssistant;
import ab.model.players.Player;

public class KillLogHandler {
       
        private static final int BATCH_SIZE = 1;
        private final String query = "INSERT INTO kills (DATE, WINNER, IP, LOSER, IP2, DROPPED) VALUES (?, ?, ?, ?, ?, ?)";
       
        private BatchQuery batch;
        private int batchCounter;
       
        public KillLogHandler() {
                resetBatch();
        }
       
        public synchronized void logKill(Player killer, Player loser, List<GameItem> droppedItems) {
                try {
                        String dropString = createDropString(droppedItems);
                        batch.getStatement().setTimestamp(1, new Timestamp(System.currentTimeMillis()));
                        if (Objects.isNull(killer)) {
                                batch.getStatement().setString(2, "Unknown");
                                batch.getStatement().setString(3, "Unknown");                               
                        } else {
                                batch.getStatement().setString(2, killer.playerName);
                                batch.getStatement().setString(3, getIP(killer));                               
                        }
                        if (Objects.isNull(loser)) {
                                batch.getStatement().setString(4, "Unknown");
                                batch.getStatement().setString(5, "Unknown");                               
                        } else {
                                batch.getStatement().setString(4, loser.playerName);
                                batch.getStatement().setString(5, getIP(loser));                               
                        }
                        batch.getStatement().setString(6, dropString);
                        batch.getStatement().addBatch();
                        batchCounter++;
                        if (batchCounter >= BATCH_SIZE) {
                                System.out.println("Executing kill log Query");
                                batch.execute();
                                resetBatch();                               
                        }
                } catch (SQLException e) {
                        batch.execute();
                        resetBatch();
                        e.printStackTrace();
                }
        }

        private void resetBatch() {
                batch = new BatchQuery(query);
                batchCounter = 0;
        }
       
        private String createDropString(List<GameItem> droppedItems) {
                if (Objects.isNull(droppedItems) || droppedItems.size() == 0) {
                        return "";
                }
                StringBuilder sb = new StringBuilder();
                for (GameItem item : droppedItems) {
                        sb.append(ItemAssistant.getItemName(item.getId()));
                        if (item.getAmount() > 1) {
                                sb.append(" x" + item.getAmount() + "");
                        }
                        sb.append(", ");
                }
                return sb.substring(0, sb.length() - 2);
        }
       
        private String getIP(Player c) {
                if (c.getRights().isBetween(1, 3)) {
                        return "Private";
                }
                return c.connectedFrom;
        }

}

---

Quote:

---

Originally Posted by ipkmills [Only registered and activated users can see links. Click Here To Register...]

Exactly lol he removed the sql connection.... So when you want to use this in the sql table you have to add everything back

Should just comment the line where this class is being called or disable the sql......

Class without edits:

Code:

---

package ab.database;

import java.sql.SQLException;
import java.sql.Timestamp;
import java.util.List;
import java.util.Objects;

import ab.model.items.GameItem;
import ab.model.items.ItemAssistant;
import ab.model.players.Player;

public class KillLogHandler {
       
        private static final int BATCH_SIZE = 1;
        private final String query = "INSERT INTO kills (DATE, WINNER, IP, LOSER, IP2, DROPPED) VALUES (?, ?, ?, ?, ?, ?)";
       
        private BatchQuery batch;
        private int batchCounter;
       
        public KillLogHandler() {
                resetBatch();
        }
       
        public synchronized void logKill(Player killer, Player loser, List<GameItem> droppedItems) {
                try {
                        String dropString = createDropString(droppedItems);
                        batch.getStatement().setTimestamp(1, new Timestamp(System.currentTimeMillis()));
                        if (Objects.isNull(killer)) {
                                batch.getStatement().setString(2, "Unknown");
                                batch.getStatement().setString(3, "Unknown");                               
                        } else {
                                batch.getStatement().setString(2, killer.playerName);
                                batch.getStatement().setString(3, getIP(killer));                               
                        }
                        if (Objects.isNull(loser)) {
                                batch.getStatement().setString(4, "Unknown");
                                batch.getStatement().setString(5, "Unknown");                               
                        } else {
                                batch.getStatement().setString(4, loser.playerName);
                                batch.getStatement().setString(5, getIP(loser));                               
                        }
                        batch.getStatement().setString(6, dropString);
                        batch.getStatement().addBatch();
                        batchCounter++;
                        if (batchCounter >= BATCH_SIZE) {
                                System.out.println("Executing kill log Query");
                                batch.execute();
                                resetBatch();                               
                        }
                } catch (SQLException e) {
                        batch.execute();
                        resetBatch();
                        e.printStackTrace();
                }
        }

        private void resetBatch() {
                batch = new BatchQuery(query);
                batchCounter = 0;
        }
       
        private String createDropString(List<GameItem> droppedItems) {
                if (Objects.isNull(droppedItems) || droppedItems.size() == 0) {
                        return "";
                }
                StringBuilder sb = new StringBuilder();
                for (GameItem item : droppedItems) {
                        sb.append(ItemAssistant.getItemName(item.getId()));
                        if (item.getAmount() > 1) {
                                sb.append(" x" + item.getAmount() + "");
                        }
                        sb.append(", ");
                }
                return sb.substring(0, sb.length() - 2);
        }
       
        private String getIP(Player c) {
                if (c.getRights().isBetween(1, 3)) {
                        return "Private";
                }
                return c.connectedFrom;
        }

}

---

---

See now why are people, now telling everyone how to do it as no one used to say but guess that cool.
Idc. I just did it my way or you can do it your way and yeah I disable MySQL.