Thread: [PI] Redoing Teleport System

Originally Posted by Stanaveli

I remember doing something similar for Wildercress a while back ago, I just had to make a few edits to Lare's system. Maybe you can use this as a reference to improve what you currently have.

Code:

package com.wc.game.character.player.content.spellbook;

import com.wc.game.World;
import com.wc.game.character.Animation;
import com.wc.game.character.Graphic;
import com.wc.game.character.player.Player;
import com.wc.game.location.Position;
import com.wc.task.Task;

/**
 * Manages the Spell books for players.
 * @author <a href="http://www.rune-server.ee/members/stand+up/">Stand Up</a>
 */
public final class SpellbookManager {

	/**
	 * The standard spellbook the player has open.
	 */
	private Spellbook spellbook = Spellbook.NORMAL;

	/**
	 * The enumerated type whose elements represent a spellbook type.
	 * @author lare96 <http://github.com/lare96>
	 */
	public enum Spellbook {
		NORMAL(1151) {
			@Override
			public void execute(Player player, Position position) {
				player.animation(new Animation(714));
				World.submit(new Task(1, false) {
					@Override
					public void execute() {
						if(player.getTeleportStage() == 1) {
							player.graphic(new Graphic(308));
							player.setTeleportStage(2);
						} else if(player.getTeleportStage() == 2) {
							player.setTeleportStage(3);
						} else if(player.getTeleportStage() == 3) {
							player.move(position);
							player.animation(new Animation(715));
							player.setTeleportStage(0);
							this.cancel();
						}
					}
				}.attach(player));
			}
		},
		ANCIENT(12855) {
			@Override
			public void execute(Player player, Position position) {
				player.animation(new Animation(1979));
				World.submit(new Task(1, false) {
					@Override
					public void execute() {
						if(player.getTeleportStage() == 1) {
							player.graphic(new Graphic(392));
							player.setTeleportStage(2);
						} else if(player.getTeleportStage() == 2) {
							player.setTeleportStage(3);
						} else if(player.getTeleportStage() == 3) {
							player.setTeleportStage(4);
						} else if(player.getTeleportStage() == 4) {
							player.move(position);
							player.setTeleportStage(0);
							this.cancel();
						}
					}
				}.attach(player));
			}
		},
		LUNAR(29999) {
			@Override
			public void execute(Player player, Position position) {//TODO replace this to correct lunar home teleport
				player.animation(new Animation(714));
				World.submit(new Task(1, false) {
					@Override
					public void execute() {
						if(player.getTeleportStage() == 1) {
							player.graphic(new Graphic(308));
							player.setTeleportStage(2);
						} else if(player.getTeleportStage() == 2) {
							player.setTeleportStage(3);
						} else if(player.getTeleportStage() == 3) {
							player.move(position);
							player.animation(new Animation(715));
							player.setTeleportStage(0);
							this.cancel();
						}
					}
				}.attach(player));
			}
		};

		/**
		 * The identifier for this spellbook interface.
		 */
		private final int id;

		/**
		 * Creates a new {@link Spellbook}.
		 * @param id the identifier for this spellbook interface.
		 */
		private Spellbook(int id) {
			this.id = id;
		}

		@Override
		public final String toString() {
			return name().toLowerCase().replaceAll("_", " ");
		}

		/**
		 * Attempts to convert the spellbook for {@code player} to {@code book}.
		 * @param player the player to convert the spellbook for.
		 * @param book   the type of spellbook to convert to.
		 */
		public static void convert(Player player, Spellbook book) {
			if(player.getSpellbookManager().getSpellbook() == book) {
				player.getMessages().sendMessage("You have already converted to " + book + " magics!");
				return;
			}
			player.getMessages().sendSidebarInterface(6, book.id);
			player.getSpellbookManager().setSpellbook(book);
		}

		/**
		 * The method executed when {@code player} teleports to {@code position}
		 * while converted to this spellbook type.
		 * @param player   the player that is teleporting.
		 * @param position the position the player is teleporting to.
		 */
		public abstract void execute(Player player, Position position);

		/**
		 * Gets the identifier for this spellbook interface.
		 * @return the identifier for the interface.
		 */
		public final int getId() {
			return id;
		}
	}

	/**
	 * @return the spellbook
	 */
	public Spellbook getSpellbook() {
		return spellbook;
	}

	/**
	 * @param spellbook the spellbook to set
	 */
	public void setSpellbook(Spellbook spellbook) {
		this.spellbook = spellbook;
	}
}

Code:

package com.wc.game.character.player.content;

import java.util.Optional;

import com.wc.game.character.CharacterNode;
import com.wc.game.character.Spell;
import com.wc.game.character.player.Player;
import com.wc.game.character.player.content.spellbook.SpellbookManager.Spellbook;
import com.wc.game.item.Item;
import com.wc.game.location.Position;

/**
 * The spell implementation that provides additional functions exclusively for
 * teleportation spells.
 * @author lare96 <http://github.com/lare96>
 */
public abstract class TeleportSpell extends Spell {

	@Override
	public final Optional<Item[]> equipmentRequired(Player player) {
		return Optional.empty();
	}

	@Override
	public final void startCast(CharacterNode cast, CharacterNode castOn) {

	}

	/**
	 * The position that the caster will be moved to.
	 * @return the teleport position.
	 */
	public abstract Position moveTo();

	/**
	 * The teleportation method that this spell uses.
	 * @return the teleportation type.
	 */
	public abstract Spellbook type();
}

Then you could use something like this to teleport the players around.

Code:

	/**
	 * Attempts to teleport this player somewhere based on {@code spell}.
	 * @param spell the spell the player is using to teleport.
	 */
	public void teleport(TeleportSpell spell) {
		if(viewingOrb != null || disabled)
			return;
		OutputMessages encoder = getMessages();
		if(teleportStage > 0)
			return;
		if(wildernessLevel >= 20) {
			encoder.sendMessage("You must be below level 20 wilderness to teleport!");
			return;
		}
		if(teleblockTimer.get() > 0) {
			int time = teleblockTimer.get() * 600;
			if(time >= 1000 && time <= 60000) {
				encoder.sendMessage("You must wait approximately " + ((time) / 1000) + " seconds in order to teleport!");
				return;
			} else if(time > 60000) {
				encoder.sendMessage("You must wait approximately " + ((time) / 60000) + " minutes in order to teleport!");
				return;
			}
		}
		if(!MinigameHandler.execute(this, true, m -> m.canTeleport(this, spell.moveTo())))
			return;
		if(!spell.canCast(this))
			return;
		FightCavesHandler.remove(this);
		encoder.sendWalkable(-1);
		teleportStage = 1;
		super.getCombatBuilder().reset();
		faceCharacter(null);
		setFollowing(false);
		setFollowCharacter(null);
		encoder.sendCloseWindows();
		Skills.experience(this, spell.baseExperience(), Skills.MAGIC);
		spell.type().execute(this, spell.moveTo());
	}

and to teleport to a position;

Code:

	/**
	 * Attempts to teleport this player somewhere based on the type of spellbook
	 * they have open.
	 * @param position the position that the player will be moved to.
	 */
	public void teleport(Position position) {
		teleport(new TeleportSpell() {
			@Override
			public Position moveTo() {
				return position;
			}

			@Override
			public Spellbook type() {
				return spellbookManager.getSpellbook();
			}

			@Override
			public double baseExperience() {
				return 0;
			}

			@Override
			public Optional<Item[]> itemsRequired(Player player) {
				return Optional.empty();
			}

			@Override
			public int levelRequired() {
				return 1;
			}
		});
	}

Most credits go to Lare96.

public TeleportSpell(Position position, SpellBook book), ur abstract methods are pointless (at most you would make your startCast abstract). I would then have DefaultTeleportSpell, and remove the ridiculousness from teleport(Position) (simply make it call teleport(new DefaultTeleportSpell(position, spellbook) or w.e.

Originally Posted by Intrice Joe

public TeleportSpell(Position position, SpellBook book), ur abstract methods are pointless (at most you would make your startCast abstract). I would then have DefaultTeleportSpell, and remove the ridiculousness from teleport(Position) (simply make it call teleport(new DefaultTeleportSpell(position, spellbook) or w.e.

^ i recommend doing this

Originally Posted by Stanaveli

Should perhaps update your code on the repo as it's the same(?) besides for the spellbook manager class.

yeah, just file an issue and ill get to it eventually

Originally Posted by Bob the Cat

Why do you have the 'NONE' enum field entry? Lol (Explain a use for it)

None does the samething as the movePlayer method in pi.

Originally Posted by Bob the Cat

No his is like NONE(?, -1, -1, 0), or something so I don't see the point in having it, just don't send the teleport? I skimmed through code am I missing something? lol

i am Karma_K and i already explained to you what it does. NONE would do the same thing as the movePlayer method in original pi... it would move the player instantly to the location without performing any animations/gfx or delays