Thread: [ANY] Better Command System

Originally Posted by zeke

It's alright, I have a command system people that people like, Its the

Code:

case "command":
commands code
break;

My command system doesn't have to deal with nearly the amount of code you put in like

Code:

 static final String STRING_COMMANDS[] =
    {
    	"yell",
    	"commands",
        "help"
    };

But I like what you did here, Did you do this?

"(No one was giving me constructive criticism so i decided to post it so people can give me nonconstructive criticism)"

Yeah o-o why would i put up someone elses work?

and this way, the show commands command is dynamic, it always, shows every command up there~

Lol no offence but this is awful

The command system i wrote:

Code:

package server.net.packets.command;

import java.util.HashMap;

import server.model.entity.players.Client;
import server.net.packets.PacketType;
import server.net.packets.command.impl.*;
import server.net.packets.command.impl.Object;
import server.model.entity.players.*;

/**
 * A new command engine
 * @author Zack/Optimum
 *
 */
public class CommandPacketEncoder implements PacketType
{

	/**
	 * Hashmap will contain all of the commands. and the
	 * activation for them
	 */
	private HashMap<String, Command> map = new HashMap<>();
	
	/**
	 * Constructor for the command handler which
	 * adds all the commands to the @link map
	 */
	public CommandPacketEncoder()
	{
		map.put("tele", new Teleport());
		map.put("item", new SpawnItem());
		map.put("master", new Master());
		map.put("setlevel", new SetLevel());
		map.put("interface", new Interface());
		map.put("object", new Object());
		map.put("gfx", new Gfx());
		map.put("npc", new SpawnNpc());
		map.put("anim", new Animation());
		map.put("itemsearch", new ItemSearch());
	}
	
	/**
	 * Process the command packet.
	 */
	@Override
	public void processPacket(Client player, int packetType, int packetSize) 
	{
		String command = player.getInStream().readString();
		for(String commandText : map.keySet())
		{
			String[] args = command.split(" ");
			
			if(commandText.equals(args[0]))
			{
				Command cmd = map.get(commandText);
				for(PlayerRight p : cmd.allowedPlayers())
				{
					if(player.playerRights == p.getPlayerRight())
					{
						cmd.execute(player, command);
						return;
					}
				}
			}
		}
	}

}//end of class

Code:

import server.model.entity.players.Client;

/**
* Handles the commands
* @author Zack/Optimum
*/
public abstract class Command
{

	/**
	* All the players that can use the command
	*/
	public abstract PlayerRight[] allowedPlayers();
	
	/**
	* Executes the command
	* @param player - The player
	* @param command - the command
	*/
	public abstract void execute(Client player, String command);
}

Code:

package server.net.packets.command.impl;

import server.model.entity.players.Client;
import server.model.entity.players.PlayerRight;
import server.net.packets.command.Command;

public class SpawnItem extends Command
{

	@Override
	public PlayerRight[] allowedPlayers() 
	{
		return new PlayerRight[] 
		{
				PlayerRight.ADMIN,
				PlayerRight.OWNER
		};
	}

	@Override
	public void execute(Client player, String command) 
	{
		try 
		{
			String args[] = command.split(" ");
			int itemId = Integer.parseInt(args[1]);
			if(itemId > 21000)
			{
				player.sendMessage("Can't spawn this id : " + itemId);
				return;
			}
			int itemAmount = Integer.parseInt(args[2]);
			
			player.getItems().addItem(itemId, itemAmount);
			player.sendMessage("You have just spawned " + itemAmount + "x " 
					+ player.getItems().getItemName(itemId) + ".");
		}
		catch (Exception e)
		{
			player.sendMessage("Syntax error!: ::item itemId amount");
		}
	}

}

Code:

package server.net.packets.command.impl;

import server.Server;
import server.model.entity.players.Client;
import server.model.entity.players.PlayerRight;
import server.net.packets.command.Command;

public class ItemSearch extends Command 
{

	@Override
	public PlayerRight[] allowedPlayers() 
	{
		return PlayerRight.allRights();
	}

	@Override
	public void execute(Client player, String command) 
	{
		String a[] = command.split(" ");
		String name = "";
		int results = 0;
		for (int i = 1; i < a.length; i++)
		{
			name = name + a[i] + " ";
		}

		name = name.substring(0, name.length() - 1);
		player.sendMessage("Searching: " + name);
		for (int j = 0; j < Server.itemHandler.ItemList.length; j++) 
		{
			if (Server.itemHandler.ItemList[j] != null)
				if (Server.itemHandler.ItemList[j].itemName
						.replace("_", " ").toLowerCase()
						.contains(name.toLowerCase())) {
					player.sendMessage("@[email protected]" + Server.itemHandler.ItemList[j].itemName
									.replace("_", " ") + " - "
							+ Server.itemHandler.ItemList[j].itemId);
					results++;
				}
		}
		player.sendMessage(results + " results found...");
	}

}

This is awful! I highly suggest you to learn how enums work.

oh and #values() is a expensive call, avoid it.

This shows you dont really understand how enums work. Not much better than having a packed class full of commands either.