[PI] Improvements - Cleaning/Converting Process to Events.

Cleaning some sh!t from process...
Using [Only registered and activated users can see links. Click Here To Register...]

#1#

Open client.java and from process() remove:

Code:

---

                if(walkingToItem) {
                        if(getX() == pItemX && getY() == pItemY || goodDistance(getX(), getY(), pItemX, pItemY,1)) {
                                walkingToItem = false;
                                Server.itemHandler.removeGroundItem(this, pItemId, pItemX, pItemY, true);
                        }
                }

---

Open PickupItem.java and under walkingToItem = true; add:

Code:

---

                        CycleEventHandler.getSingleton().addEvent(c, new CycleEvent() {
                                @Override
                                public void execute(CycleEventContainer container) {
                                        if(!c.walkingToItem)
                                                container.stop();
                                        if(c.getX() == c.pItemX && c.getY() == c.pItemY) {
                                                Server.itemHandler.removeGroundItem(c, c.pItemId, c.pItemX, c.pItemY, true);
                                                container.stop();
                                        }
                                }
                                @Override
                                public void stop() {
                                        c.walkingToItem = false;
                                }
                        }, 1);

---

Open Walking.java and under public void processPacket(Client c, int packetType, int packetSize) { add:

Code:

---

c.walkingToItem = false;

---

#2#

Open client.java and from process() remove:

Code:

---

                if(clickObjectType > 0 && goodDistance(objectX + objectXOffset, objectY + objectYOffset, getX(), getY(), objectDistance)) {
                        if(clickObjectType == 1) {
                                getActions().firstClickObject(objectId, objectX, objectY);
                        }
                        if(clickObjectType == 2) {
                                getActions().secondClickObject(objectId, objectX, objectY);
                        }
                        if(clickObjectType == 3) {
                                getActions().thirdClickObject(objectId, objectX, objectY);
                        }
                }

---

Open ClickObject.java and under c.clickObjectType = 1; add:

Code:

---

                                CycleEventHandler.getSingleton().addEvent(c, new CycleEvent() {
                                        @Override
                                        public void execute(CycleEventContainer container) {
                                                if(c.clickObjectType == 1 && c.goodDistance(c.objectX + c.objectXOffset, c.objectY + c.objectYOffset, c.getX(), c.getY(), c.objectDistance)) {
                                                        c.getActions().firstClickObject(c.objectId, c.objectX, c.objectY);
                                                        container.stop();
                                                }
                                                if(c.clickObjectType > 1 || c.clickObjectType == 0)
                                                        container.stop();
                                        }
                                        @Override
                                        public void stop() {
                                                c.clickObjectType = 0;
                                        }
                                }, 1);

---

Under c.clickObjectType = 2; add:

Code:

---

                                CycleEventHandler.getSingleton().addEvent(c, new CycleEvent() {
                                        @Override
                                        public void execute(CycleEventContainer container) {
                                                if(c.clickObjectType == 2 && c.goodDistance(c.objectX + c.objectXOffset, c.objectY + c.objectYOffset, c.getX(), c.getY(), c.objectDistance)) {
                                                        c.getActions().secondClickObject(c.objectId, c.objectX, c.objectY);
                                                        container.stop();
                                                }
                                                if(c.clickObjectType < 2 || c.clickObjectType > 2)
                                                        container.stop();
                                        }
                                        @Override
                                        public void stop() {
                                                c.clickObjectType = 0;
                                        }
                                }, 1);

---

Under c.clickObjectType = 3; add:

Code:

---

                                CycleEventHandler.getSingleton().addEvent(c, new CycleEvent() {
                                        @Override
                                        public void execute(CycleEventContainer container) {
                                                if(c.clickObjectType == 3 && c.goodDistance(c.objectX + c.objectXOffset, c.objectY + c.objectYOffset, c.getX(), c.getY(), c.objectDistance)) {
                                                        c.getActions().thirdClickObject(c.objectId, c.objectX, c.objectY);
                                                        container.stop();
                                                }
                                                if(c.clickObjectType < 3)
                                                        container.stop();
                                        }
                                        @Override
                                        public void stop() {
                                                c.clickObjectType = 0;
                                        }
                                }, 1);

---

#3#

Open client.java and from process() remove:

Code:

---

                if((clickNpcType > 0) && NPCHandler.npcs[npcClickIndex] != null) {                       
                        if(goodDistance(getX(), getY(), NPCHandler.npcs[npcClickIndex].getX(), NPCHandler.npcs[npcClickIndex].getY(), 1)) {
                                if(clickNpcType == 1) {
                                        turnPlayerTo(NPCHandler.npcs[npcClickIndex].getX(), NPCHandler.npcs[npcClickIndex].getY());
                                        NPCHandler.npcs[npcClickIndex].facePlayer(playerId);
                                        getActions().firstClickNpc(npcType);
                                }
                                if(clickNpcType == 2) {
                                        turnPlayerTo(NPCHandler.npcs[npcClickIndex].getX(), NPCHandler.npcs[npcClickIndex].getY());
                                        NPCHandler.npcs[npcClickIndex].facePlayer(playerId);
                                        getActions().secondClickNpc(npcType);
                                }
                                if(clickNpcType == 3) {
                                        turnPlayerTo(NPCHandler.npcs[npcClickIndex].getX(), NPCHandler.npcs[npcClickIndex].getY());
                                        NPCHandler.npcs[npcClickIndex].facePlayer(playerId);
                                        getActions().thirdClickNpc(npcType);
                                }
                        }
                }

---

Open ClickNPC.java and under clickNpcType = 1; add:

Code:

---

                                CycleEventHandler.getSingleton().addEvent(c, new CycleEvent() {
                                        @Override
                                        public void execute(CycleEventContainer container) {
                                                if((c.clickNpcType == 1) && NPCHandler.npcs[c.npcClickIndex] != null) {                       
                                                        if(c.goodDistance(c.getX(), c.getY(), NPCHandler.npcs[c.npcClickIndex].getX(), NPCHandler.npcs[c.npcClickIndex].getY(), 1)) {
                                                                c.turnPlayerTo(NPCHandler.npcs[c.npcClickIndex].getX(), NPCHandler.npcs[c.npcClickIndex].getY());
                                                                NPCHandler.npcs[c.npcClickIndex].facePlayer(c.playerId);
                                                                c.getActions().firstClickNpc(c.npcType);
                                                                container.stop();
                                                        }
                                                }
                                                if(c.clickNpcType == 0 || c.clickNpcType > 1)
                                                        container.stop();
                                        }
                                        @Override
                                        public void stop() {
                                                c.clickNpcType = 0;
                                        }
                                }, 1);

---

Under clickNpcType = 2; add:

Code:

---

                                CycleEventHandler.getSingleton().addEvent(c, new CycleEvent() {
                                        @Override
                                        public void execute(CycleEventContainer container) {
                                                if((c.clickNpcType == 2) && NPCHandler.npcs[c.npcClickIndex] != null) {                       
                                                        if(c.goodDistance(c.getX(), c.getY(), NPCHandler.npcs[c.npcClickIndex].getX(), NPCHandler.npcs[c.npcClickIndex].getY(), 1)) {
                                                                c.turnPlayerTo(NPCHandler.npcs[c.npcClickIndex].getX(), NPCHandler.npcs[c.npcClickIndex].getY());
                                                                NPCHandler.npcs[c.npcClickIndex].facePlayer(c.playerId);
                                                                c.getActions().secondClickNpc(c.npcType);
                                                                container.stop();
                                                        }
                                                }
                                                if(c.clickNpcType < 2 || c.clickNpcType > 2)
                                                        container.stop();
                                        }
                                        @Override
                                        public void stop() {
                                                c.clickNpcType = 0;
                                        }
                                }, 1);

---

Under clickNpcType = 3; add:

Code:

---

                                CycleEventHandler.getSingleton().addEvent(c, new CycleEvent() {
                                        @Override
                                        public void execute(CycleEventContainer container) {
                                                if((c.clickNpcType == 3) && NPCHandler.npcs[c.npcClickIndex] != null) {                       
                                                        if(c.goodDistance(c.getX(), c.getY(), NPCHandler.npcs[c.npcClickIndex].getX(), NPCHandler.npcs[c.npcClickIndex].getY(), 1)) {
                                                                c.turnPlayerTo(NPCHandler.npcs[c.npcClickIndex].getX(), NPCHandler.npcs[c.npcClickIndex].getY());
                                                                NPCHandler.npcs[c.npcClickIndex].facePlayer(c.playerId);
                                                                c.getActions().thirdClickNpc(c.npcType);
                                                                container.stop();
                                                        }
                                                }
                                                if(c.clickNpcType < 3)
                                                        container.stop();
                                        }
                                        @Override
                                        public void stop() {
                                                c.clickNpcType = 0;
                                        }
                                }, 1);

---

Open Walking.java and under public void processPacket(Client c, int packetType, int packetSize) { add:

Code:

---

                c.clickNpcType = 0;
                c.clickObjectType = 0;

---

#4#

Open client.java and from process() remove:

Code:

---

                if(System.currentTimeMillis() - teleGrabDelay >  1550 && usingMagic) {
                        usingMagic = false;
                        if(Server.itemHandler.itemExists(teleGrabItem, teleGrabX, teleGrabY)) {
                                Server.itemHandler.removeGroundItem(this, teleGrabItem, teleGrabX, teleGrabY, true);
                        }
                }

---

Open MagicOnFloorItems.java and add:

Code:

---

                /*
                * Telegrab spell
                */
                if ((((c.getItems().freeSlots() >= 1) || c.getItems().playerHasItem(itemId, 1)) && Item.itemStackable[itemId]) || ((c.getItems().freeSlots() > 0) && !Item.itemStackable[itemId])) {
                        if(c.goodDistance(c.getX(), c.getY(), itemX, itemY, 12)) {
                                c.walkingToItem = true;
                                int offY = (c.getX() - itemX) * -1;
                                int offX = (c.getY() - itemY) * -1;
                                c.teleGrabX = itemX;
                                c.teleGrabY = itemY;
                                c.teleGrabItem = itemId;
                                c.turnPlayerTo(itemX, itemY);
                                c.teleGrabDelay = System.currentTimeMillis();
                                c.startAnimation(c.MAGIC_SPELLS[51][2]);
                                c.gfx100(c.MAGIC_SPELLS[51][3]);
                                c.getPA().createPlayersStillGfx(144, itemX, itemY, 0, 72);
                                c.getPA().createPlayersProjectile(c.getX(), c.getY(), offX, offY, 50, 70, c.MAGIC_SPELLS[51][4], 50, 10, 0, 50);
                                c.getPA().addSkillXP(c.MAGIC_SPELLS[51][7], 6);
                                c.getPA().refreshSkill(6);
                                c.stopMovement();
                                CycleEventHandler.getSingleton().addEvent(c, new CycleEvent() {
                                        @Override
                                        public void execute(CycleEventContainer container) {
                                                if(!c.walkingToItem)
                                                        container.stop();
                                                if(System.currentTimeMillis() - c.teleGrabDelay > 1550 && c.usingMagic) {
                                                        if(Server.itemHandler.itemExists(c.teleGrabItem, c.teleGrabX, c.teleGrabY) && c.goodDistance(c.getX(), c.getY(), itemX, itemY, 12)) {
                                                                Server.itemHandler.removeGroundItem(c, c.teleGrabItem, c.teleGrabX, c.teleGrabY, true);
                                                                c.usingMagic = false;
                                                                container.stop();
                                                        }
                                                }
                                        }
                                        @Override
                                        public void stop() {
                                                c.walkingToItem = false;
                                        }
                                }, 1);
                        }
                } else {
                        c.sendMessage("You don't have enough space in your inventory.");
                        c.stopMovement();
                }

---

#5#

Open client.java and from process() remove:

Code:

---

                if (getItems().updateInventory)
                        getItems().updateInventory();

---

Open ItemAssistant.java and under every updateInventory = true; add:

Code:

---

updateInventory();

---

#6#

Open client.java and from process() remove:

Code:

---

                if(System.currentTimeMillis() - duelDelay > 800 && duelCount > 0) {
                        if(duelCount != 1) {
                                forcedChat(""+(--duelCount));
                                duelDelay = System.currentTimeMillis();
                        } else {
                                damageTaken = new int[Config.MAX_PLAYERS];
                                forcedChat("FIGHT!");
                                duelCount = 0;
                        }
                }

---

Open ClickingButtons.java and under c.duelCount = 4; add:

Code:

---

                                CycleEventHandler.getSingleton().addEvent(c, new CycleEvent() {
                                        @Override
                                        public void execute(CycleEventContainer container) {
                                                if(System.currentTimeMillis() - c.duelDelay > 800 && c.duelCount > 0) {
                                                        if(c.duelCount != 1) {
                                                                c.forcedChat(""+(--c.duelCount));
                                                                c.duelDelay = System.currentTimeMillis();
                                                        } else {
                                                                c.damageTaken = new int[Config.MAX_PLAYERS];
                                                                c.forcedChat("FIGHT!");
                                                                c.duelCount = 0;
                                                        }
                                                }
                                                if (c.duelCount == 0) {
                                                        container.stop();
                                                }
                                        }
                                        @Override
                                        public void stop() {
                                        }
                                }, 1);

---

#7#

Open client.java and from process() remove:

Code:

---

                if(inTrade && tradeResetNeeded){
                        Client o = (Client) PlayerHandler.players[tradeWith];
                        if(o != null){
                                if(o.tradeResetNeeded){
                                        getTradeAndDuel().resetTrade();
                                        o.getTradeAndDuel().resetTrade();
                                }
                        }
                }

---

Open TradeAndDuel.java and under c.tradeResetNeeded = true; add:

Code:

---

                        CycleEventHandler.getSingleton().addEvent(this, new CycleEvent() {
                                public void execute(CycleEventContainer container) {
                                        if(c.inTrade && c.tradeResetNeeded){
                                                Client o = (Client) PlayerHandler.players[c.tradeWith];
                                                if(o != null){
                                                        if(o.tradeResetNeeded){
                                                                c.getTradeAndDuel().resetTrade();
                                                                o.getTradeAndDuel().resetTrade();
                                                                container.stop();
                                                        } else {
                                                                container.stop();
                                                        }
                                                } else {
                                                        container.stop();
                                                }
                                        } else {
                                                container.stop();
                                        }
                                }

                                @Override
                                public void stop() {
                                        c.tradeResetNeeded = false;
                                }
                        }, 1);

---

A hint:

Code:

---

import server.event.CycleEvent;
import server.event.CycleEventContainer;
import server.event.CycleEventHandler;

---

Nice, turning it into an event, good idea ^^ But thats only one day, 1000000000 Other parts of shit code to go ^^, GL

Keep clicking the item and it'll create as many events as you want, and you could walk away before you get to the item and it wouldn't stop the tick. Nice though.

Quote:

---

Originally Posted by Mikey` [Only registered and activated users can see links. Click Here To Register...]

Keep clicking the item and it'll create as many events as you want, and you could walk away before you get to the item and it wouldn't stop the tick. Nice though.

---

What about increasing the timer to 1000? (1K milli = 1 sec right?)
I'm pretty sure process() executes every second too, wouldn't that fix it?

isn't it meant to run on 600ms

Code:

---

public void duelTimer() {
                CycleEventHandler.getSingleton().addEvent(c, new CycleEvent() {
                @Override
                public void execute(CycleEventContainer container) {
                        if(System.currentTimeMillis() - c.duelDelay > 800 && c.duelCount > 0) {
                                if(c.duelCount != 1) {
                                        c.forcedChat(""+(--c.duelCount));
                                        c.duelDelay = System.currentTimeMillis();
                                } else {
                                        c.damageTaken = new int[Config.MAX_PLAYERS];
                                        c.forcedChat("FIGHT!");
                                        c.duelCount = 0;
                                        }
                                }
                                if (c.duelCount == 0) {
                                        container.stop();
                                }
                                        }
                                @Override
                                public void stop() {
                                }
                                }, 1);       
        }

---

I guess it was in process.

Quote:

---

Originally Posted by Faris [Only registered and activated users can see links. Click Here To Register...]

Nice, turning it into an event, good idea ^^ But thats only one day, 1000000000 Other parts of shit code to go ^^, GL

---

Better than nothing ;)

Quote:

---

Originally Posted by Mikey` [Only registered and activated users can see links. Click Here To Register...]

Keep clicking the item and it'll create as many events as you want, and you could walk away before you get to the item and it wouldn't stop the tick. Nice though.

---

Try clicking, it won't :)

About walking away, here's the fix:

replace that event with:

Code:

---

                        CycleEventHandler.getSingleton().addEvent(c, new CycleEvent() {
                                @Override
                                public void execute(CycleEventContainer container) {
                                        if(!c.walkingToItem)
                                                container.stop();
                                        if(c.getX() == c.pItemX && c.getY() == c.pItemY) {
                                                Server.itemHandler.removeGroundItem(c, c.pItemId, c.pItemX, c.pItemY, true);
                                                container.stop();
                                        }
                                }
                                @Override
                                public void stop() {
                                        c.walkingToItem = false;
                                }
                        }, 1);

---

In Walking.java add:

Code:

---

c.walkingToItem = false

---

Thanks for the feedback ;)

EDIT:
Thread updated.

I can see a flaw in this... THE EVENT MANAGER IS RUN EVERY SINGLE CYCLE ANYWAY REGARDLESS. It's just the same as keeping it in process(), you just have the flexibility of how many cycles you want it to run for... I suggest using Hyperion's event manager or Graham's old event manager if you want to do things like this.

This isn't flame by the way, I was just informing you.

Wouldn't this cause issues using an event vs keeping it on the same thread?

Quote:

---

Originally Posted by Flux [Only registered and activated users can see links. Click Here To Register...]

I can see a flaw in this... THE EVENT MANAGER IS RUN EVERY SINGLE CYCLE ANYWAY REGARDLESS. It's just the same as keeping it in process(), you just have the flexibility of how many cycles you want it to run for... I suggest using Hyperion's event manager or Graham's old event manager if you want to do things like this.

This isn't flame by the way, I was just informing you.

---

Code:

---

THE EVENT MANAGER IS RUN EVERY SINGLE CYCLE ANYWAY REGARDLESS.

---

It's being runned only when it's needed, when it's finished, it's stopped, instead of being processed every CYCLE in PROCESS() for ever! :)

Code:

---

It's just the same as keeping it in process(), you just have the flexibility of how many cycles you want it to run for...

---

Not how many cycles you want it to run for, but how often do you want it to run until it's stopped;)

and what's the flaw?

Quote:

---

Originally Posted by animeking1120 [Only registered and activated users can see links. Click Here To Register...]

Wouldn't this cause issues using an event vs keeping it on the same thread?

---

I'm not sure, needs testing :) Eragorn is using this sh1t, till now, the admin never complained about :)

If what you guys said was true about using events then why is using the process() method considered dumb and using events good? Makes no sense if they are both the same (that's what you said)

Nice release, one of the few things released here on rune-server that I'll be using.

Wow! I really want to change mine but there are so many parts to change.... I might pay someone to do it but overall nice share ;)

Thanks for the feedback ;)

Quote:

---

Originally Posted by phl0w [Only registered and activated users can see links. Click Here To Register...]

If what you guys said was true about using events then why is using the process() method considered dumb and using events good? Makes no sense if they are both the same (that's what you said)

Nice release, one of the few things released here on rune-server that I'll be using.

---

In some cases it's really redundant, but netzo is right in saying that some of these should not be in process(), but animeking also has a point.

Testing! sound good ;) LOL

Updated the thread ;)

i don't think this is better than using process.

Quote:

---

Originally Posted by owner blade [Only registered and activated users can see links. Click Here To Register...]

i don't think this is better than using process.

---

How so? At least now the stuff will only be called if necessary, not every 600ms (or whatever you set your cycle rate to)

Nice netzo <3 I added to my tut thread :hurr:
Also about the comment earlier, how would I go about changing the rate in which shit is executed in process thread?

Only problem I can see people getting is step 3, a lot of typin :)

What's the point you still are running them in process.

Nice job, and using events would be better imo.

Code:

---

src\server\model\players\packets\ClickObject.java:223: local variable c is acces
sed from within inner class; needs to be declared final
                                                if(c.clickObjectType == 1 && c.g
oodDistance(c.objectX + c.objectXOffset, c.objectY + c.objectYOffset, c.getX(),
c.getY(), c.objectDistance)) {
                                                  ^
src\server\model\players\packets\ClickObject.java:223: local variable c is acces
sed from within inner class; needs to be declared final
                                                if(c.clickObjectType == 1 && c.g
oodDistance(c.objectX + c.objectXOffset, c.objectY + c.objectYOffset, c.getX(),
c.getY(), c.objectDistance)) {

            ^
src\server\model\players\packets\ClickObject.java:223: local variable c is acces
sed from within inner class; needs to be declared final
                                                if(c.clickObjectType == 1 && c.g
oodDistance(c.objectX + c.objectXOffset, c.objectY + c.objectYOffset, c.getX(),
c.getY(), c.objectDistance)) {

                        ^
src\server\model\players\packets\ClickObject.java:223: local variable c is acces
sed from within inner class; needs to be declared final
                                                if(c.clickObjectType == 1 && c.g
oodDistance(c.objectX + c.objectXOffset, c.objectY + c.objectYOffset, c.getX(),
c.getY(), c.objectDistance)) {

                                        ^
src\server\model\players\packets\ClickObject.java:223: local variable c is acces
sed from within inner class; needs to be declared final
                                                if(c.clickObjectType == 1 && c.g
oodDistance(c.objectX + c.objectXOffset, c.objectY + c.objectYOffset, c.getX(),
c.getY(), c.objectDistance)) {

                                                    ^
src\server\model\players\packets\ClickObject.java:223: local variable c is acces
sed from within inner class; needs to be declared final
                                                if(c.clickObjectType == 1 && c.g
oodDistance(c.objectX + c.objectXOffset, c.objectY + c.objectYOffset, c.getX(),
c.getY(), c.objectDistance)) {

                                                                      ^
src\server\model\players\packets\ClickObject.java:223: local variable c is acces
sed from within inner class; needs to be declared final
                                                if(c.clickObjectType == 1 && c.g
oodDistance(c.objectX + c.objectXOffset, c.objectY + c.objectYOffset, c.getX(),
c.getY(), c.objectDistance)) {


^
src\server\model\players\packets\ClickObject.java:223: local variable c is acces
sed from within inner class; needs to be declared final
                                                if(c.clickObjectType == 1 && c.g
oodDistance(c.objectX + c.objectXOffset, c.objectY + c.objectYOffset, c.getX(),
c.getY(), c.objectDistance)) {


          ^
src\server\model\players\packets\ClickObject.java:223: local variable c is acces
sed from within inner class; needs to be declared final
                                                if(c.clickObjectType == 1 && c.g
oodDistance(c.objectX + c.objectXOffset, c.objectY + c.objectYOffset, c.getX(),
c.getY(), c.objectDistance)) {
                                                                            ^
src\server\model\players\packets\ClickObject.java:224: local variable c is acces
sed from within inner class; needs to be declared final
                                                        c.getActions().firstClic
kObject(c.objectId, c.objectX, c.objectY);

        ^
src\server\model\players\packets\ClickObject.java:224: local variable c is acces
sed from within inner class; needs to be declared final
                                                        c.getActions().firstClic
kObject(c.objectId, c.objectX, c.objectY);

                    ^
src\server\model\players\packets\ClickObject.java:224: local variable c is acces
sed from within inner class; needs to be declared final
                                                        c.getActions().firstClic
kObject(c.objectId, c.objectX, c.objectY);

                              ^
src\server\model\players\packets\ClickObject.java:224: local variable c is acces
sed from within inner class; needs to be declared final
                                                        c.getActions().firstClic
kObject(c.objectId, c.objectX, c.objectY);
                                                        ^
src\server\model\players\packets\ClickObject.java:227: local variable c is acces
sed from within inner class; needs to be declared final
                                                if(c.clickObjectType > 1 || c.cl
ickObjectType == 0)
                                                  ^
src\server\model\players\packets\ClickObject.java:227: local variable c is acces
sed from within inner class; needs to be declared final
                                                if(c.clickObjectType > 1 || c.cl
ickObjectType == 0)
                                                                            ^
src\server\model\players\packets\ClickObject.java:232: local variable c is acces
sed from within inner class; needs to be declared final
                                                c.clickObjectType = 0;
                                                ^
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
16 errors
Press any key to continue . . .

---

How do i go about solving these? Iv tryed declaring the ObjectType's as ints and it then tells me that it wants another identifyer? Am i missing something really easy here :P

c has to be final.

Code:

---

public void processPacket(final Client c, int packetType, int packetSize) {

---

Quote:

---

Originally Posted by Creator [Only registered and activated users can see links. Click Here To Register...]

c has to be final.

Code:

---

public void processPacket(final Client c, int packetType, int packetSize) {

---

---

Thank you, Got it sorted :)

No problem

Nice job.

Thanks for the feedback everyone :)

Quote:

---

Originally Posted by Ambient [Only registered and activated users can see links. Click Here To Register...]

Nice netzo <3 I added to my tut thread :hurr:
Also about the comment earlier, how would I go about changing the rate in which shit is executed in process thread?

Only problem I can see people getting is step 3, a lot of typin :)

---

public static final int CYCLE_TIME = 600; in Config.java? :)

Quote:

---

Originally Posted by 1776 [Only registered and activated users can see links. Click Here To Register...]

What's the point you still are running them in process.

---

So a better idea would be to put everything into process instead of calling it when it's needed?

Quote:

---

Originally Posted by D R O [Only registered and activated users can see links. Click Here To Register...]

Nice job, and using events would be better imo.

---

Could you please explain why it is better, because I see no improvement over using process(). All this does is move from client.process to the server loop which is the same thing... :rofl:


Server => PlayerHandler => Loops through all players online => Player Process()

I've handled teleporting and combat events as well :)

omg repped !

Error:
[spoil]

Code:

---

src\server\model\players\packets\MagicOnFloorItems.java:33: error: cannot find s
ymbol
                if ((((c.getItems().freeSlots() >= 1) || c.getItems().playerHasI
tem(itemId, 1)) && Item.itemStackable[itemId]) || ((c.getItems().freeSlots() > 0
) && !Item.itemStackable[itemId])) {

                  ^
  symbol:  variable Item
  location: class MagicOnFloorItems
src\server\model\players\packets\MagicOnFloorItems.java:33: error: cannot find s
ymbol
                if ((((c.getItems().freeSlots() >= 1) || c.getItems().playerHasI
tem(itemId, 1)) && Item.itemStackable[itemId]) || ((c.getItems().freeSlots() > 0
) && !Item.itemStackable[itemId])) {


      ^
  symbol:  variable Item
  location: class MagicOnFloorItems
src\server\model\players\packets\MagicOnFloorItems.java:56: error: local variabl
e itemX is accessed from within inner class; needs to be declared final
                                                        if(Server.itemHandler.it
emExists(c.teleGrabItem, c.teleGrabX, c.teleGrabY) && c.goodDistance(c.getX(), c
.getY(), itemX, itemY, 12)) {


        ^
src\server\model\players\packets\MagicOnFloorItems.java:56: error: local variabl
e itemY is accessed from within inner class; needs to be declared final
                                                        if(Server.itemHandler.it
emExists(c.teleGrabItem, c.teleGrabX, c.teleGrabY) && c.goodDistance(c.getX(), c
.getY(), itemX, itemY, 12)) {


                ^
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
4 errors
Press any key to continue . . .

---

[/spoil]

Code:
[spoil]

Code:

---

package server.model.players.packets;
import server.Server;
import server.model.players.Client;
import server.model.players.PacketType;
import server.event.CycleEvent;
import server.event.CycleEventContainer;
import server.event.CycleEventHandler;

/**
 * Magic on floor items
 **/
public class MagicOnFloorItems implements PacketType {

        @Override
        public void processPacket(final Client c, int packetType, int packetSize) {
                int itemY = c.getInStream().readSignedWordBigEndian();
                int itemId = c.getInStream().readUnsignedWord();
                int itemX = c.getInStream().readSignedWordBigEndian();
                int spellId = c.getInStream().readUnsignedWordA();

                if(!Server.itemHandler.itemExists(itemId, itemX, itemY)) {
                        c.stopMovement();
                        return;
                }
                c.usingMagic = true;
                if(!c.getCombat().checkMagicReqs(51)) {
                        c.stopMovement();
                        return;
                }
                                /*
                * Telegrab spell
                */
                if ((((c.getItems().freeSlots() >= 1) || c.getItems().playerHasItem(itemId, 1)) && Item.itemStackable[itemId]) || ((c.getItems().freeSlots() > 0) && !Item.itemStackable[itemId])) {
                        if(c.goodDistance(c.getX(), c.getY(), itemX, itemY, 12)) {
                                c.walkingToItem = true;
                                int offY = (c.getX() - itemX) * -1;
                                int offX = (c.getY() - itemY) * -1;
                                c.teleGrabX = itemX;
                                c.teleGrabY = itemY;
                                c.teleGrabItem = itemId;
                                c.turnPlayerTo(itemX, itemY);
                                c.teleGrabDelay = System.currentTimeMillis();
                                c.startAnimation(c.MAGIC_SPELLS[51][2]);
                                c.gfx100(c.MAGIC_SPELLS[51][3]);
                                c.getPA().createPlayersStillGfx(144, itemX, itemY, 0, 72);
                                c.getPA().createPlayersProjectile(c.getX(), c.getY(), offX, offY, 50, 70, c.MAGIC_SPELLS[51][4], 50, 10, 0, 50);
                                c.getPA().addSkillXP(c.MAGIC_SPELLS[51][7], 6);
                                c.getPA().refreshSkill(6);
                                c.stopMovement();
                                CycleEventHandler.getSingleton().addEvent(c, new CycleEvent() {
                                        @Override
                                        public void execute(CycleEventContainer container) {
                                                if(!c.walkingToItem)
                                                        container.stop();
                                                if(System.currentTimeMillis() - c.teleGrabDelay > 1550 && c.usingMagic) {
                                                        if(Server.itemHandler.itemExists(c.teleGrabItem, c.teleGrabX, c.teleGrabY) && c.goodDistance(c.getX(), c.getY(), itemX, itemY, 12)) {
                                                                Server.itemHandler.removeGroundItem(c, c.teleGrabItem, c.teleGrabX, c.teleGrabY, true);
                                                                c.usingMagic = false;
                                                                container.stop();
                                                        }
                                                }
                                        }
                                        @Override
                                        public void stop() {
                                                c.walkingToItem = false;
                                        }
                                }, 1);
                        }
                } else {
                        c.sendMessage("You don't have enough space in your inventory.");
                        c.stopMovement();
                }
                /*if(c.goodDistance(c.getX(), c.getY(), itemX, itemY, 12)) {
                        int offY = (c.getX() - itemX) * -1;
                        int offX = (c.getY() - itemY) * -1;
                        c.teleGrabX = itemX;
                        c.teleGrabY = itemY;
                        c.teleGrabItem = itemId;
                        c.turnPlayerTo(itemX, itemY);
                        c.teleGrabDelay = System.currentTimeMillis();
                        c.startAnimation(c.MAGIC_SPELLS[51][2]);
                        c.gfx100(c.MAGIC_SPELLS[51][3]);
                        c.getPA().createPlayersStillGfx(144, itemX, itemY, 0, 72);
                        c.getPA().createPlayersProjectile(c.getX(), c.getY(), offX, offY, 50, 70, c.MAGIC_SPELLS[51][4], 50, 10, 0, 50);
                        c.getPA().addSkillXP(c.MAGIC_SPELLS[51][7], 6);
                        c.getPA().refreshSkill(6);
                        c.stopMovement();
                }*/
        }

}

---

[/spoil]

Tried the above and didn't work.

Quote:

---

Originally Posted by 1776 [Only registered and activated users can see links. Click Here To Register...]

Could you please explain why it is better, because I see no improvement over using process(). All this does is move from client.process to the server loop which is the same thing... :rofl:


Server => PlayerHandler => Loops through all players online => Player Process()

---

Exactly you will not even notice the improvement, normally it would just go through some if statements at the 600ms loop which wouldn't even be a problem and certainly not the cause of the bad stability of PI.
It wouldn't make a big difference if it would get executed by an event or by the process() call, so this is kind of useless.

Good work.

You can't fix something so broken anyhow. But nice work.

This is really nice, will release most of the lag (y)

Quote:

---

Originally Posted by Mikey` [Only registered and activated users can see links. Click Here To Register...]

You can't fix something so broken anyhow. But nice work.

---

Whats broken about it? I realise the way it loads items/npcs could be done better. But that is what uses the most and creates the most instances.

but i'd like you to explain to me what exactly is " broken " about project insanity.

This is literally the first thing I did when I worked on PI. Now that I'm working on Azure, it's done for me :D

Quote:

---

Originally Posted by Haptic [Only registered and activated users can see links. Click Here To Register...]

Error:
[spoil]

Code:

---

src\server\model\players\packets\MagicOnFloorItems.java:33: error: cannot find s
ymbol
                if ((((c.getItems().freeSlots() >= 1) || c.getItems().playerHasI
tem(itemId, 1)) && Item.itemStackable[itemId]) || ((c.getItems().freeSlots() > 0
) && !Item.itemStackable[itemId])) {

                  ^
  symbol:  variable Item
  location: class MagicOnFloorItems
src\server\model\players\packets\MagicOnFloorItems.java:33: error: cannot find s
ymbol
                if ((((c.getItems().freeSlots() >= 1) || c.getItems().playerHasI
tem(itemId, 1)) && Item.itemStackable[itemId]) || ((c.getItems().freeSlots() > 0
) && !Item.itemStackable[itemId])) {


      ^
  symbol:  variable Item
  location: class MagicOnFloorItems
src\server\model\players\packets\MagicOnFloorItems.java:56: error: local variabl
e itemX is accessed from within inner class; needs to be declared final
                                                        if(Server.itemHandler.it
emExists(c.teleGrabItem, c.teleGrabX, c.teleGrabY) && c.goodDistance(c.getX(), c
.getY(), itemX, itemY, 12)) {


        ^
src\server\model\players\packets\MagicOnFloorItems.java:56: error: local variabl
e itemY is accessed from within inner class; needs to be declared final
                                                        if(Server.itemHandler.it
emExists(c.teleGrabItem, c.teleGrabX, c.teleGrabY) && c.goodDistance(c.getX(), c
.getY(), itemX, itemY, 12)) {


                ^
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
4 errors
Press any key to continue . . .

---

[/spoil]

Code:
[spoil]

Code:

---

package server.model.players.packets;
import server.Server;
import server.model.players.Client;
import server.model.players.PacketType;
import server.event.CycleEvent;
import server.event.CycleEventContainer;
import server.event.CycleEventHandler;

/**
 * Magic on floor items
 **/
public class MagicOnFloorItems implements PacketType {

        @Override
        public void processPacket(final Client c, int packetType, int packetSize) {
                int itemY = c.getInStream().readSignedWordBigEndian();
                int itemId = c.getInStream().readUnsignedWord();
                int itemX = c.getInStream().readSignedWordBigEndian();
                int spellId = c.getInStream().readUnsignedWordA();

                if(!Server.itemHandler.itemExists(itemId, itemX, itemY)) {
                        c.stopMovement();
                        return;
                }
                c.usingMagic = true;
                if(!c.getCombat().checkMagicReqs(51)) {
                        c.stopMovement();
                        return;
                }
                                /*
                * Telegrab spell
                */
                if ((((c.getItems().freeSlots() >= 1) || c.getItems().playerHasItem(itemId, 1)) && Item.itemStackable[itemId]) || ((c.getItems().freeSlots() > 0) && !Item.itemStackable[itemId])) {
                        if(c.goodDistance(c.getX(), c.getY(), itemX, itemY, 12)) {
                                c.walkingToItem = true;
                                int offY = (c.getX() - itemX) * -1;
                                int offX = (c.getY() - itemY) * -1;
                                c.teleGrabX = itemX;
                                c.teleGrabY = itemY;
                                c.teleGrabItem = itemId;
                                c.turnPlayerTo(itemX, itemY);
                                c.teleGrabDelay = System.currentTimeMillis();
                                c.startAnimation(c.MAGIC_SPELLS[51][2]);
                                c.gfx100(c.MAGIC_SPELLS[51][3]);
                                c.getPA().createPlayersStillGfx(144, itemX, itemY, 0, 72);
                                c.getPA().createPlayersProjectile(c.getX(), c.getY(), offX, offY, 50, 70, c.MAGIC_SPELLS[51][4], 50, 10, 0, 50);
                                c.getPA().addSkillXP(c.MAGIC_SPELLS[51][7], 6);
                                c.getPA().refreshSkill(6);
                                c.stopMovement();
                                CycleEventHandler.getSingleton().addEvent(c, new CycleEvent() {
                                        @Override
                                        public void execute(CycleEventContainer container) {
                                                if(!c.walkingToItem)
                                                        container.stop();
                                                if(System.currentTimeMillis() - c.teleGrabDelay > 1550 && c.usingMagic) {
                                                        if(Server.itemHandler.itemExists(c.teleGrabItem, c.teleGrabX, c.teleGrabY) && c.goodDistance(c.getX(), c.getY(), itemX, itemY, 12)) {
                                                                Server.itemHandler.removeGroundItem(c, c.teleGrabItem, c.teleGrabX, c.teleGrabY, true);
                                                                c.usingMagic = false;
                                                                container.stop();
                                                        }
                                                }
                                        }
                                        @Override
                                        public void stop() {
                                                c.walkingToItem = false;
                                        }
                                }, 1);
                        }
                } else {
                        c.sendMessage("You don't have enough space in your inventory.");
                        c.stopMovement();
                }
                /*if(c.goodDistance(c.getX(), c.getY(), itemX, itemY, 12)) {
                        int offY = (c.getX() - itemX) * -1;
                        int offX = (c.getY() - itemY) * -1;
                        c.teleGrabX = itemX;
                        c.teleGrabY = itemY;
                        c.teleGrabItem = itemId;
                        c.turnPlayerTo(itemX, itemY);
                        c.teleGrabDelay = System.currentTimeMillis();
                        c.startAnimation(c.MAGIC_SPELLS[51][2]);
                        c.gfx100(c.MAGIC_SPELLS[51][3]);
                        c.getPA().createPlayersStillGfx(144, itemX, itemY, 0, 72);
                        c.getPA().createPlayersProjectile(c.getX(), c.getY(), offX, offY, 50, 70, c.MAGIC_SPELLS[51][4], 50, 10, 0, 50);
                        c.getPA().addSkillXP(c.MAGIC_SPELLS[51][7], 6);
                        c.getPA().refreshSkill(6);
                        c.stopMovement();
                }*/
        }

}

---

[/spoil]

Tried the above and didn't work.

---

parameter c to final c :)

Hey man love this work. But however important things;
That duel thing that handles the FIGHT force chat & being able to attack does not work. It will work for other player but not for you.
Second, traderesetneeded causes a DUPE.
Trade someone an item, after the trade is done relog. You will receive the item and he will aswell.
You should consider fixing these, thanks.

Have fun recoding all the timers