Thread: [PI] Improvements - Cleaning/Converting Process to Events.

Originally Posted by 1776

Could you please explain why it is better, because I see no improvement over using process(). All this does is move from client.process to the server loop which is the same thing...


Server => PlayerHandler => Loops through all players online => Player Process()

Exactly you will not even notice the improvement, normally it would just go through some if statements at the 600ms loop which wouldn't even be a problem and certainly not the cause of the bad stability of PI.
It wouldn't make a big difference if it would get executed by an event or by the process() call, so this is kind of useless.

Good work.

You can't fix something so broken anyhow. But nice work.

This is really nice, will release most of the lag

Originally Posted by Mikey`

You can't fix something so broken anyhow. But nice work.

Whats broken about it? I realise the way it loads items/npcs could be done better. But that is what uses the most and creates the most instances.

but i'd like you to explain to me what exactly is " broken " about project insanity.

Originally Posted by Haptic

Error:
[spoil]

Code:

src\server\model\players\packets\MagicOnFloorItems.java:33: error: cannot find s
ymbol
                if ((((c.getItems().freeSlots() >= 1) || c.getItems().playerHasI
tem(itemId, 1)) && Item.itemStackable[itemId]) || ((c.getItems().freeSlots() > 0
) && !Item.itemStackable[itemId])) {

                   ^
  symbol:   variable Item
  location: class MagicOnFloorItems
src\server\model\players\packets\MagicOnFloorItems.java:33: error: cannot find s
ymbol
                if ((((c.getItems().freeSlots() >= 1) || c.getItems().playerHasI
tem(itemId, 1)) && Item.itemStackable[itemId]) || ((c.getItems().freeSlots() > 0
) && !Item.itemStackable[itemId])) {


      ^
  symbol:   variable Item
  location: class MagicOnFloorItems
src\server\model\players\packets\MagicOnFloorItems.java:56: error: local variabl
e itemX is accessed from within inner class; needs to be declared final
                                                        if(Server.itemHandler.it
emExists(c.teleGrabItem, c.teleGrabX, c.teleGrabY) && c.goodDistance(c.getX(), c
.getY(), itemX, itemY, 12)) {


         ^
src\server\model\players\packets\MagicOnFloorItems.java:56: error: local variabl
e itemY is accessed from within inner class; needs to be declared final
                                                        if(Server.itemHandler.it
emExists(c.teleGrabItem, c.teleGrabX, c.teleGrabY) && c.goodDistance(c.getX(), c
.getY(), itemX, itemY, 12)) {


                ^
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
4 errors
Press any key to continue . . .

[/spoil]

Code:
[spoil]

Code:

package server.model.players.packets;
import server.Server;
import server.model.players.Client;
import server.model.players.PacketType;
import server.event.CycleEvent;
import server.event.CycleEventContainer;
import server.event.CycleEventHandler;

/**
 * Magic on floor items
 **/
public class MagicOnFloorItems implements PacketType {

	@Override
	public void processPacket(final Client c, int packetType, int packetSize) {
		int itemY = c.getInStream().readSignedWordBigEndian();
		int itemId = c.getInStream().readUnsignedWord();
		int itemX = c.getInStream().readSignedWordBigEndian();
		int spellId = c.getInStream().readUnsignedWordA();

		if(!Server.itemHandler.itemExists(itemId, itemX, itemY)) {
			c.stopMovement();
			return;
		}
		c.usingMagic = true;
		if(!c.getCombat().checkMagicReqs(51)) {
			c.stopMovement();
			return;
		}
				/*
		 * Telegrab spell
		 */
		if ((((c.getItems().freeSlots() >= 1) || c.getItems().playerHasItem(itemId, 1)) && Item.itemStackable[itemId]) || ((c.getItems().freeSlots() > 0) && !Item.itemStackable[itemId])) {
			if(c.goodDistance(c.getX(), c.getY(), itemX, itemY, 12)) {
				c.walkingToItem = true;
				int offY = (c.getX() - itemX) * -1;
				int offX = (c.getY() - itemY) * -1;
				c.teleGrabX = itemX;
				c.teleGrabY = itemY;
				c.teleGrabItem = itemId;
				c.turnPlayerTo(itemX, itemY);
				c.teleGrabDelay = System.currentTimeMillis();
				c.startAnimation(c.MAGIC_SPELLS[51][2]);
				c.gfx100(c.MAGIC_SPELLS[51][3]);
				c.getPA().createPlayersStillGfx(144, itemX, itemY, 0, 72);
				c.getPA().createPlayersProjectile(c.getX(), c.getY(), offX, offY, 50, 70, c.MAGIC_SPELLS[51][4], 50, 10, 0, 50);
				c.getPA().addSkillXP(c.MAGIC_SPELLS[51][7], 6);
				c.getPA().refreshSkill(6);
				c.stopMovement();
				CycleEventHandler.getSingleton().addEvent(c, new CycleEvent() {
					@Override
					public void execute(CycleEventContainer container) {
						if(!c.walkingToItem)
							container.stop();
						if(System.currentTimeMillis() - c.teleGrabDelay > 1550 && c.usingMagic) {
							if(Server.itemHandler.itemExists(c.teleGrabItem, c.teleGrabX, c.teleGrabY) && c.goodDistance(c.getX(), c.getY(), itemX, itemY, 12)) {
								Server.itemHandler.removeGroundItem(c, c.teleGrabItem, c.teleGrabX, c.teleGrabY, true);
								c.usingMagic = false;
								container.stop();
							}
						}
					}
					@Override
					public void stop() {
						c.walkingToItem = false;
					}
				}, 1);
			}
		} else {
			c.sendMessage("You don't have enough space in your inventory.");
			c.stopMovement();
		}
		/*if(c.goodDistance(c.getX(), c.getY(), itemX, itemY, 12)) {
			int offY = (c.getX() - itemX) * -1;
			int offX = (c.getY() - itemY) * -1;
			c.teleGrabX = itemX;
			c.teleGrabY = itemY;
			c.teleGrabItem = itemId;
			c.turnPlayerTo(itemX, itemY);
			c.teleGrabDelay = System.currentTimeMillis();
			c.startAnimation(c.MAGIC_SPELLS[51][2]);
			c.gfx100(c.MAGIC_SPELLS[51][3]);
			c.getPA().createPlayersStillGfx(144, itemX, itemY, 0, 72);
			c.getPA().createPlayersProjectile(c.getX(), c.getY(), offX, offY, 50, 70, c.MAGIC_SPELLS[51][4], 50, 10, 0, 50);
			c.getPA().addSkillXP(c.MAGIC_SPELLS[51][7], 6);
			c.getPA().refreshSkill(6);
			c.stopMovement();
		}*/
	}

}

[/spoil]

Tried the above and didn't work.

parameter c to final c

Hey man love this work. But however important things;
That duel thing that handles the FIGHT force chat & being able to attack does not work. It will work for other player but not for you.
Second, traderesetneeded causes a DUPE.
Trade someone an item, after the trade is done relog. You will receive the item and he will aswell.
You should consider fixing these, thanks.