[PI] Improvements - Cleaning/Converting Process to Events.

Nice job, and using events would be better imo.

Code:

src\server\model\players\packets\ClickObject.java:223: local variable c is acces sed from within inner class; needs to be declared final if(c.clickObjectType == 1 && c.g oodDistance(c.objectX + c.objectXOffset, c.objectY + c.objectYOffset, c.getX(), c.getY(), c.objectDistance)) { ^ src\server\model\players\packets\ClickObject.java:223: local variable c is acces sed from within inner class; needs to be declared final if(c.clickObjectType == 1 && c.g oodDistance(c.objectX + c.objectXOffset, c.objectY + c.objectYOffset, c.getX(), c.getY(), c.objectDistance)) { ^ src\server\model\players\packets\ClickObject.java:223: local variable c is acces sed from within inner class; needs to be declared final if(c.clickObjectType == 1 && c.g oodDistance(c.objectX + c.objectXOffset, c.objectY + c.objectYOffset, c.getX(), c.getY(), c.objectDistance)) { ^ src\server\model\players\packets\ClickObject.java:223: local variable c is acces sed from within inner class; needs to be declared final if(c.clickObjectType == 1 && c.g oodDistance(c.objectX + c.objectXOffset, c.objectY + c.objectYOffset, c.getX(), c.getY(), c.objectDistance)) { ^ src\server\model\players\packets\ClickObject.java:223: local variable c is acces sed from within inner class; needs to be declared final if(c.clickObjectType == 1 && c.g oodDistance(c.objectX + c.objectXOffset, c.objectY + c.objectYOffset, c.getX(), c.getY(), c.objectDistance)) { ^ src\server\model\players\packets\ClickObject.java:223: local variable c is acces sed from within inner class; needs to be declared final if(c.clickObjectType == 1 && c.g oodDistance(c.objectX + c.objectXOffset, c.objectY + c.objectYOffset, c.getX(), c.getY(), c.objectDistance)) { ^ src\server\model\players\packets\ClickObject.java:223: local variable c is acces sed from within inner class; needs to be declared final if(c.clickObjectType == 1 && c.g oodDistance(c.objectX + c.objectXOffset, c.objectY + c.objectYOffset, c.getX(), c.getY(), c.objectDistance)) { ^ src\server\model\players\packets\ClickObject.java:223: local variable c is acces sed from within inner class; needs to be declared final if(c.clickObjectType == 1 && c.g oodDistance(c.objectX + c.objectXOffset, c.objectY + c.objectYOffset, c.getX(), c.getY(), c.objectDistance)) { ^ src\server\model\players\packets\ClickObject.java:223: local variable c is acces sed from within inner class; needs to be declared final if(c.clickObjectType == 1 && c.g oodDistance(c.objectX + c.objectXOffset, c.objectY + c.objectYOffset, c.getX(), c.getY(), c.objectDistance)) { ^ src\server\model\players\packets\ClickObject.java:224: local variable c is acces sed from within inner class; needs to be declared final c.getActions().firstClic kObject(c.objectId, c.objectX, c.objectY); ^ src\server\model\players\packets\ClickObject.java:224: local variable c is acces sed from within inner class; needs to be declared final c.getActions().firstClic kObject(c.objectId, c.objectX, c.objectY); ^ src\server\model\players\packets\ClickObject.java:224: local variable c is acces sed from within inner class; needs to be declared final c.getActions().firstClic kObject(c.objectId, c.objectX, c.objectY); ^ src\server\model\players\packets\ClickObject.java:224: local variable c is acces sed from within inner class; needs to be declared final c.getActions().firstClic kObject(c.objectId, c.objectX, c.objectY); ^ src\server\model\players\packets\ClickObject.java:227: local variable c is acces sed from within inner class; needs to be declared final if(c.clickObjectType > 1 || c.cl ickObjectType == 0) ^ src\server\model\players\packets\ClickObject.java:227: local variable c is acces sed from within inner class; needs to be declared final if(c.clickObjectType > 1 || c.cl ickObjectType == 0) ^ src\server\model\players\packets\ClickObject.java:232: local variable c is acces sed from within inner class; needs to be declared final c.clickObjectType = 0; ^ Note: Some input files use unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. 16 errors Press any key to continue . . .

How do i go about solving these? Iv tryed declaring the ObjectType's as ints and it then tells me that it wants another identifyer? Am i missing something really easy here :P

c has to be final.

Code:

public void processPacket(final Client c, int packetType, int packetSize) {

Quote:

Originally Posted by Creator [Only registered and activated users can see links. Click Here To Register...]

c has to be final.

Code:

public void processPacket(final Client c, int packetType, int packetSize) {

Thank you, Got it sorted :)

No problem

Nice job.

Thanks for the feedback everyone :)

Quote:

Originally Posted by Ambient [Only registered and activated users can see links. Click Here To Register...]

Nice netzo <3 I added to my tut thread :hurr:
Also about the comment earlier, how would I go about changing the rate in which shit is executed in process thread?

Only problem I can see people getting is step 3, a lot of typin :)

public static final int CYCLE_TIME = 600; in Config.java? :)

Quote:

Originally Posted by 1776 [Only registered and activated users can see links. Click Here To Register...]

What's the point you still are running them in process.

So a better idea would be to put everything into process instead of calling it when it's needed?

Quote:

Originally Posted by D R O [Only registered and activated users can see links. Click Here To Register...]

Nice job, and using events would be better imo.

Could you please explain why it is better, because I see no improvement over using process(). All this does is move from client.process to the server loop which is the same thing... :rofl:

Server => PlayerHandler => Loops through all players online => Player Process()

I've handled teleporting and combat events as well :)

omg repped !