Thread: [#181] RS Mod - Let's Do This Together

Originally Posted by Arravs

180 Update Friend List Snippet. I can't submit a PR to the repo.

Code:

- message: gg.rsmod.game.message.impl.LoadFriendListMessage
    type: VARIABLE_SHORT
    opcode: 58
    structure:
      - name: online
        type: BYTE
      - name: username
        type: BYTES
      - name: previousUsername
        type: BYTES
      - name: world
        type: SHORT

Code:

package gg.rsmod.game.message.encoder;

import gg.rsmod.game.message.MessageEncoder
import gg.rsmod.game.message.impl.LoadFriendListMessage

class LoadFriendListEncoder : MessageEncoder<LoadFriendListMessage>() {
    override fun extract(message: LoadFriendListMessage, key: String): Number = when (key) {
        "online" -> message.online
        "world" -> message.world
        else -> throw Exception("Unhandled value key.")
    }

    override fun extractBytes(message: LoadFriendListMessage, key: String): ByteArray = when(key) {
        "username" -> {
            if (message.username != null) {
                val data = ByteArray(message.username.length + 1)
                System.arraycopy(message.username.toByteArray(), 0, data, 0, data.size - 1)
                data[data.size - 1] = 0
                data
            } else {
                ByteArray(0)
            }
        }
        "previousUsername" -> {
            if (message.previousUsername != null) {
                val data = ByteArray(message.previousUsername.length + 1)
                System.arraycopy(message.previousUsername.toByteArray(), 0, data, 0, data.size - 1)
                data[data.size - 1] = 0
                data
            } else {
                ByteArray(0)
            }
        }
        else -> throw Exception("Unhandled value key.")
    }

}

were you going to post the actual "LoadFriendListMessage" class or is that for us to figure out?
Sorry im all new to this Kotlin stuff

Very cool project! Keep it up!

Amazing contribution, its a shame progress has stopped.

Originally Posted by Gallus

I launch the server and get this error.

Code:

Caused by: java.lang.IllegalStateException: Option "pickpocket" not found for npc 5298 [options=[]]

I looked in the class that cause the error, and there is no 5298 id anywhere. Not sure what is causing that.

I just moved the thieving plugin out of the source and it loads fine.


Any help is appreciated!

NPC ids were moved around in some recent revision and the RSMod `on_npc_option` event will throw errors when an npc you've referenced doesn't have the context menu option you've asked to bind.

The error is telling you that npc id 5298 doesn't have a "pickpocket" context menu option and so binding the pickpocket action to this npc isn't possible. Most likely that npc has a different id now, you need to find it and change the config.

See here:
1. The npc 5298 reference `Npcs.YSGAWYN`: [Only registered and activated users can see links. ]
2. Proof of the npc id: [Only registered and activated users can see links. ]
3. Where the pickpocket option is being bound to the npc: [Only registered and activated users can see links. ]