Best of luck on this, would be cool to see this open source and active with a few solid contributors.
|
Best of luck man, looks interesting
Best of luck on this, would be cool to see this open source and active with a few solid contributors.
There have been a good thousand commits or so to the main repo since the version that you're using. While most of that is new features and things like that, there is also a lot of major and minor bug fixes, core improvements, networking upgrades, and so on. Ruby has been phased out for a much nicer system using Kotlin script. Overall, it's just significantly better than it was in the past—it's a lot more fleshed out. And, I wouldn't want to be the one trying to back port the important changes.
Even if the goal isn't for others to use it, for your own sake, when you have the time and opportunity, I would try and get this project moved to a more current version; it'll be worth it.
On another note, you've still got unnecessary files that you shouldn't be committing. For example, in the "/bin/" directory, you've created a .gitignore file, but it is only ignoring Apollo class files; libraries, like the Isaac random, are still being included. For your own sanity, you might want to use a tool to help you cover all the important bases in your gitignore and then add the RuneScape specific things from there (e.g., *.dat, *.idx*, etc).
https://www.gitignore.io/
Oh, and, one more thing. I am not sure why you've picked GPL as your license, but my assumption is that it's probably not the best choice for you. The problem with GPL is that for the whole "must publish source code" stipulation to kick in, you have to distribute the server - e.g., distribute a binary form of the server. And, under the GPL, network usage does not count as distribution.
If you want people who make use of this to have to contribute back to the community, you're probably looking for something like the AGPL instead as it takes into account the networked aspect.
goodluck, looks interesting. hope there will be helpers on the way.
Thanks for the suggestions, but I still stand by my decision to use my current iteration of Apollo as it fits my needs at this present time. If I run into any major issues, I'll be sure to take a look at the current public repository of Apollo by Major.
However, I think some people are missing the point of the public code on this project, and that's just to show some progress on my attempt to learn RuneScape protocol, which is something I haven't dived into, and making the code (or some of it) public was a last minute decision, all Git errors and mistakes aside. My focus isn't on the public code nor who would contribute or use it, it's just a benchmark for those to take a look at Apollo for the 400~+ cache revision protocol, and to provide a layer of proof that I'm doing what I'm claiming to do. This project in of itself isn't meant to be fully public, and gathering collaborators isn't the projects goal.
This isn't directed entirely at you, but to anyone who might have concerns about what this project is. Thanks for your time, I'll clean up the public repository once I'm ready to commit the next batch of packets and cache handling.
take a look, see that there have been thousands of commits and you probably should have kept up to date, decide that individually backporting all the fixes is far too much work, be stuck on your old version with the issues..?
You really should keep up to date, this martyrdom around choosing something that is out-of-date is very odd
« Previous Thread | Next Thread » |
Thread Information |
Users Browsing this ThreadThere are currently 1 users browsing this thread. (0 members and 1 guests) |