PickUp not working

I'm a noob, sorry for all the questions.

EDIT: I have been able to add the item to the player but the item on the ground still remains, and unable to pick up again (which is good as thats what its meant to do). However, I can't seem to
remove the item after picking up

GlobalDropsHandler.java

Code:

---

public static void pickup(Client client, int itemId, int itemX, int itemY, int itemH) {
                GlobalDrop drop = itemExists(itemId, itemX, itemY, itemH);
                if (drop == null) {
                        return;
                }
                if (drop.isTaken()) {
                        return;
                }
                drop.setTakenAt(System.currentTimeMillis());
                drop.setTaken(true);
                if (client.getItemAssistant().freeSlots() > 0) {
                        System.out.println("pick up item"); //This prints on first time i pick up the item, but not after (which means it works but the model remains)
                        client.getItemAssistant().addItem(drop.getId(), drop.getAmount());
                        client.getActionSender().removeGroundItem(drop.getId(), drop.getX(), drop.getY(), drop.getAmount(),drop.getH());
                        globalDrops.remove(drop);
                }
                for (Player player : PlayerHandler.players) {
                        Client cl = (Client) player;
                        if (cl != null) {
                                if (cl.distanceToPoint(drop.getX(), drop.getY()) <= 60) {
                                        cl.getActionSender().removeGroundItem(drop.getId(), drop.getX(), drop.getY(), drop.getAmount(),drop.getH());
                                }
                        }
                }
        }

---

In the PickUpItem.java

Code:

---

public class PickupItem implements PacketType {


        @Override
        public void processPacket(final Client player, int packetType, int packetSize) {
                player.pItemY = player.getInStream().readSignedWordBigEndian();
                player.pItemId = player.getInStream().readUnsignedWord();
                player.pItemX = player.getInStream().readSignedWordBigEndian();
               
                System.out.println("Step 1 - start pick up packet");
                GlobalDropsHandler.pickup(player, player.pItemId, player.pItemX, player.pItemY, player.heightLevel);

---

Then in the ActionSender.java

Code:

---

       
        public ActionSender removeGroundItem(int itemID, int itemX, int itemY, int Amount, int height) {
                if (player == null) {
                        return this;
                }
                player.getOutStream().createFrame(85);
                player.getOutStream().writeByteC(itemY - 8 * player.mapRegionY);
                player.getOutStream().writeByteC(itemX - 8 * player.mapRegionX);
                player.getOutStream().createFrame(156);
                player.getOutStream().writeByteS(height);
                player.getOutStream().writeWord(itemID);
                player.flushOutStream();
                return this;
        }

---

I've toiled away at this without much success. Any guidance would be appreciated.

Thanks.

I'm wondering how come you don't have item pickup handled already.

Have you got the packet in place and is it being called?

If so, then just keep adding printouts starting from the pickup packet and see how far it gets. This way you will find out where it fails.

Code:

---

System.out.println("Step 1");

---

Quote:

---

Originally Posted by Blaketon [Only registered and activated users can see links. Click Here To Register...]

I'm wondering how come you don't have item pickup handled already.

Have you got the packet in place and is it being called?

If so, then just keep adding printouts starting from the pickup packet and see how far it gets. This way you will find out where it fails.

Code:

---

System.out.println("Step 1");

---

---

When you say "already" what should I have? I thought thats what the itemhandler does, plus the globalitemshandler does.

Code:

---

        public static void pickup(Client client, int a, int b, int c, int d) {
                GlobalDrop drop = itemExists(a, b, c, d); //Check whether it actually exists.

---

please refactor this my god. Also, what is the exact issue im confused? Is it not going to the players inventory? Is it not disappearing from the ground?

Code:

---

                if (drop == null) {
                        return;
                }
                else {
                        System.out.println("Item Exists!"); //Test statement
                }
                if (drop.isTaken()) {  //If the drop is taken
                        return;
                }

---

this is also top tier

it would be nice to NEVER name ur variables 1 letter long unless inside a for loop

Quote:

---

Originally Posted by Melvin [Only registered and activated users can see links. Click Here To Register...]

Code:

---

        public static void pickup(Client client, int a, int b, int c, int d) {
                GlobalDrop drop = itemExists(a, b, c, d); //Check whether it actually exists.

---

please refactor this my god. Also, what is the exact issue im confused? Is it not going to the players inventory? Is it not disappearing from the ground?

Code:

---

                if (drop == null) {
                        return;
                }
                else {
                        System.out.println("Item Exists!"); //Test statement
                }
                if (drop.isTaken()) {  //If the drop is taken
                        return;
                }

---

this is also top tier

---

My bad I have edited the post. I have fixed some of the issues, but having problems with removing the item in game, even though the player has the item in the inventory after pick up

Quote:

---

Originally Posted by Optimum [Only registered and activated users can see links. Click Here To Register...]

it would be nice to NEVER name ur variables 1 letter long unless inside a for loop

---

I updated the thread

Quote:

---

Originally Posted by gilbo184 [Only registered and activated users can see links. Click Here To Register...]

My bad I have edited the post. I have fixed some of the issues, but having problems with removing the item in game, even though the player has the item in the inventory after pick up



I updated the thread

---

Is the player able to pick up the item more than once?

Any errors client sided?

Quote:

---

Originally Posted by gilbo184 [Only registered and activated users can see links. Click Here To Register...]

My bad I have edited the post. I have fixed some of the issues, but having problems with removing the item in game, even though the player has the item in the inventory after pick up



I updated the thread

---

thanks, the constructor could also just be Item item, and then below just do (item.getId(), item.getX(), item.getY(), item.getHeight())

Code:

---

globalDrops.remove(drop);

---

check this, its not removing from the region. No idea what globalDrops is, but probably a list used in your region class.

Quote:

---

Originally Posted by Tyluur [Only registered and activated users can see links. Click Here To Register...]

Is the player able to pick up the item more than once?

---

Nope, once i log in, I can pick the item up once, and then not again.

Quote:

---

Originally Posted by Melvin [Only registered and activated users can see links. Click Here To Register...]

thanks, the constructor could also just be Item item, and then below just do (item.getId(), item.getX(), item.getY(), item.getHeight())

Code:

---

globalDrops.remove(drop);

---

check this, its not removing from the region. No idea what globalDrops is, but probably a list used in your region class.

---

globalDrops is just a list of all the global drops. So a file called globalDrops.txt loads in the global drops. Region updating does work.

I think I may have an issue with understanding the true difference between the ItemHandler and the GlobalDropHandler. This is the load method for changing regions in my GlobalDropHandler.

Code:

---

/**
        * Loads all the items when a player changes region
        *
        * @[Only registered and activated users can see links. Click Here To Register...] client
        *            the client
        */
        public static void load(Client client) {
                for (GlobalDrop drop : globalDrops) {
                        if (!drop.isTaken()) {
                                if (client.distanceToPoint(drop.getX(), drop.getY()) <= 60) {
                                        client.getActionSender().createGroundItem(drop.getId(), drop.getX(), drop.getY(), drop.getAmount(), drop.getH());
                                }
                        }
                }
        }

---

Quote:

---

Originally Posted by Blaketon [Only registered and activated users can see links. Click Here To Register...]

Any errors client sided?

---

No that I am aware of. There is no errors printing, only that the item remains on the ground even though its been added to my inventory

Quote:

---

Originally Posted by gilbo184 [Only registered and activated users can see links. Click Here To Register...]

Nope, once i log in, I can pick the item up once, and then not again.



globalDrops is just a list of all the global drops. So a file called globalDrops.txt loads in the global drops. Region updating does work.

I think I may have an issue with understanding the true difference between the ItemHandler and the GlobalDropHandler. This is the load method for changing regions in my GlobalDropHandler.

Code:

---

/**
        * Loads all the items when a player changes region
        *
        * @[Only registered and activated users can see links. Click Here To Register...] client
        *            the client
        */
        public static void load(Client client) {
                for (GlobalDrop drop : globalDrops) {
                        if (!drop.isTaken()) {
                                if (client.distanceToPoint(drop.getX(), drop.getY()) <= 60) {
                                        client.getActionSender().createGroundItem(drop.getId(), drop.getX(), drop.getY(), drop.getAmount(), drop.getH());
                                }
                        }
                }
        }

---

No that I am aware of. There is no errors printing, only that the item remains on the ground even though its been added to my inventory

---

Sounds like it's not sending the packet to the client correctly.

Quote:

---

Originally Posted by Tyluur [Only registered and activated users can see links. Click Here To Register...]

Sounds like it's not sending the packet to the client correctly.

---

Can you confirm that I am doing this in the correct class.

I have an itemHandler and GlobalDropsHandler class, which both really do the same thing. I'm assuming that itemHandler would be more for when I drop items or anything that isnt a tick bases such as if a player drops it and other players cant see etc.

GlobalDropsHandler is more dealing with the global drops, and when it is removed, it needs to respawn.

Quote:

---

Originally Posted by gilbo184 [Only registered and activated users can see links. Click Here To Register...]

Can you confirm that I am doing this in the correct class.

I have an itemHandler and GlobalDropsHandler class, which both really do the same thing. I'm assuming that itemHandler would be more for when I drop items or anything that isnt a tick bases such as if a player drops it and other players cant see etc.

GlobalDropsHandler is more dealing with the global drops, and when it is removed, it needs to respawn.

---

I'd do some debugging if i were you

Quote:

---

Originally Posted by Tyluur [Only registered and activated users can see links. Click Here To Register...]

I'd do some debugging if i were you

---

I have been doing some debugging. I have found that everything works fine. For example I was testing createGroundItem, and when an item is dropped it begins the tick timer for other players to see etc and the item is added to the item list which is called every game tick. However, the item doesnt appear when i drop it. So this leads to the ActionSender. Does this look correct?

Code:

---

public ActionSender createGroundItem(int itemID, int itemX, int itemY, int itemAmount, int height) {
                if (player.heightLevel != height) {
                        return this;
                }
                player.getOutStream().createFrame(85);
                player.getOutStream().writeByteC(itemY - 8 * player.mapRegionY);
                player.getOutStream().writeByteC(itemX - 8 * player.mapRegionX);
                player.getOutStream().createFrame(44);
                player.getOutStream().writeWordBigEndianA(itemID);
                player.getOutStream().writeWord(itemAmount);
                player.getOutStream().writeByte(height);
                player.flushOutStream();
                return this;
        }

---

Quote:

---

Originally Posted by gilbo184 [Only registered and activated users can see links. Click Here To Register...]

I have been doing some debugging. I have found that everything works fine. For example I was testing createGroundItem, and when an item is dropped it begins the tick timer for other players to see etc and the item is added to the item list which is called every game tick. However, the item doesnt appear when i drop it. So this leads to the ActionSender. Does this look correct?

Code:

---

public ActionSender createGroundItem(int itemID, int itemX, int itemY, int itemAmount, int height) {
                if (player.heightLevel != height) {
                        return this;
                }
                player.getOutStream().createFrame(85);
                player.getOutStream().writeByteC(itemY - 8 * player.mapRegionY);
                player.getOutStream().writeByteC(itemX - 8 * player.mapRegionX);
                player.getOutStream().createFrame(44);
                player.getOutStream().writeWordBigEndianA(itemID);
                player.getOutStream().writeWord(itemAmount);
                player.getOutStream().writeByte(height);
                player.flushOutStream();
                return this;
        }

---

---

I don't know the packet structure - use some breakpoints to see where it fails.

Quote:

---

Originally Posted by Tyluur [Only registered and activated users can see links. Click Here To Register...]

I don't know the packet structure - use some breakpoints to see where it fails.

---

After some more debugging, items that i drop appear on the ground, and items i pick up are removed from hte ground (only the dropped ones). I think there is an issue with loading the global drops because they all appear in 2's, instead of 1. This is how it is intialised on load up:

Code:

---

        /**
        * loads the items
        */
        public static void initialize() {
                String Data;
                BufferedReader Checker;
                try {
                        Checker = new BufferedReader(new FileReader(
                                        "./Data/cfg/globaldrops.txt"));
                        while ((Data = Checker.readLine()) != null) {
                                if (Data.startsWith("#")) {
                                        continue;
                                }
                                String[] args = Data.split(":");
                                getGlobalDrops().add(new GlobalDrop(Integer.parseInt(args[0]), // id
                                                                                          Integer.parseInt(args[1]), //amount
                                                                                          Integer.parseInt(args[2]), //x
                                                                                          Integer.parseInt(args[3]), //y
                                                                                          Integer.parseInt(args[4]))); //height
                        }
                        Checker.close();
                } catch (Exception e) {
                        e.printStackTrace();
                }
                Misc.println("Loaded " + getGlobalDrops().size() + " global drops.");

        for (Player player : PlayerHandler.players) {
                final Client client = (Client) player;
                if (client != null) {
                  CycleEventHandler.getSingleton().addEvent(client, new CycleEvent() {
                    @Override
                    public void execute(CycleEventContainer container) {
                                for (GlobalDrop drop : getGlobalDrops()) {
                                        if (drop.isTaken()) {
                                                if (System.currentTimeMillis() - drop.getTakenAt() >= TIME_TO_RESPAWN * 1000) {
                                                        drop.setTaken(false);
                                                                if (client.distanceToPoint(drop.getX(), drop.getY()) <= 60) {
                                                                        System.out.println(drop.getId());
                                                                        client.getActionSender().createGroundItem(drop.getId(), drop.getX(), drop.getY(), drop.getH(),drop.getAmount());
                                                                }
                                                        }
                                                }
                                        }
                                }
                    @Override
                                public void stop() {
                                        // TODO Auto-generated method stub
                                }
                                }, 1);
                        }
                }
        }

---