[Kronos] Sound system

Sounds system are working here, but, it seems like

"equipSound" isn't working in-game? - In weapon_types.json all the "equipSound" doesn't working there.

Also attackSound is working in game but I tried to add for scimitar another attacksound for "lunge" it wont let me for ex:

Code:

---

"SCIMITAR": {
    "config": 9,
    "maxDistance": 1,
    "attackTicks": 4,
    "attackAnimation": 390,
    "defendAnimation": 388,
    "equipSound": 2242,
    "attackSound": 2500,
    "attackSets": [
      {
        "child": 3,
        "type": "ACCURATE",
        "style": "SLASH"
      },
      {
        "child": 7,
        "type": "AGGRESSIVE",
        "style": "SLASH"
      },
      {
        "child": 11,
        "type": "CONTROLLED",
        "style": "STAB",
        "attackSound": 2501
        "attackAnimation": 386
      },
      {
        "child": 15,
        "type": "DEFENSIVE",
        "style": "SLASH"
      }
    ],

---

Any ideas?

Same problem

Code:

---

"SCIMITAR": {
    "config": 9,
    "maxDistance": 1,
    "attackTicks": 4,
    "attackAnimation": 390,
    "defendAnimation": 388,
    "equipSound": 2242, - UNUSED
    "attackSound": 2500, - USED
    "attackSets": [
      {
        "child": 3,
        "type": "ACCURATE",
        "style": "SLASH"
      },
      {
        "child": 7,
        "type": "AGGRESSIVE",
        "style": "SLASH"
      },
      {
        "child": 11,
        "type": "CONTROLLED",
        "style": "STAB",
        "attackSound": 2501, - UNUSED
        "attackAnimation": 386
      },
      {
        "child": 15,
        "type": "DEFENSIVE",
        "style": "SLASH"
      }
    ],

---

Quote:

---

Originally Posted by Brandito [Only registered and activated users can see links. Click Here To Register...]

Code:

---

"SCIMITAR": {
    "config": 9,
    "maxDistance": 1,
    "attackTicks": 4,
    "attackAnimation": 390,
    "defendAnimation": 388,
    "equipSound": 2242, - UNUSED
    "attackSound": 2500, - USED
    "attackSets": [
      {
        "child": 3,
        "type": "ACCURATE",
        "style": "SLASH"
      },
      {
        "child": 7,
        "type": "AGGRESSIVE",
        "style": "SLASH"
      },
      {
        "child": 11,
        "type": "CONTROLLED",
        "style": "STAB",
        "attackSound": 2501, - UNUSED
        "attackAnimation": 386
      },
      {
        "child": 15,
        "type": "DEFENSIVE",
        "style": "SLASH"
      }
    ],

---

---

You don't need to tell me what used and what unUsed bro, I already know that. I am looking to make them all used. so please if u know how let me know and I will thank you + repp+.

Quote:

---

Originally Posted by Ilgaz [Only registered and activated users can see links. Click Here To Register...]

You don't need to tell me what used and what unUsed bro, I already know that. I am looking to make them all used. so please if u know how let me know and I will thank you + repp+.

---

It's because sounds were never added. I just added it for you.. Know that this is only for weapon equips, not for wearing armor/robes that's another story, I'll see if I can get that but for now. Replace your io.ruin.model.item.containers > Equipment.java with this:

Code:

---


package io.ruin.model.item.containers;

import io.ruin.cache.Color;
import io.ruin.cache.ItemDef;
import io.ruin.model.activities.duelarena.DuelRule;
import io.ruin.model.combat.RangedWeapon;
import io.ruin.model.inter.Interface;
import io.ruin.model.inter.handlers.EquipmentStats;
import io.ruin.model.item.Item;
import io.ruin.model.item.ItemContainer;
import io.ruin.model.item.actions.impl.MaxCape;
import io.ruin.model.item.actions.impl.chargable.Blowpipe;
import io.ruin.model.item.attributes.AttributeExtensions;
import io.ruin.model.skills.construction.actions.CombatRoom;
import io.ruin.model.stat.Stat;
import io.ruin.model.stat.StatType;

import java.util.Map;

public class Equipment extends ItemContainer {

    public static final int SLOT_HAT = 0, SLOT_CAPE = 1, SLOT_AMULET = 2, SLOT_WEAPON = 3, SLOT_CHEST = 4,
            SLOT_SHIELD = 5, SLOT_LEGS = 7, SLOT_HANDS = 9, SLOT_FEET = 10, SLOT_RING = 12, SLOT_AMMO = 13;

    public int[] bonuses = new int[16];

    public double weight;

    public void equip(Item selectedItem) {
        ItemDef selectedDef = selectedItem.getDef();

        int equipSound = -1;
        if(selectedDef != null && selectedDef.weaponType != null) {
            equipSound = selectedDef.weaponType.equipSound;
        }

        int equipSlot = selectedDef.equipSlot;
        if(equipSlot == -1 || selectedDef.equipOption == -1) {
            player.sendMessage("You can't wear this item.");
            return;
        }
        if(selectedDef.equipReqs != null) {
            for(int req : selectedDef.equipReqs) {
                int statId = req >> 8;
                int lvl = req & 0xff;
                Stat stat = player.getStats().get(statId);
                if(stat.fixedLevel < lvl) {
                    player.sendMessage("You need " + StatType.get(statId).descriptiveName + " level of " + lvl + " to equip this item.");
                    return;
                }
            }
        }
        if(selectedDef.maxType && !MaxCape.unlocked(player)) {
            player.sendMessage("You don't have the required stats to wear this.");
            return;
        }

        if(player.getDuel().isBlocked(selectedDef)) {
            player.sendMessage("That item cannot be equipped in this duel!");
            return;
        }

        if(player.getDuel().isToggled(DuelRule.NO_WEAPON_SWITCH) && equipSlot == Equipment.SLOT_WEAPON) {
            player.sendMessage("Weapon switching is disabled for this fight!");
            return;
        }

        if(!CombatRoom.allowEquip(player, selectedDef)) {
            return;
        }

        if(selectedDef.achievement != null && !selectedDef.achievement.isFinished(player) && (!selectedDef.achievementReqIsIronmanOnly || player.getGameMode().isIronMan())) {
            player.sendMessage("You must complete the " + Color.RED.wrap(selectedDef.achievement.getListener().name()) + " achievement to equip this item.");
            return;
        }

        if(selectedDef.name.toLowerCase().contains("goblin mail")) {
            player.sendMessage("You can't wear this item.");
            return;
        }

        Item addLast = null;
        Inventory inventory = player.getInventory();
        if(equipSlot == SLOT_SHIELD) {
            Item weapon = get(SLOT_WEAPON);
            if(weapon != null) {
                if(weapon.getDef().twoHanded) {
                    if(inventory.getFreeSlots() == 0 && get(SLOT_SHIELD) != null) {
                        player.sendMessage("You don't have enough free inventory space to do that.");
                        return;
                    }
                    addLast = weapon;
                    set(SLOT_WEAPON, null);
                }
            }
        } else if(equipSlot == SLOT_WEAPON) {
            Item shield = get(SLOT_SHIELD);
            if(shield != null) {
                if(selectedDef.twoHanded) {
                    if(inventory.getFreeSlots() == 0 && get(SLOT_WEAPON) != null) {
                        player.sendMessage("You don't have enough free inventory space to do that.");
                        return;
                    }
                    addLast = shield;
                    set(SLOT_SHIELD, null);
                }
            }
        }
        Item worn = get(equipSlot);
        if (worn == null) {
            selectedItem.remove();
            set(equipSlot, selectedItem);
        } else {
            int selectedId = selectedItem.getId();
            int selectedAmount = selectedItem.getAmount();
            Map<String, String> attributeCopy = selectedItem.copyOfAttributes();
            if(worn.getId() == selectedId && selectedDef.stackable) {
                selectedItem.remove();
                worn.incrementAmount(selectedAmount);
            } else {
                Item inventoryStack = null;
                Map<String, String> attributes = worn.copyOfAttributes();
                if (worn.getDef().stackable)
                    inventoryStack = inventory.findItem(worn.getId());
                if (inventoryStack != null) {
                    selectedItem.remove();
                    inventoryStack.incrementAmount(worn.getAmount());
                } else {
                    selectedItem.setId(worn.getId());
                    selectedItem.setAmount(worn.getAmount());
                    worn.clearAttributes();
                    worn.putAttributes(selectedItem.copyOfAttributes());
                }
                worn.setId(selectedId);
                worn.setAmount(selectedAmount);
                worn.putAttributes(attributeCopy);
                selectedItem.clearAttributes();
                selectedItem.putAttributes(attributes);
            }
        }
        if(addLast != null)
            inventory.add(addLast);
        if(!player.recentlyEquipped.isDelayed() && equipSlot == Equipment.SLOT_WEAPON) {
            player.recentlyEquipped.delay(1);
          // player.resetAnimation();
        }
        player.closeDialogue();
        if(equipSound != -1)
            player.privateSound(equipSound, 1, 0);
    }

    public boolean unequip(Item equipped) {
        Inventory inventory = player.getInventory();
        Item inventoryStack = null;
        if(equipped.getDef().stackable)
            inventoryStack = inventory.findItem(equipped.getId());
        if(inventoryStack != null) {
            equipped.remove();
            inventoryStack.incrementAmount(equipped.getAmount());
        } else {
            int freeSlot = inventory.freeSlot();
            if(freeSlot == -1) {
                player.sendMessage("You don't have enough free space to do that.");
                return false;
            }
            equipped.remove();
            inventory.set(freeSlot, equipped);
        }
        return true;
    }
    @Override
    public boolean sendUpdates() {
        int updatedAppearanceSlots = updatedCount;
        if(updatedSlots[SLOT_RING])
            updatedAppearanceSlots--;
        if(updatedSlots[SLOT_AMMO])
            updatedAppearanceSlots--;
        if(updatedSlots[SLOT_WEAPON])
            player.getCombat().updateWeapon(false);
        if(updatedAppearanceSlots > 0)
            player.getAppearance().update();
        if(!super.sendUpdates())
            return false;
        /**
        * Reset bonuses/weight
        */
        for(int i = 0; i < bonuses.length; i++)
            bonuses[i] = 0;
        weight = 0.0;
        /**
        * Calculate bonuses/weight
        */
        boolean ignoreRangedAmmoStr = false;
        Item wep = get(SLOT_WEAPON);
        if(wep != null) {
            if(wep.getId() == 12926) { //blowpipe
                Blowpipe.Dart dart = Blowpipe.getDart(wep);
                if(dart != Blowpipe.Dart.NONE) //should always be true
                    bonuses[EquipmentStats.RANGED_STRENGTH] += ItemDef.get(dart.id).equipBonuses[EquipmentStats.RANGED_STRENGTH];
                ignoreRangedAmmoStr = true;
            } else {
                RangedWeapon rangedWep = wep.getDef().rangedWeapon;
                ignoreRangedAmmoStr = rangedWep != null && rangedWep.allowedAmmo == null;
            }
        }
        for(Item item : getItems()) {
            if(item != null) {
                ItemDef def = item.getDef();
                if(def.equipBonuses != null) {
                    boolean wilderness = def.wilderness; //If its pvp armor
                    boolean inWilderness = player.wildernessLevel > 0 || player.tournament != null;
                    for(int i = 0; i < def.equipBonuses.length; i++) {
                        int bonus = def.equipBonuses[i];
                        if (bonus == 0)
                            continue;
                        if(ignoreRangedAmmoStr && def.equipSlot == SLOT_AMMO && i == EquipmentStats.RANGED_STRENGTH)
                            continue;
                        if (wilderness && !inWilderness)
                            bonus *= .75;
                        bonuses[i] += bonus;
                    }
                }
                weight += def.weightEquipment;
            }
        }
        /**
        * Update equipment stats interface
        */
        if(player.isVisibleInterface(Interface.EQUIPMENT_STATS))
            EquipmentStats.update(player);
        return true;
    }

    @Override
    public boolean hasId(int id) {
        return getId(ItemDef.get(id).equipSlot) == id;
    }

}

---

Quote:

---

Originally Posted by Armo [Only registered and activated users can see links. Click Here To Register...]

It's because sounds were never added. I just added it for you.. Know that this is only for weapon equips, not for wearing armor/robes that's another story, I'll see if I can get that but for now. Replace your io.ruin.model.item.containers > Equipment.java with this:

Code:

---


package io.ruin.model.item.containers;

import io.ruin.cache.Color;
import io.ruin.cache.ItemDef;
import io.ruin.model.activities.duelarena.DuelRule;
import io.ruin.model.combat.RangedWeapon;
import io.ruin.model.inter.Interface;
import io.ruin.model.inter.handlers.EquipmentStats;
import io.ruin.model.item.Item;
import io.ruin.model.item.ItemContainer;
import io.ruin.model.item.actions.impl.MaxCape;
import io.ruin.model.item.actions.impl.chargable.Blowpipe;
import io.ruin.model.item.attributes.AttributeExtensions;
import io.ruin.model.skills.construction.actions.CombatRoom;
import io.ruin.model.stat.Stat;
import io.ruin.model.stat.StatType;

import java.util.Map;

public class Equipment extends ItemContainer {

    public static final int SLOT_HAT = 0, SLOT_CAPE = 1, SLOT_AMULET = 2, SLOT_WEAPON = 3, SLOT_CHEST = 4,
            SLOT_SHIELD = 5, SLOT_LEGS = 7, SLOT_HANDS = 9, SLOT_FEET = 10, SLOT_RING = 12, SLOT_AMMO = 13;

    public int[] bonuses = new int[16];

    public double weight;

    public void equip(Item selectedItem) {
        ItemDef selectedDef = selectedItem.getDef();

        int equipSound = -1;
        if(selectedDef != null && selectedDef.weaponType != null) {
            equipSound = selectedDef.weaponType.equipSound;
        }

        int equipSlot = selectedDef.equipSlot;
        if(equipSlot == -1 || selectedDef.equipOption == -1) {
            player.sendMessage("You can't wear this item.");
            return;
        }
        if(selectedDef.equipReqs != null) {
            for(int req : selectedDef.equipReqs) {
                int statId = req >> 8;
                int lvl = req & 0xff;
                Stat stat = player.getStats().get(statId);
                if(stat.fixedLevel < lvl) {
                    player.sendMessage("You need " + StatType.get(statId).descriptiveName + " level of " + lvl + " to equip this item.");
                    return;
                }
            }
        }
        if(selectedDef.maxType && !MaxCape.unlocked(player)) {
            player.sendMessage("You don't have the required stats to wear this.");
            return;
        }

        if(player.getDuel().isBlocked(selectedDef)) {
            player.sendMessage("That item cannot be equipped in this duel!");
            return;
        }

        if(player.getDuel().isToggled(DuelRule.NO_WEAPON_SWITCH) && equipSlot == Equipment.SLOT_WEAPON) {
            player.sendMessage("Weapon switching is disabled for this fight!");
            return;
        }

        if(!CombatRoom.allowEquip(player, selectedDef)) {
            return;
        }

        if(selectedDef.achievement != null && !selectedDef.achievement.isFinished(player) && (!selectedDef.achievementReqIsIronmanOnly || player.getGameMode().isIronMan())) {
            player.sendMessage("You must complete the " + Color.RED.wrap(selectedDef.achievement.getListener().name()) + " achievement to equip this item.");
            return;
        }

        if(selectedDef.name.toLowerCase().contains("goblin mail")) {
            player.sendMessage("You can't wear this item.");
            return;
        }

        Item addLast = null;
        Inventory inventory = player.getInventory();
        if(equipSlot == SLOT_SHIELD) {
            Item weapon = get(SLOT_WEAPON);
            if(weapon != null) {
                if(weapon.getDef().twoHanded) {
                    if(inventory.getFreeSlots() == 0 && get(SLOT_SHIELD) != null) {
                        player.sendMessage("You don't have enough free inventory space to do that.");
                        return;
                    }
                    addLast = weapon;
                    set(SLOT_WEAPON, null);
                }
            }
        } else if(equipSlot == SLOT_WEAPON) {
            Item shield = get(SLOT_SHIELD);
            if(shield != null) {
                if(selectedDef.twoHanded) {
                    if(inventory.getFreeSlots() == 0 && get(SLOT_WEAPON) != null) {
                        player.sendMessage("You don't have enough free inventory space to do that.");
                        return;
                    }
                    addLast = shield;
                    set(SLOT_SHIELD, null);
                }
            }
        }
        Item worn = get(equipSlot);
        if (worn == null) {
            selectedItem.remove();
            set(equipSlot, selectedItem);
        } else {
            int selectedId = selectedItem.getId();
            int selectedAmount = selectedItem.getAmount();
            Map<String, String> attributeCopy = selectedItem.copyOfAttributes();
            if(worn.getId() == selectedId && selectedDef.stackable) {
                selectedItem.remove();
                worn.incrementAmount(selectedAmount);
            } else {
                Item inventoryStack = null;
                Map<String, String> attributes = worn.copyOfAttributes();
                if (worn.getDef().stackable)
                    inventoryStack = inventory.findItem(worn.getId());
                if (inventoryStack != null) {
                    selectedItem.remove();
                    inventoryStack.incrementAmount(worn.getAmount());
                } else {
                    selectedItem.setId(worn.getId());
                    selectedItem.setAmount(worn.getAmount());
                    worn.clearAttributes();
                    worn.putAttributes(selectedItem.copyOfAttributes());
                }
                worn.setId(selectedId);
                worn.setAmount(selectedAmount);
                worn.putAttributes(attributeCopy);
                selectedItem.clearAttributes();
                selectedItem.putAttributes(attributes);
            }
        }
        if(addLast != null)
            inventory.add(addLast);
        if(!player.recentlyEquipped.isDelayed() && equipSlot == Equipment.SLOT_WEAPON) {
            player.recentlyEquipped.delay(1);
          // player.resetAnimation();
        }
        player.closeDialogue();
        if(equipSound != -1)
            player.privateSound(equipSound, 1, 0);
    }

    public boolean unequip(Item equipped) {
        Inventory inventory = player.getInventory();
        Item inventoryStack = null;
        if(equipped.getDef().stackable)
            inventoryStack = inventory.findItem(equipped.getId());
        if(inventoryStack != null) {
            equipped.remove();
            inventoryStack.incrementAmount(equipped.getAmount());
        } else {
            int freeSlot = inventory.freeSlot();
            if(freeSlot == -1) {
                player.sendMessage("You don't have enough free space to do that.");
                return false;
            }
            equipped.remove();
            inventory.set(freeSlot, equipped);
        }
        return true;
    }
    @Override
    public boolean sendUpdates() {
        int updatedAppearanceSlots = updatedCount;
        if(updatedSlots[SLOT_RING])
            updatedAppearanceSlots--;
        if(updatedSlots[SLOT_AMMO])
            updatedAppearanceSlots--;
        if(updatedSlots[SLOT_WEAPON])
            player.getCombat().updateWeapon(false);
        if(updatedAppearanceSlots > 0)
            player.getAppearance().update();
        if(!super.sendUpdates())
            return false;
        /**
        * Reset bonuses/weight
        */
        for(int i = 0; i < bonuses.length; i++)
            bonuses[i] = 0;
        weight = 0.0;
        /**
        * Calculate bonuses/weight
        */
        boolean ignoreRangedAmmoStr = false;
        Item wep = get(SLOT_WEAPON);
        if(wep != null) {
            if(wep.getId() == 12926) { //blowpipe
                Blowpipe.Dart dart = Blowpipe.getDart(wep);
                if(dart != Blowpipe.Dart.NONE) //should always be true
                    bonuses[EquipmentStats.RANGED_STRENGTH] += ItemDef.get(dart.id).equipBonuses[EquipmentStats.RANGED_STRENGTH];
                ignoreRangedAmmoStr = true;
            } else {
                RangedWeapon rangedWep = wep.getDef().rangedWeapon;
                ignoreRangedAmmoStr = rangedWep != null && rangedWep.allowedAmmo == null;
            }
        }
        for(Item item : getItems()) {
            if(item != null) {
                ItemDef def = item.getDef();
                if(def.equipBonuses != null) {
                    boolean wilderness = def.wilderness; //If its pvp armor
                    boolean inWilderness = player.wildernessLevel > 0 || player.tournament != null;
                    for(int i = 0; i < def.equipBonuses.length; i++) {
                        int bonus = def.equipBonuses[i];
                        if (bonus == 0)
                            continue;
                        if(ignoreRangedAmmoStr && def.equipSlot == SLOT_AMMO && i == EquipmentStats.RANGED_STRENGTH)
                            continue;
                        if (wilderness && !inWilderness)
                            bonus *= .75;
                        bonuses[i] += bonus;
                    }
                }
                weight += def.weightEquipment;
            }
        }
        /**
        * Update equipment stats interface
        */
        if(player.isVisibleInterface(Interface.EQUIPMENT_STATS))
            EquipmentStats.update(player);
        return true;
    }

    @Override
    public boolean hasId(int id) {
        return getId(ItemDef.get(id).equipSlot) == id;
    }

}

---

---

I'm ashamed of you already because every time you help me. You always invest and help me wholeheartedly, thank you very much, Armo.

Quote:

---

Originally Posted by Ilgaz [Only registered and activated users can see links. Click Here To Register...]

I'm ashamed of you already because every time you help me. You always invest and help me wholeheartedly, thank you very much, Armo.

---

Posted a snippet for armor sounds:

[Only registered and activated users can see links. Click Here To Register...]