Clicking Buttons - Dialogue

This should be pretty simple.. How do the cases work inside of Clicking-Buttons using an IF statement inside of a case: do I need a break after every If statement like dialogues? Or a return? Because When I'm choosing an option and then I walk away from a dialogue in progress, then pull up a teleport and then go back talking to that NPC and choose an option it'll teleport me instead of finishing out the NPC chat. Hopefully this makes sense.

Code:

---

case 9180:
                        if (c.teleAction == 6) { // fishing tele
                                c.getPA().spellTeleport(2604, 3414, 0);
                        }
                        else if (c.dialogueAction == 9181) {
                                c.getDH().sendDialogues(9180, -1);
                        }
                        else if (c.teleAction == 241) {
                                c.getPA().spellTeleport(3096, 9868, 0);
                        }
                        /* ghouls */
                        else if (c.teleAction == 7) {
                                c.getPA().spellTeleport(3443, 3458, 0);
                               
                        }
break;

---

You'd probably want to reset teleaction or dialogue action if you click away
Although im not sure why its done this way to begin with

Quote:

---

Originally Posted by NeilG [Only registered and activated users can see links. Click Here To Register...]

You'd probably want to reset teleaction or dialogue action if you click away
Although im not sure why its done this way to begin with

---

Would teleaction and dialogueID/action be better if they were just in a switch statement under the ActionButton switch?

Quote:

---

Originally Posted by scoping king [Only registered and activated users can see links. Click Here To Register...]

Would teleaction and dialogueID/action be better if they were just in a switch statement under the ActionButton switch?

---

... it'll work but i'm not a fan of nested switchcases personally. I would go as far as to say it's bad practice but that might vary depending on who you ask.
I was mostly criticising the dialogueaction id /actionid etc because i find it confusing. Not that you asked, but it might be worth rewriting how dialogue is handled in future to avoid confusion and falling into bad habbits.

Quote:

---

Originally Posted by NeilG [Only registered and activated users can see links. Click Here To Register...]

... it'll work but i'm not a fan of nested switchcases personally. I would go as far as to say it's bad practice but that might vary depending on who you ask.
I was mostly criticising the dialogueaction id /actionid etc because i find it confusing. Not that you asked, but it might be worth rewriting how dialogue is handled in future to avoid confusion and falling into bad habbits.

---

Yeah, just having an issue with fall throughs. I don’t like nested switches either do to how bad it looks, what’s a good way to start rewriting this? I’m thinking change the dialogue-action variable to playerOption or something that makes a bit more sense.

Quote:

---

Originally Posted by scoping king [Only registered and activated users can see links. Click Here To Register...]

This should be pretty simple.. How do the cases work inside of Clicking-Buttons using an IF statement inside of a case: do I need a break after every If statement like dialogues? Or a return? Because When I'm choosing an option and then I walk away from a dialogue in progress, then pull up a teleport and then go back talking to that NPC and choose an option it'll teleport me instead of finishing out the NPC chat. Hopefully this makes sense.

Code:

---

case 9180:
                        if (c.teleAction == 6) { // fishing tele
                                c.getPA().spellTeleport(2604, 3414, 0);
                        }
                        else if (c.dialogueAction == 9181) {
                                c.getDH().sendDialogues(9180, -1);
                        }
                        else if (c.teleAction == 241) {
                                c.getPA().spellTeleport(3096, 9868, 0);
                        }
                        /* ghouls */
                        else if (c.teleAction == 7) {
                                c.getPA().spellTeleport(3443, 3458, 0);
                               
                        }
break;

---

---

No you don't need to break after every if statement that's what the else is for (although it does evaluate them so are you saying it executes both?), it isn't executed unless the first statement is incorrect. If I have understood your problem correctly the issue is probably that the teleAction or dialogueAction is not correctly reset or adjusted or whatnot so your problem is when it does the conditional logic again it does the wrong one. I don't really know how your teleAction etc work (presumably badly based on the above) but a simple reset at the end would suffice I would presume?

Code:

---


c.teleAction = 0;
c.dialogueAction = 0;

---

Quote:

---

Originally Posted by Fire Cape [Only registered and activated users can see links. Click Here To Register...]

No you don't need to break after every if statement that's what the else is for (although it does evaluate them so are you saying it executes both?), it isn't executed unless the first statement is incorrect. If I have understood your problem correctly the issue is probably that the teleAction or dialogueAction is not correctly reset or adjusted or whatnot so your problem is when it does the conditional logic again it does the wrong one. I don't really know how your teleAction etc work (presumably badly based on the above) but a simple reset at the end would suffice I would presume?

Code:

---


c.teleAction = 0;
c.dialogueAction = 0;

---

---

In a nutshell it does execute both, not at the same time of course but like if i opened a teleport for cities then opened up monster teleport instead, it would teleport me to the city area instead. Whats the difference between DialogueAction and DialogueId?