Getting player location in a loop

**toMeisteR** · 04-20-2020, 09:13 PM

I'm currently working on zalcano's falling rock attack, and I've got most of it working however. I need to define the coordinates of the players that are being hit:

Code:

CycleEvent event = new CycleEvent() {
				int rockTick = 0;
				@Override
				public void execute(CycleEventContainer container) {
					Misc.shuffle(targets)
					.stream()
					.limit(20)
					.forEach(plr -> {
						System.err.println(rockTick);
						
						final Location locs = plr.getLocation();
						
						if (rockTick == 1) {
							plr.asPlayer().getPA().createPlayersStillGfx(1727, plr.getX(), plr.getY(), 0, 0);
						}
						if (rockTick == 6) {
							if (plr.getLocation().equalsIgnoreHeight(locs)) {
								plr.appendDamage(Misc.random(1, 2), Hitmark.HIT);
							}
						}
					});
					if (rockTick >= 8) {
						container.stop();
					}
					//container.setTick(1);
					rockTick++;
				}
			};

What I colored out should take the players coordinate, however since we're looping their coordinates keep changing and thus players keep getting hit.
I've tried this:

Code:

CycleEvent event = new CycleEvent() {
				int rockTick = 0;
				@Override
				public void execute(CycleEventContainer container) {
					Misc.shuffle(targets)
					.stream()
					.limit(20)
					.forEach(plr -> {
						System.err.println(rockTick);
						
                                                if (rockTick == 1) {
						             final Location locs = plr.getLocation();
						}
						if (rockTick == 2) {
							plr.asPlayer().getPA().createPlayersStillGfx(1727, plr.getX(), plr.getY(), 0, 0);
						}
						if (rockTick == 6) {
							if (plr.getLocation().equalsIgnoreHeight(locs)) {
								plr.appendDamage(Misc.random(1, 2), Hitmark.HIT);
							}
						}
					});
					if (rockTick >= 8) {
						container.stop();
					}
					//container.setTick(1);
					rockTick++;
				}
			};

But I cannot open that final on tick 6 and it's now allowing me to make it public

I've been trial & erroring for over 4 hours now with no luck.

Also I can grab their location before the cycle event, however that will only grab the location of the NPC's target and not all the players that are gonna get hit resulting in everyone getting hit or no one getting hit (Depending if the actual targets stepping away or not)

**hc747** · 04-21-2020, 04:45 AM

Something along these lines; note that this is somewhat pseudo code. Don't store the players actual location, otherwise it'll point to their current location, as opposed to where they were standing.

Code:

CycleEvent event = new CycleEvent() {
 private int tick = 0;
 private List <Location> locations = null;


 @Override
 public void execute(CycleEventContainer container) {
  if (tick == 1) {
   locations = Misc.shuffle(targets).stream().limit(20).map(target -> target.getLocation().copy());
  } else if (tick == 2) {
   //create graphics for each location
  } else if (tick == 6) {
   //for each player, if they're standing in one of the locations, append damage
  } else if (tick >= 8) {
   container.stop(); //why not stop after tick 6???
  }
  tick++;
 }
};

**toMeisteR** · 04-21-2020, 07:12 AM

Originally Posted by hc747

Something along these lines; note that this is somewhat pseudo code. Don't store the players actual location, otherwise it'll point to their current location, as opposed to where they were standing.

Code:

CycleEvent event = new CycleEvent() {
 private int tick = 0;
 private List <Location> locations = null;


 @Override
 public void execute(CycleEventContainer container) {
  if (tick == 1) {
   locations = Misc.shuffle(targets).stream().limit(20).map(target -> target.getLocation().copy());
  } else if (tick == 2) {
   //create graphics for each location
  } else if (tick == 6) {
   //for each player, if they're standing in one of the locations, append damage
  } else if (tick >= 8) {
   container.stop(); //why not stop after tick 6???
  }
  tick++;
 }
};

First of all thanks for the reply.

I'm getting a bit confused on the part where you say don't store players locations as they will change. On the first cycle your returning the targets locations. I'm unsure where it stores this and how I would check the players location individually and the players location at cycle 6 to check wether or not to apply damage.

Sorry for the nooby questions.

**hc747** · 04-21-2020, 07:19 AM

Originally Posted by toMeisteR

First of all thanks for the reply.

I'm getting a bit confused on the part where you say don't store players locations as they will change. On the first cycle your returning the targets locations. I'm unsure where it stores this and how I would check the players location individually and the players location at cycle 6 to check wether or not to apply damage.

Sorry for the nooby questions.

If the locations are mutable (I assume they are), you're only storing a reference to the players location, which in 6 ticks might change, so instead of targeting their original location, it'll target their current location - hence why you need to copy (and not modify) the original locations. They're being stored in the List of locations declared below the ticks variable, and being populated in tick 1 as opposed to during initialisation (for whatever reason). Iterate over all of the players within the area and see if any of them are at the same location as any of the locations within the list. GL.

Thread: Getting player location in a loop

Thread Tools

Thankful users:

Thankful user:

Users Browsing this Thread

User Tag List

Similar Threads

Get player amount in certain Areas?

How do i make it so that players get what the other player loses in pvp? rs2hd 562.

Getting player count in a certain area?

I get this weird error everytime a player logs in

Need help getting player's heads to move in chat boxes.