Some errors with Elvarg [3.2]

So i've recently got back into the RSPS scene and I've picked up Elvarg 3.2 because it seems stable and leaves space for new content for my new project. However i've noticed some issues and would appreciate if anyone could provide some help as I think others have experienced the same issues as me. These don't happen in the 3.1 or OSRS Pk so it's got to be something with updating the packets, I went about to try changing it in packet constants etc. but it's been a while and I couldn't manage to do it. I would appreciate all the help I can get, cheers!.

Client [PacketConstants]
[Only registered and activated users can see links. Click Here To Register...]

Server [PacketDecoder]
[Only registered and activated users can see links. Click Here To Register...]

1. Dropping items kicks you out constantly, even after login in packet.

Code:

---

Client error
T1 - 162,0 - 85,219
T1 - 204,0 - 85,178
T1 - 237,0 - 85,178
T1 - 216,0 - 85,178

Server error
{PacketEncoder} Opcode 44 has defined size 5 but is actually 7.

---

2. Duel Arena dc when clicking accept in the duel interface.

Code:

---

{PacketEncoder} Opcode 54 has defined size 0 but is actually 4.
{PacketEncoder} Opcode 54 has defined size 0 but is actually 4.
{PacketEncoder} Opcode 184 has defined size 0 but is actually 1.
{PacketEncoder} Opcode 54 has defined size 0 but is actually 4.
{PacketEncoder} Opcode 54 has defined size 0 but is actually 4.
{PacketEncoder} Opcode 184 has defined size 0 but is actually 1.

---

3.The presets DC as well.

Code:

---

{PacketEncoder} Opcode 54 has defined size 0 but is actually 4.
{PacketEncoder} Opcode 54 has defined size 0 but is actually 4.
{PacketEncoder} Opcode 54 has defined size 0 but is actually 4.
{PacketEncoder} Opcode 54 has defined size 0 but is actually 4.
{PacketEncoder} Opcode 184 has defined size 0 but is actually 1.
T1 - 170,0 - 110,134
T1 - 197,0 - 110,134

---

4.In the dialogue player heads are invisible.

[Only registered and activated users can see links. Click Here To Register...]

Just to add to the list you might want to go check out poisoning each other in combat.

bumppp :-)

Quote:

---

Originally Posted by Brett the Don [Only registered and activated users can see links. Click Here To Register...]

Just to add to the list you might want to go check out poisoning each other in combat.

---

It is just the hitmarker being reset. If you debug it correctly; removing one line of code fixes that. And venom hitmarker is not added server and client sided.

Quote:

---

Originally Posted by rensmanders [Only registered and activated users can see links. Click Here To Register...]

bumppp :-)

---

The sizes of the packets are incorrect. Some other packets have issues not related to their size. It is like the message says. Your encoder, and the client receiving or writing them s not the correct size. So you have to the change the size in the client and server.
Elvarg 3.2 was ment to be an improved networking system, which it is. Changing sizes is not to only thing to do, some parts need a rewrite. It is great as a reference, using it needs some work.

Understanding the errors you're getting: [Only registered and activated users can see links. Click Here To Register...]
Understanding the 317 protocol: [Only registered and activated users can see links. Click Here To Register...]

I would suggest using 3.1 if you can't fix this. Or ask any other questions if this information is not sufficient :)

Someone who want a fast fix:

I've fixed it on my own.

Server encode packets:

Quote:

---

public static final int[] CLIENT_PACKET_SIZES = {
0, 0, 0, 1, 6, 0, 0, 0, 4, 4, //0
6, 2, -1, 1, 1, -1, 1, 0, 0, 0, // 10
0, 0, 0, 0, 1, 0, 0, -1, 1, 1, //20
0, 0, 0, 0, -2, 4, 3, 0, 2, 0, //30
0, 0, 0, 0, 7, 8, 0, 6, 0, 0, //40
9, 8, 0, -2, 4, 1, 0, 0, 0, 0, //50
-2, 1, 0, 0, 2, -2, 0, 0, 0, 0, //60
6, 3, 2, 4, 2, 4, 0, 0, 0, 4, //70
0, -2, 0, 0, 7, 2, 1, 6, 6, 0, //80
0, 0, 0, 0, 0, 0, 0, 2, 0, 1, //90
2, 2, 0, 1, -1, 8, 1, 0, 8, 0, //100
1, 1, 1, 1, 2, 1, 5, 15, 0, 0, //110
0, 4, 4, -1, 9, -1, -2, 2, 0, 0, //120 // 9
-1, 0, 0, 0, 13, 0, 0, 1, 0, 0, // 130
3, 10, 2, 0, 0, 0, 0, 14, 0, 0, //140
0, 4, 5, 3, 0, 0, 3, 0, 0, 0, //150
4, 5, 0, 0, 2, 0, 6, 0, 0, 0, //160
0, 5, -2, -2, 5, 5, 10, 6, 0, -2, // 170
0, 0, 0, 1, 1, 2, 1, -1, 0, 0, //180
0, 0, 0, 0, 0, 2, -1, 0, -1, 0, //190
4, 0, 0, 0, 0, 0, 3, 0, 4, 0, //200
0, 0, 0, 0, 8, 7, 0, -2, 2, 0, //210
0, 1, -2, -2, 0, 0, 0, 0, 0, 0, // 220
8, 0, 0, 0, 0, 0, 0, 0, 0, 0,//230
2, -2, 0, 0, -1, 0, 6, 0, 4, 3,//240
-1, 0, 0, -1, 6, 0, 0//250
};

---

Server decode packets:

Quote:

---

private final static int[] PACKET_SIZES = {
0, 0, 6, 1, -1, -1, 2, 4, 4, 4, // 0
4, -1, -1, -1, 8, 0, 6, 2, 2, 0, // 10
0, 2, 0, 6, 0, 12, 0, 0, 0, 0, // 20
9, 0, 0, 0, 0, 8, 4, 0, 0, 2, // 30
2, 6, 0, 8, 0, -1, 0, 0, 0, 1, // 40
0, 0, 0, 12, 0, 0, 0, 8, 8, 0, // 50
-1, 8, 0, 0, 0, 0, 0, 0, 0, 0, // 60
6, 0, 2, 2, 8, 6, 0, -1, 0, 6, // 70
-1, 0, 0, 0, 0, 1, 4, 6, 0, 0, // 80
0, 0, 0, 0, 0, 3, 0, 0, -1, 0, // 90
0, 13, 0, -1, -1, 0, 0, 0, 0, 0, // 100
0, 0, 0, 0, 0, 0, 0, 8, 0, 0, // 110
1, 0, 6, 0, 0, 0, -1, 0, 2, 8, // 120
0, 4, 6, 8, 0, 8, 0, 0, 6, 2, // 130
0, 0, 0, 0, 0, 8, 0, 0, 0, 0, // 140
0, 0, 1, 2, 0, 2, 6, 0, 0, 0, // 150
0, 0, 0, 0, -1, -1, 0, 0, 0, 0, // 160
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, // 170
0, 8, 0, 2, 4, 4, 5, 6, 8, 1, // 180
0, 0, 12, 0, 0, 0, 0, 0, 0, 0, // 190
2, 0, 0, 0, 2, 0, 0, 0, 4, 0, // 200
4, 0, 0, 0, 7, 8, 8, 0, 10, 0, // 210
0, 0, 3, 2, 0, 0, -1, 0, 6, 1, // 220
1, 0, 0, 0, 6, 0, 6, 8, 1, 0, // 230
0, 4, 0, 0, 0, 0, -1, 0, -1, 4, // 240
0, 0, 6, 6, 0, 0 // 250
};

---