Thread: (ELVARG) NPC Shops

Results 1 to 4 of 4
  1. #1 (ELVARG) NPC Shops 
    hash1mate
    hash1mate is offline
    Registered Member
    Join Date
    May 2018
    Posts
    3
    Thanks given
    0
    Thanks received
    0
    Rep Power
    0
    Default 06-10-2018, 01:31 AM
    Hi, I'm currently struggling to implement shops into my elvarg based server. I've tried by myself but had no luck so I used a similar post where a guy used "BOB", however I'm still having no luck
    These are my current lines of code;
    in NPCOPTIONPACKETLISTENER.JAVA -
    switch(npc.getId()) {
    case BOB:
    Shop.open(player, Shop.PK_GEAR);
    break;
    further down -
    private static final int BOB = 505;

    in Shop.java - public static final int PK_GEAR = 3;

    in shops.json - {
    "id":3,
    "buys-items":true,
    "name":"Pk Gear",
    "items":[
    {
    "id":299,
    "amount":2000000000
    }
    ],
    "currency":13307
    }

    I've def'd and spawned the npc. He's loaded onto my server permanently, the shop just doesn't open with any interaction.
    Would appreciate any guidance,
    Thanks.
     
  2. #2  
    Hitten
    Hitten is offline
    ¯\_(ツ)_/¯

    Join Date
    Jul 2014
    Posts
    1,810
    Thanks given
    927
    Thanks received
    546
    Rep Power
    299
    06-10-2018, 02:00 AM
    post your NPCOPTIONPACKETLISTENER.java so i can see where you're adding the code.
     
  3. #3  
    hash1mate
    hash1mate is offline
    Registered Member
    Join Date
    May 2018
    Posts
    3
    Thanks given
    0
    Thanks received
    0
    Rep Power
    0
    06-10-2018, 02:12 AM
    Here:
    Code:
    package com.elvarg.net.packet.impl;

import com.elvarg.engine.task.impl.WalkToTask;
import com.elvarg.engine.task.impl.WalkToTask.FinalizedMovementTask;
import com.elvarg.net.packet.Packet;
import com.elvarg.net.packet.PacketConstants;
import com.elvarg.net.packet.PacketListener;
import com.elvarg.world.World;
import com.elvarg.world.content.BossPets;
import com.elvarg.world.entity.combat.CombatFactory;
import com.elvarg.world.entity.combat.bountyhunter.BountyHunter;
import com.elvarg.world.entity.combat.magic.CombatSpell;
import com.elvarg.world.entity.combat.magic.CombatSpells;
import com.elvarg.world.entity.impl.npc.NPC;
import com.elvarg.world.entity.impl.player.Player;
import com.elvarg.world.model.BrokenItem;
import com.elvarg.world.model.PlayerRights;
import com.elvarg.world.model.SkullType;
import com.elvarg.world.model.container.impl.Shop;
import com.elvarg.world.model.dialogue.DialogueManager;
import com.elvarg.world.model.dialogue.DialogueOptions;

public class NPCOptionPacketListener implements PacketListener {


	private static void firstClick(Player player, Packet packet) {
		int index = packet.readLEShort();
		if(index < 0 || index > World.getNpcs().capacity())
			return;
		final NPC npc = World.getNpcs().get(index);
		if (npc == null)
			return;
		player.setEntityInteraction(npc);
		if(player.getRights() == PlayerRights.ADMINISTRATOR)
			player.getPacketSender().sendMessage("First click npc id: "+npc.getId());
		player.setWalkToTask(new WalkToTask(player, npc.getPosition(), npc.getSize(), new FinalizedMovementTask() {
			@Override
			public void execute() {
				if(BossPets.pickup(player, npc)) {
					return;
				}
				switch(npc.getId()) {
				case BOB:
					Shop.open(player, Shop.PK_GEAR);
					break;
				case SHOP_KEEPER:
					Shop.open(player, Shop.GENERAL_SHOP);
					break;

				case PARTY_PETE:
					Shop.open(player, Shop.GAMBLING_SHOP);
					break;
					
				case MAKE_OVER_MAGE:
					player.getPacketSender().sendInterfaceRemoval().sendInterface(3559);
					player.getAppearance().setCanChangeAppearance(true);
					break;

				case EMBLEM_TRADER:
					//And then start dialogue
					DialogueManager.start(player, 0);
					//Set dialogue options
					player.setDialogueOptions(new DialogueOptions() {
						@Override
						public void handleOption(Player player, int option) {
							switch(option) {
							case 1:
								//Open pvp shop
								Shop.open(player, Shop.PVP_SHOP);
								break;
							case 2:
								//Sell emblems option
								player.setDialogueOptions(new DialogueOptions() {
									@Override
									public void handleOption(Player player, int option) {
										if(option == 1) {
											int cost = BountyHunter.getValueForEmblems(player, true);
											player.getPacketSender().sendMessage("@[email protected] have received "+cost+" blood money for your emblem(s).");
											DialogueManager.start(player, 4);
										} else {
											player.getPacketSender().sendInterfaceRemoval();
										}
									}
								});
								int value = BountyHunter.getValueForEmblems(player, false);
								if(value > 0) {
									player.setDialogue(DialogueManager.getDialogues().get(10)); //Yes / no option
									DialogueManager.sendStatement(player, "I will give you "+value+" blood money for those emblems. Agree?");
								} else {
									DialogueManager.start(player, 5);
								}
								break;
							case 3:
								//Skull me option
								if(player.isSkulled()) {
									DialogueManager.start(player, 3);
								} else {
									DialogueManager.start(player, 22);
									player.setDialogueOptions(new DialogueOptions() {
										@Override
										public void handleOption(Player player, int option) {
											if(option == 1) {
												CombatFactory.skull(player, SkullType.WHITE_SKULL, 300);
											} else if(option == 2) {
												CombatFactory.skull(player, SkullType.RED_SKULL, 300);
											}
											player.getPacketSender().sendInterfaceRemoval();
										}
									});
								}
								break;
							case 4:
								//Cancel option
								player.getPacketSender().sendInterfaceRemoval();
								break;
							}
						}
					});
					break;
					
				case PERDU:
					//Set dialogue options
					player.setDialogueOptions(new DialogueOptions() {
						@Override
						public void handleOption(Player player, int option) {
							if(option == 1) {
								
								int cost = BrokenItem.getRepairCost(player);
								
								player.setDialogueOptions(new DialogueOptions() {
									@Override
									public void handleOption(Player player, int option) {
										if(option == 1) {
											BrokenItem.repair(player);
										} else {
											player.getPacketSender().sendInterfaceRemoval();
										}
									}
								});								
								
								if(cost > 0) {
									player.setDialogue(DialogueManager.getDialogues().get(10)); //Yes / no option
									DialogueManager.sendStatement(player, "It will cost you "+cost+" blood money to fix your broken items. Agree?");
								} else {
									DialogueManager.start(player, 20);
								}
								
							} else {
								player.getPacketSender().sendInterfaceRemoval();
							}
						}
					});
					
					//Start main dialogue
					DialogueManager.start(player, 19);
					break;


				case FINANCIAL_ADVISOR:
					DialogueManager.start(player, 15);
					//Removed
					break;


				}
				npc.setPositionToFace(player.getPosition());
				player.setPositionToFace(npc.getPosition());
			}
		}));
	}

	public void handleSecondClick(Player player, Packet packet) {
		int index = packet.readLEShortA();
		if(index < 0 || index > World.getNpcs().capacity())
			return;
		final NPC npc = World.getNpcs().get(index);
		if(npc == null)
			return;
		player.setEntityInteraction(npc);
		final int npcId = npc.getId();
		if(player.getRights() == PlayerRights.DEVELOPER)
			player.getPacketSender().sendMessage("Second click npc id: "+npcId);
		player.setWalkToTask(new WalkToTask(player, npc.getPosition(), npc.getSize(), new FinalizedMovementTask() {
			@Override
			public void execute() {
				switch(npc.getId()) {

				case EMBLEM_TRADER:
					Shop.open(player, Shop.PVP_SHOP);
					break;

				}
				npc.setPositionToFace(player.getPosition());
				player.setPositionToFace(npc.getPosition());
			}
		}));
	}

	public void handleThirdClick(Player player, Packet packet) {
		int index = packet.readShort();
		if(index < 0 || index > World.getNpcs().capacity())
			return;
		final NPC npc = World.getNpcs().get(index);
		if (npc == null)
			return;
		player.setEntityInteraction(npc).setPositionToFace(npc.getPosition().copy());
		npc.setPositionToFace(player.getPosition());
		if(player.getRights() == PlayerRights.DEVELOPER)
			player.getPacketSender().sendMessage("Third click npc id: "+npc.getId());
		player.setWalkToTask(new WalkToTask(player, npc.getPosition(), npc.getSize(), new FinalizedMovementTask() {
			@Override
			public void execute() {
				switch(npc.getId()) {

				case EMBLEM_TRADER:
					//Sell emblems option
					player.setDialogueOptions(new DialogueOptions() {
						@Override
						public void handleOption(Player player, int option) {
							if(option == 1) {
								int cost = BountyHunter.getValueForEmblems(player, true);
								player.getPacketSender().sendMessage("@[email protected] have received "+cost+" blood money for your emblem(s).");
								DialogueManager.start(player, 4);
							} else {
								player.getPacketSender().sendInterfaceRemoval();
							}
						}
					});
					int value = BountyHunter.getValueForEmblems(player, false);
					if(value > 0) {
						player.setDialogue(DialogueManager.getDialogues().get(10)); //Yes / no option
						DialogueManager.sendStatement(player, "I will give you "+value+" blood money for those emblems. Agree?");
					} else {
						DialogueManager.start(player, 5);
					}
					break;
				}

				npc.setPositionToFace(player.getPosition());
				player.setPositionToFace(npc.getPosition());
			}
		}));
	}

	public void handleFourthClick(Player player, Packet packet) {
		int index = packet.readLEShort();
		if(index < 0 || index > World.getNpcs().capacity())
			return;
		final NPC npc = World.getNpcs().get(index);
		if (npc == null)
			return;
		player.setEntityInteraction(npc);
		if(player.getRights() == PlayerRights.DEVELOPER)
			player.getPacketSender().sendMessage("Fourth click npc id: "+npc.getId());
		player.setWalkToTask(new WalkToTask(player, npc.getPosition(), npc.getSize(), new FinalizedMovementTask() {
			@Override
			public void execute() {
				switch(npc.getId()) {
				case EMBLEM_TRADER:
					if(player.isSkulled()) {
						DialogueManager.start(player, 3);
					} else {
						DialogueManager.start(player, 22);
						player.setDialogueOptions(new DialogueOptions() {
							@Override
							public void handleOption(Player player, int option) {
								if(option == 1) {
									CombatFactory.skull(player, SkullType.WHITE_SKULL, 300);
								} else if(option == 2) {
									CombatFactory.skull(player, SkullType.RED_SKULL, 300);
								}
								player.getPacketSender().sendInterfaceRemoval();
							}
						});
					}
					break;
				}
				npc.setPositionToFace(player.getPosition());
				player.setPositionToFace(npc.getPosition());
			}
		}));
	}

	private static void attackNPC(Player player, Packet packet) {
		int index = packet.readShortA();
		if(index < 0 || index > World.getNpcs().capacity())
			return;
		final NPC interact = World.getNpcs().get(index);

		if (interact == null || interact.getDefinition() == null) {
			return;
		}

		if (!interact.getDefinition().isAttackable()) {
			return;
		}

		if(interact == null || interact.getHitpoints() <= 0) {
			player.getMovementQueue().reset();
			return;
		}

		player.getCombat().attack(interact);
	}

	private static void mageNpc(Player player, Packet packet) {
		int npcIndex = packet.readLEShortA();
		int spellId = packet.readShortA();

		if (npcIndex < 0 || spellId < 0 || npcIndex > World.getNpcs().capacity()) {
			return;
		}

		final NPC interact = World.getNpcs().get(npcIndex);

		if (interact == null || interact.getDefinition() == null) {
			return;
		}

		if (!interact.getDefinition().isAttackable()) {
			return;
		}

		if(interact == null || interact.getHitpoints() <= 0) {
			player.getMovementQueue().reset();
			return;
		}

		CombatSpell spell = CombatSpells.getCombatSpell(spellId);

		if(spell == null) {
			player.getMovementQueue().reset();
			return;
		}

		player.setPositionToFace(interact.getPosition());
		player.getCombat().setCastSpell(spell);

		player.getCombat().attack(interact);
	}

	@Override
	public void handleMessage(Player player, Packet packet) {

		if(player == null || player.getHitpoints() <= 0) {
			return;
		}

		if(player.busy()) {
			return;
		}
		switch (packet.getOpcode()) {
		case PacketConstants.ATTACK_NPC_OPCODE:
			attackNPC(player, packet);
			break;
		case PacketConstants.FIRST_CLICK_OPCODE:
			firstClick(player, packet);
			break;
		case PacketConstants.SECOND_CLICK_OPCODE:
			handleSecondClick(player, packet);
			break;
		case PacketConstants.THIRD_CLICK_OPCODE:
			handleThirdClick(player, packet);
			break;
		case PacketConstants.FOURTH_CLICK_OPCODE:
			handleFourthClick(player, packet);
			break;
		case PacketConstants.MAGE_NPC_OPCODE:
			mageNpc(player, packet);
			break;
		}
	}

	/** NPCS **/
	private static final int EMBLEM_TRADER = 315;
	private static final int MAKE_OVER_MAGE = 1306;
	private static final int FINANCIAL_ADVISOR = 3310;
	private static final int PERDU = 7456;
	private static final int PARTY_PETE = 5792;
	private static final int SHOP_KEEPER = 506;
	private static final int BOB = 505;
}
     
  4. #4  
    Hitten
    Hitten is offline
    ¯\_(ツ)_/¯

    Join Date
    Jul 2014
    Posts
    1,810
    Thanks given
    927
    Thanks received
    546
    Rep Power
    299
    06-10-2018, 02:20 AM
    Looks like it should work if you click 'Talk to' on bob.
     

« Mac ban +UID and virtual machine bypass help | osrs pk disconnections »
Thread Information
Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

User Tag List

Similar Threads

  1. elvarg npc shop option
    By nochance in forum Help
    Replies: 2
    Last Post: 05-08-2017, 05:36 AM
  2. magic on npc shops attacks them?
    By Kduffy45 in forum Help
    Replies: 1
    Last Post: 09-26-2009, 01:34 AM
  3. [508] NPC Shops
    By ganja zombie in forum Help
    Replies: 6
    Last Post: 05-14-2009, 06:46 PM
  4. [508] NPC Shop help
    By White. in forum Help
    Replies: 3
    Last Post: 03-16-2009, 06:29 PM
  5. Dodian duel dupe (npcs shops and bankers)
    By Knova in forum Tutorials
    Replies: 3
    Last Post: 11-23-2007, 02:39 PM
Posting Permissions
  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  

Forum Rules