[Ruse] Help please!

Okay, so I'm trying to make a boss that you can only do every 30 minutes...

Code:

---

if (command[0].equals("servant")) {
                                        if (player.getLastServant().elapsed(1800000)) {
                                        GodServant.spawn(player, 1, 5000);
                                        player.moveTo(new Position(2897, 2787, player.getIndex() * 4));
                                        player.getLastServant().reset();
                                } else {
                                        player.getPacketSender().sendMessage("You can only teleport here every 30 minutes!");
                                }
                                        if (player.getLastServant().elapsed(1200000)) {
                                                player.getPacketSender().sendMessage("You have 20 minutes left to wait.");
                                        }
                                        if (player.getLastServant().elapsed(600000)) {
                                                player.getPacketSender().sendMessage("You have 10 minutes left to wait.");
                                        }
                                }

---

[Only registered and activated users can see links. Click Here To Register...]
It just completely skips the 20 minutes left to wait text...

How can I improve this?
Thanks in advance :)

I would look into your "player.getLastServant().elapsed(1800000)" and see what it sets it to true.
Also your if checks at the bottom is seperate from your elapsed time above:

Code:

---

If(x) { //x == true send below
sends();
} else { //If x != true send this below!
sends();
}

if(y) { //If y == true send below
sends();
}
if(z) { //if z == true send below
sends();
}

---

I also advice to remove the two bottom if statement and just have the send message below } else { to send out minutes left by grabbing your timer and do correct math to it:

Code:

---

int minutes = formula;
player.getPacketSender().sendMessage("You can only teleport here every " + minutes + " minute" + (minutes == 1 ? "" : "s") + "!");

---

Quote:

---

Originally Posted by arch337 [Only registered and activated users can see links. Click Here To Register...]

I would look into your "player.getLastServant().elapsed(1800000)" and see what it sets it to true.
Also your if checks at the bottom is seperate from your elapsed time above:

Code:

---

If(x) { //x == true send below
sends();
} else { //If x != true send this below!
sends();
}

if(y) { //If y == true send below
sends();
}
if(z) { //if z == true send below
sends();
}

---

I also advice to remove the two bottom if statement and just have the send message below } else { to send out minutes left by grabbing your timer and do correct math to it:

Code:

---

int minutes = formula;
player.getPacketSender().sendMessage("You can only teleport here every " + minutes + " minute" + (minutes == 1 ? "" : "s") + "!");

---

---

See that's what I want, I want it to do that when I do it so it says the exact time left, but no idea how to go about doing it... LOL
Still learning, sorry

Quote:

---

Originally Posted by OmegaX [Only registered and activated users can see links. Click Here To Register...]

See that's what I want, I want it to do that when I do it so it says the exact time left, but no idea how to go about doing it... LOL
Still learning, sorry

---

Are you new to math? If so I suggest go back to it as coding sure will test your math skills.
formula is (1800000 - timeElapsed) / 60000 + 1
timeElapsed is your code for the elapsed time within player.getLastServant()
If it do not have one, just code it.

Quote:

---

Originally Posted by OmegaX [Only registered and activated users can see links. Click Here To Register...]

Okay, so I'm trying to make a boss that you can only do every 30 minutes...

Code:

---

if (command[0].equals("servant")) {
                                        if (player.getLastServant().elapsed(1800000)) {
                                        GodServant.spawn(player, 1, 5000);
                                        player.moveTo(new Position(2897, 2787, player.getIndex() * 4));
                                        player.getLastServant().reset();
                                } else {
                                        player.getPacketSender().sendMessage("You can only teleport here every 30 minutes!");
                                }
                                        if (player.getLastServant().elapsed(1200000)) {
                                                player.getPacketSender().sendMessage("You have 20 minutes left to wait.");
                                        }
                                        if (player.getLastServant().elapsed(600000)) {
                                                player.getPacketSender().sendMessage("You have 10 minutes left to wait.");
                                        }
                                }

---

[Only registered and activated users can see links. Click Here To Register...]
It just completely skips the 20 minutes left to wait text...

How can I improve this?
Thanks in advance :)

---

I translated your code into English sentences so you can figure out what's wrong with it yourself:

Code:

---

if you enter the ::servant command {

    if you haven't killed the servant for over 30 minutes, you {
        spawn the servant
        teleport the player to the servant
        reset the servant-wait-timer back to 0
    } else {
        tell the player you can only teleport here every 30 minutes
    }

    if you haven't killed the servant for over 20 minutes {
        tell the player he has to wait another 20 minutes
    }

    if you haven't killed the servant for over 10 minutes {
        tell the player he has to wait another 10 minutes
    }
   
}

---

To get what you want, you could do something along the lines of:

Code:

---

if (command[0].equals("servant")) {

    final int TELEPORT_INTERVAL = 30 * 60 * 1000;

    if (player.getLastServant().elapsed(TELEPORT_INTERVAL)) {
        GodServant.spawn(player, 1, 5000);
        player.moveTo(new Position(2897, 2787, player.getIndex() * 4));
        player.getLastServant().reset();
    } else {
        player.getPacketSender().sendMessage("You can only teleport here every 30 minutes!");
        int minutesLeftToWait = (TELEPORT_INTERVAL - player.getLastServant().elapsed()) / 1000 / 60;
        player.getPacketSender().sendMessage(String.format("You have %d minutes left to wait", minutesLeftToWait));
    }

}

---