Thread: [Elvarg] Shop

Results 1 to 9 of 9
  1. #1 [Elvarg] Shop 
    Registered Member
    Join Date
    Jan 2016
    Posts
    106
    Thanks given
    16
    Thanks received
    14
    Rep Power
    69
    tried implementing shops back into the most recent release from Professor Oak... when ever i try to open the shop this is the error i get...

    Code:
    java.lang.NullPointerException
    	at com.elvarg.game.model.container.impl.Shop.open(Shop.java:62)
    	at com.elvarg.game.model.container.impl.Shop.open(Shop.java:81)
    	at com.elvarg.net.packet.impl.NPCOptionPacketListener$2.execute(NPCOptionPacketListener.java:204)
    	at com.elvarg.game.model.movement.WalkToAction.sequence(WalkToAction.java:60)
    	at com.elvarg.game.entity.impl.player.Player.sequence(Player.java:219)
    	at com.elvarg.game.World$1.execute(World.java:134)
    	at com.elvarg.game.entity.updating.sync.GameSyncExecutor.sync(GameSyncExecutor.java:55)
    	at com.elvarg.game.World.sequence(World.java:129)
    	at com.elvarg.game.GameEngine.run(GameEngine.java:35)
    	at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
    	at java.util.concurrent.FutureTask.runAndReset(Unknown Source)
    	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(Unknown Source)
    	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source)
    	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
    	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
    	at java.lang.Thread.run(Unknown Source)
    Reply With Quote  
     

  2. #2  
    Registered Member Emre's Avatar
    Join Date
    Jan 2014
    Posts
    596
    Thanks given
    91
    Thanks received
    61
    Rep Power
    7
    Show the code
    Reply With Quote  
     

  3. #3  
    Registered Member
    Join Date
    Jan 2016
    Posts
    106
    Thanks given
    16
    Thanks received
    14
    Rep Power
    69
    Code:
    				public static void open(Player player, Shop shop) {
    			player.getPacketSender().sendInterfaceRemoval();
    
    			//Update player's shop and player status
    			player.setShop(ShopDefinition.getShops().get(shop.getDefinition().getId())).setInterfaceId(INTERFACE_ID)
    			.setStatus(PlayerStatus.NPC_OWNED_SHOPPING);
    		
    			//Refresh items
    		shop.refreshItems();
    
    		//Set up the scroll bar
    		player.getPacketSender().sendInterfaceScrollReset(SCROLL_BAR_INTERFACE_ID);
    		if(shop.getDefinition().getOriginalStock().length < 37) {
    			player.getPacketSender().sendScrollbarHeight(SCROLL_BAR_INTERFACE_ID, 0);
    		} else {
    			int rows = (shop.getDefinition().getOriginalStock().length % 9 == 0 ? (shop.getDefinition().getOriginalStock().length / 9) : ((shop.getDefinition().getOriginalStock().length / 9) + 1));
    			player.getPacketSender().sendScrollbarHeight(SCROLL_BAR_INTERFACE_ID, rows * 56);
    		}
    		
    		player.getPacketSender().sendMessage("").sendMessage("Warning! When selling an item to the shop, it loses 20% of its original value.");
    	}
    
    	public static void open(Player player, int shop) {
    		open(player, ShopDefinition.getShops().get(shop));
    	}
    Reply With Quote  
     

  4. #4  
    Registered Member Emre's Avatar
    Join Date
    Jan 2014
    Posts
    596
    Thanks given
    91
    Thanks received
    61
    Rep Power
    7
    Quote Originally Posted by Too Moist View Post
    Code:
    				public static void open(Player player, Shop shop) {
    			player.getPacketSender().sendInterfaceRemoval();
    
    			//Update player's shop and player status
    			player.setShop(ShopDefinition.getShops().get(shop.getDefinition().getId())).setInterfaceId(INTERFACE_ID)
    			.setStatus(PlayerStatus.NPC_OWNED_SHOPPING);
    		
    			//Refresh items
    		shop.refreshItems();
    
    		//Set up the scroll bar
    		player.getPacketSender().sendInterfaceScrollReset(SCROLL_BAR_INTERFACE_ID);
    		if(shop.getDefinition().getOriginalStock().length < 37) {
    			player.getPacketSender().sendScrollbarHeight(SCROLL_BAR_INTERFACE_ID, 0);
    		} else {
    			int rows = (shop.getDefinition().getOriginalStock().length % 9 == 0 ? (shop.getDefinition().getOriginalStock().length / 9) : ((shop.getDefinition().getOriginalStock().length / 9) + 1));
    			player.getPacketSender().sendScrollbarHeight(SCROLL_BAR_INTERFACE_ID, rows * 56);
    		}
    		
    		player.getPacketSender().sendMessage("").sendMessage("Warning! When selling an item to the shop, it loses 20% of its original value.");
    	}
    
    	public static void open(Player player, int shop) {
    		open(player, ShopDefinition.getShops().get(shop));
    	}
    ShopDefinition.getShops().get(shop)

    this returns null
    Reply With Quote  
     

  5. #5  
    Registered Member
    Join Date
    Jan 2016
    Posts
    106
    Thanks given
    16
    Thanks received
    14
    Rep Power
    69
    So how'd i go about that? literally i just ripped it all back from the previous release from Oak which it works on?
    Reply With Quote  
     

  6. #6  
    Registered Member Emre's Avatar
    Join Date
    Jan 2014
    Posts
    596
    Thanks given
    91
    Thanks received
    61
    Rep Power
    7
    Quote Originally Posted by Too Moist View Post
    So how'd i go about that? literally i just ripped it all back from the previous release from Oak which it works on?
    Fix up the loading of the shops or write your own shop system
    Reply With Quote  
     

  7. #7  
    Registered Member
    Join Date
    Jan 2016
    Posts
    106
    Thanks given
    16
    Thanks received
    14
    Rep Power
    69
    Nice one cheers bud.
    Reply With Quote  
     

  8. #8  
    Registered Member
    Join Date
    Dec 2016
    Posts
    87
    Thanks given
    1
    Thanks received
    4
    Rep Power
    59
    Check that the shop actually exists that you're trying to retrieve.
    Reply With Quote  
     

  9. #9  
    Registered Member Farage's Avatar
    Join Date
    Jan 2017
    Posts
    252
    Thanks given
    24
    Thanks received
    22
    Rep Power
    0
    Its trying to retrive a null shop. Shop system is broke to my knowledge. Rewrite or fix it. Or rip the shop system from a time the shops worked.
    Have a nice day!
    Иди в пизду!
    Bonne journée!
    Einen schönen Tag noch!
    Hezký den!
    祝你今天愉快!
    Reply With Quote  
     


Thread Information
Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)


User Tag List

Similar Threads

  1. Replies: 0
    Last Post: 07-09-2017, 02:59 PM
  2. [Elvarg/OSRSPK] Adding open shops
    By nochance in forum Help
    Replies: 4
    Last Post: 05-07-2017, 03:47 PM
  3. Elvarg Base using diffrent NPC for shops
    By D E T H in forum Help
    Replies: 10
    Last Post: 04-18-2017, 10:35 PM
  4. Elvarg Base Shop Issue
    By D E T H in forum Help
    Replies: 3
    Last Post: 04-12-2017, 02:16 AM
  5. Elvarg | shops help
    By josharmarksman in forum Help
    Replies: 6
    Last Post: 03-18-2017, 01:18 AM
Posting Permissions
  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •