[667] NPC Examining Null Pointer

I am using Pox 667 base and loaded it with 667 v3 Cache to fix mapping issues and just cause I wanted a cleaner cache with old models. I am trying to get my NPC examines to work, but i keep getting a nullpointerexception when trying to get the examine. Is it something todo with the cache or npcdefinitions or something idk of? Been messing with it for hours and can't figure out what exactly isnt going correctly.

Code:

java.lang.NullPointerException at com.rs.net.decoders.handlers.NPCHandler.handleExamine(NPCHandler.java:33) at com.rs.net.decoders.WorldPacketsDecoder.processPackets(WorldPacketsDecoder.java:1375) at com.rs.net.decoders.WorldPacketsDecoder.decode(WorldPacketsDecoder.java:258) at com.rs.net.ServerChannelHandler.messageReceived(ServerChannelHandler.java:96) at org.jboss.netty.channel.SimpleChannelHandler.handleUpstream(SimpleChannelHandler.java:100) at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564) at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:559) at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:274) at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:261) at org.jboss.netty.channel.socket.nio.NioWorker.read(NioWorker.java:351) at org.jboss.netty.channel.socket.nio.NioWorker.processSelectedKeys(NioWorker.java:282) at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:202) at org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108) at org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:44) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source)

Any help is appreciated and lmk if there is any files you need to see for more clarification

First post ftw, mainly a runeserver browser :P

This is a classic Runtime Exception, Unchecked Exception, called a Null-pointer exception, in java. It means a line of code has a null object reference being called..

Code:

at com.rs.net.decoders.handlers.NPCHandler.handleExamine(NPCHandler.java:33)

Show us; Line 33 - NPCHandler, preferably the entire method/statement.

Just another note; your revision is 667, therefor should likely be in the 503+ section instead of RS2. ^^

Quote:

Originally Posted by Lumiere [Only registered and activated users can see links. Click Here To Register...]

Just another note; your revision is 667, therefor should likely be in the 503+ section instead of RS2. ^^

My bad, didn't know higher revisions had their own section ^_^

OT:

Code:

public static void handleExamine(final Player player, InputStream stream) { player.sm("in the method"); int npcIndex = stream.readUnsignedShort128(); final NPC npc = World.getNPCs().get(npcIndex); player.getPackets().sendNPCMessage(0, npc, NPCExamines.getExamine(npc.getId())); if (player.getRights() >= 9) { player.getPackets().sendGameMessage( "NPC - [id=" + npc.getId() + ", loc=[" + npc.getX() + ", " + npc.getY() + ", " + npc.getPlane() + "]]."); } }

Quote:

Originally Posted by Yagada [Only registered and activated users can see links. Click Here To Register...]

My bad, didn't know higher revisions had their own section ^_^

OT:

Code:

public static void handleExamine(final Player player, InputStream stream) { player.sm("in the method"); int npcIndex = stream.readUnsignedShort128(); final NPC npc = World.getNPCs().get(npcIndex); player.getPackets().sendNPCMessage(0, npc, NPCExamines.getExamine(npc.getId())); if (player.getRights() >= 9) { player.getPackets().sendGameMessage( "NPC - [id=" + npc.getId() + ", loc=[" + npc.getX() + ", " + npc.getY() + ", " + npc.getPlane() + "]]."); } }

Just add a null check:

Code:

player.sm("in the method"); int npcIndex = stream.readUnsignedShort128(); final NPC npc = World.getNPCs().get(npcIndex); if (npc != null) { player.getPackets().sendNPCMessage(0, npc, NPCExamines.getExamine(npc.getId())); if (player.getRights() >= 9) { player.getPackets().sendGameMessage( "NPC - [id=" + npc.getId() + ", loc=[" + npc.getX() + ", " + npc.getY() + ", " + npc.getPlane() + "]]."); } }

Quote:

Originally Posted by Professor Oak [Only registered and activated users can see links. Click Here To Register...]

Just add a null check:

Code:

player.sm("in the method"); int npcIndex = stream.readUnsignedShort128(); final NPC npc = World.getNPCs().get(npcIndex); if (npc != null) { player.getPackets().sendNPCMessage(0, npc, NPCExamines.getExamine(npc.getId())); if (player.getRights() >= 9) { player.getPackets().sendGameMessage( "NPC - [id=" + npc.getId() + ", loc=[" + npc.getX() + ", " + npc.getY() + ", " + npc.getPlane() + "]]."); } }

Pointless, the npc there should never return null. Only possibility is if the given index doesn't exist server side which implies that the stream is being read incorrectly. A lot of handling regarding NPCs is being done below there so worst case scenario, I'd add a return if the npc is somehow null although this won't resolve the main issue here.

Quote:

Originally Posted by Kris [Only registered and activated users can see links. Click Here To Register...]

Pointless, the npc there should never return null. Only possibility is if the given index doesn't exist server side which implies that the stream is being read incorrectly. A lot of handling regarding NPCs is being done below there so worst case scenario, I'd add a return if the npc is somehow null although this won't resolve the main issue here.

Yea i had a null check there but was seeing what was going on with the npc. It is infact telling me that the npc is null, but its there ingame and I can open shops, etc with all npcs.

If the npc is null, then the problem is either with how you get your npcIndex or World.getNPCs().get(npcIndex). If you're using an IDE that has a debugger, I'd suggest setting a breakpoint there and checking whether npcIndex is what you expect it to be, then step through the code and see why npc ends up being null. If you need help with that send me a message and I could walk you through that on teamviewer or something.