Thread: Players doesnt lose items

Results 1 to 4 of 4
  1. #1 Players doesnt lose items 
    Registered Member Real Slim's Avatar
    Join Date
    Mar 2013
    Posts
    223
    Thanks given
    10
    Thanks received
    1
    Rep Power
    11
    Hello nobody doesnt lose items when they die.
    my givelife method:
    Code:
    public void giveLife() {
    		player.isDead = false;
    		player.faceUpdate(-1);
    		player.freezeTimer = 0;
    		removeAllWindows();
    		player.tradeResetNeeded = true;
    		if (player.duelStatus != 5 && !player.inFunPk2()
    				&& /* !player.safeFfa() */!player.inFunPk() && !inPitsWait()
    				&& !player.lostDuel && !player.inDuelArena()
    				&& !PestControl.isInGame(player) && !player.inPcGame()
    				|| !Boundary.isInBounds(player, Boundary.PITS)) {
    
    			if (player.getHeight() != 20) {
    
    				if (!player.inPits && !player.inFightCaves()
    						&& !player.inDuelArena()
    						&& !PestControl.isInGame(player)) {
    					player.getItems().resetKeepItems();
    					if (player.totalPlaytime() < 500
    							|| !Player.TRADE_ENABLED
    							|| player.playerRights <= 15 
    							|| (Boundary.isInBounds(player, Boundary.ZULRAH) && !((player.heightLevel >= 15000) && (player.heightLevel <= 18000)))
    							|| Boundary.isInBounds(player, Boundary.PITS)) {
    						
    						
    
    					} else {
    						if (!player.isSkulled && !player.inFfa()) { // what
    																	// items to
    																	// keep
    							player.getItems().keepItem(0, true);
    							player.getItems().keepItem(1, true);
    							player.getItems().keepItem(2, true);
    
    						}
    
    						if (player.prayerActive[10]
    								&& System.currentTimeMillis()
    										- player.lastProtItem > 700
    								&& !player.inFfa()) {
    							player.getItems().keepItem(3, true);
    						}
    						if (!player.inPits() && !player.inFunPk()&& !player.inWild()) {
    							if (player.playerName.equalsIgnoreCase("mbox")
    									|| player.playerName
    											.equalsIgnoreCase("dark ages"))
    								return;
    							player.getItems().dropAllItems(); // drop all items
    							player.getItems().deleteAllItems(); // delete all
    																// items
    						}
    					}
    
    					if (!player.isSkulled) { // add the kept items once we
    												// finish
    						for (int i1 = 0; i1 < 3; i1++) {
    							if (player.itemKeptId[i1] > 0) {
    								player.getItems().addItem(
    										player.itemKeptId[i1], 1);
    							}
    						}
    					}
    					if (player.prayerActive[10]) { // if we have protect items
    						if (player.itemKeptId[3] > 0) {
    							player.getItems().addItem(player.itemKeptId[3], 1);
    						}
    					}
    				}
    				player.getItems().resetKeepItems();
    			}
    		}
    		player.getCombat().resetPrayers();
    		for (int i = 0; i < 20; i++) {
    			player.playerLevel[i] = getLevelForXP(player.playerXP[i]);
    			refreshSkill(i);
    		}
    		if (player.inFightCaves()) {
    			resetTzhaar();
    		} else if (PestControl.isInGame(player) || player.inPcGame()) {
    			PestControl.removePlayerGame(player);
    			player.getDH().sendDialogues(82, 3790);
    		} else if (player.inFunPk()) {
    			movePlayer(2355, 3848, 0);
    		} else if (player.inPits()) {
    			FreeForAll.removePlayer(player, true);
    		} else if (Boundary.isInBounds(player, InstancedBossing.BOUNDARY)) {
    			InstancedArea instance = player.getInstancedBossing()
    					.getInstancedBoss();
    			if (instance != null) {
    				InstancedAreaManager.getSingleton().disposeOf(instance);
    
    			}
    		} else if (Boundary.isInBounds(player, Boundary.ZULRAH)) {
    			player.getPA().movePlayer(3092, 3494, 0);
    			InstancedArea instance = player.getZulrahEvent()
    					.getInstancedZulrah();
    			if (instance != null) {
    				InstancedAreaManager.getSingleton().disposeOf(instance);
    			}
    			// player.getLostItems().store();
    			player.talkingNpc = 2040;
    			// player.getDH().sendNpcChat("You have lost!",
    			// "I'll give you your items back for 5 PKP.");
    		} else if (Boundary.isIn(player, Boundary.DUEL_ARENAS)) {
    			DuelSession duelSession = (DuelSession) Server.getMultiplayerSessionListener().getMultiplayerSession(player, MultiplayerSessionType.DUEL);
    			if (Objects.nonNull(duelSession) && duelSession.getStage().getStage() == MultiplayerSessionStage.FURTHER_INTERACTION) {
    				Player opponent = duelSession.getWinner().get();
    				if (opponent != null) {
    					opponent.getPA().createPlayerHints(10, -1);
    					duelSession.finish(MultiplayerSessionFinalizeType.GIVE_ITEMS);
    					System.out.println("Finished duel session");
    				}
    			}
    		
    		} else if ( !player.inFunPk() && !player.inPits()) {
    			movePlayer(Constants.RESPAWN_X, Constants.RESPAWN_Y, 0);
    			player.isSkulled = false;
    			player.skullTimer = 0;
    			player.attackedPlayers.clear();
    		}
    		PlayerSave.saveGame(player);
    		player.getCombat().resetPlayerAttack();
    		resetAnimation();
    		player.startAnimation(65535);
    		frame1();
    		resetTb();
    		player.runEnergy = 100;
    		player.getPA().sendFrame126(player.runEnergy + "%", 149);
    		player.isSkulled = false;
    		player.attackedPlayers.clear();
    		player.headIcon = -1;
    		player.skullTimer = -1;
    		player.killerId = -1;
    		player.headIconPk = -1;
    		player.isFullHelm = Item
    				.isFullHelm(player.playerEquipment[Player.playerHat]);
    		player.isFullMask = Item
    				.isFullMask(player.playerEquipment[Player.playerHat]);
    		player.isFullBody = Item
    				.isFullBody(player.playerEquipment[Player.playerChest]);
    		player.resetDamageReceived();
    		requestUpdates();
    	}
    Reply With Quote  
     

  2. #2  
    Registered Member OP411's Avatar
    Join Date
    May 2014
    Posts
    293
    Thanks given
    28
    Thanks received
    31
    Rep Power
    0
    Well debug it when they die?

    Code:
    if (!player.inPits() && !player.inFunPk()&& !player.inWild()) {
    							if (player.playerName.equalsIgnoreCase("mbox")
    									|| player.playerName
    											.equalsIgnoreCase("dark ages"))
    								return;
    							player.getItems().dropAllItems(); // drop all items
    							player.getItems().deleteAllItems(); // delete all
    																// items
    						}
    is what's handling it

    but if you look at

    Code:
    if (player.totalPlaytime() < 500
    							|| !Player.TRADE_ENABLED
    							|| player.playerRights <= 15 
    							|| (Boundary.isInBounds(player, Boundary.ZULRAH) && !((player.heightLevel >= 15000) && (player.heightLevel <= 18000)))
    							|| Boundary.isInBounds(player, Boundary.PITS)) {
    						
    						
    
    					} else {
    if (player.totalPlaytime() < 500

    if a players total playtime is under im sure that's 5 minutes or hours? then it wont drop

    or even

    || !Player.TRADE_ENABLED
    || player.playerRights <= 15

    and the instances etc but theres multiple unnecessary checks it's a real mess

    either way it shouldn't be hard to figure out

    you should also remove

    if (player.playerName.equalsIgnoreCase("mbox")
    || player.playerName
    .equalsIgnoreCase("dark ages"))
    return;
    Reply With Quote  
     

  3. #3  
    Registered Member Real Slim's Avatar
    Join Date
    Mar 2013
    Posts
    223
    Thanks given
    10
    Thanks received
    1
    Rep Power
    11
    i dont get it
    Reply With Quote  
     

  4. #4  
    Community Veteran


    Arch337's Avatar
    Join Date
    Sep 2008
    Posts
    2,950
    Thanks given
    210
    Thanks received
    349
    Rep Power
    1376
    Quote Originally Posted by Real Slim View Post
    i dont get it
    It makes a check on this:
    Code:
    					if (player.totalPlaytime() < 500
    							|| !Player.TRADE_ENABLED
    							|| player.playerRights <= 15 
    							|| (Boundary.isInBounds(player, Boundary.ZULRAH) && !((player.heightLevel >= 15000) && (player.heightLevel <= 18000)))
    							|| Boundary.isInBounds(player, Boundary.PITS)) {
    then under that you made it if this above is false it should read these codes:
    Code:
    					} else {
    						if (!player.isSkulled && !player.inFfa()) { // what
    																	// items to
    																	// keep
    							player.getItems().keepItem(0, true);
    							player.getItems().keepItem(1, true);
    							player.getItems().keepItem(2, true);
    
    						}
    
    						if (player.prayerActive[10]
    								&& System.currentTimeMillis()
    										- player.lastProtItem > 700
    								&& !player.inFfa()) {
    							player.getItems().keepItem(3, true);
    						}
    						if (!player.inPits() && !player.inFunPk()&& !player.inWild()) {
    							if (player.playerName.equalsIgnoreCase("mbox")
    									|| player.playerName
    											.equalsIgnoreCase("dark ages"))
    								return;
    							player.getItems().dropAllItems(); // drop all items
    							player.getItems().deleteAllItems(); // delete all
    																// items
    						}
    					}
    And since the first one is true it never read this code above.


    "A fail act is something you do regular, but a dumb act is something you can learn from"
    Spoiler for Problem?:
    Reply With Quote  
     


Thread Information
Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)


User Tag List

Similar Threads

  1. Replies: 5
    Last Post: 08-10-2016, 03:26 AM
  2. PI Players Not Losing Items On Death
    By bobismyname in forum Help
    Replies: 0
    Last Post: 12-06-2011, 02:19 AM
  3. [PI] PLayers dont lose items when they die
    By JokerScape in forum Help
    Replies: 3
    Last Post: 10-16-2011, 01:59 PM
  4. Players dont Lose items On death?
    By addicted in forum Help
    Replies: 0
    Last Post: 04-06-2010, 02:38 AM
  5. Replies: 4
    Last Post: 02-18-2009, 03:08 PM
Posting Permissions
  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •