Thread: Vencillio source Help

In all honesty, if you are looking to improve your developing skills, I'd consider working with a different base. I personally downloaded Vencillio as soon as it was released (Friends with the old owner) and found soooo many bugs that needed to be fixed, both Client side and Server side. It would be much more worth it to start from scratch.

If you insist on staying with this base, PM me and I will look through the code as to what you are looking to remove to fix it. Will take about a week. Just pm me on here.

Ive fixed most bugs, still have quite a bit to do, but im just unsure on checks and why my NPCs suddendly stopped spawning when i added the new data.

Originally Posted by Plado

Change the npc bits

. I'll try that when i get home, ty for the suggestion.

EDIT: This is the NPC Bit Code: (Incase you guys/gals can figure out how to increase correctly before i)

Server:

public static void addNewNpc(StreamBuffer.OutBuffer out, Player player, Mob mob) {
out.writeBits(14, mob.getIndex());
Location delta = Utility.delta(player.getLocation(), mob.getLocation());
out.writeBits(5, delta.getY());
out.writeBits(5, delta.getX());
out.writeBits(1, 0);
out.writeBits(16, mob.getId());
out.writeBit(true);
}

Client:

private void updateNPCs(Stream stream, int i) {
anInt839 = 0;
anInt893 = 0;
method139(stream);
method46(i, stream);
method86(stream);
for (int k = 0; k < anInt839; k++) {
int l = anIntArray840[k];
if (npcArray[l].anInt1537 != loopCycle) {
npcArray[l].desc = null;
npcArray[l] = null;
}
}

if (stream.currentOffset != i) {
Signlink.reporterror(myUsername + " size mismatch in getnpcpos - pos:" + stream.currentOffset + " psize:" + i);
throw new RuntimeException("eek");
}
for (int i1 = 0; i1 < npcCount; i1++)
if (npcArray[npcIndices[i1]] == null) {
Signlink.reporterror(myUsername + " null entry in npc list - pos:" + i1 + " size:" + npcCount);
throw new RuntimeException("eek");
}

}

Try finding where npcCount i set in the script, and if that has anything to do with it.

Originally Posted by The Reverse

We already have enough shitheads like you who don't appreciate a good release. I doubt you even tried vencillio.

Well in his Defence, Vencillio isnt the easiest to code, and even im still trying to figure out most of their set up, but yeah i agree, those comments arnt helpful at all and just clog out the thread and goes towards his post count. Woulda been better to not comment anything at all

Taking a more indepth look at it, look for npcIndices and npcArray, you may need to increase the size of the Array for the npc's. If that isn't it post an update. Im not finding anything in my source that would stop you from adding npc's. If all else fails, try starting fresh with the original source download and dumping the data again. Maybe something went wrong in the dump.

Okay ill be home in an hour to look. Nothing is wrong with the NPCs, they just arnt spawning. I didnt first think it was the npc bit, cause if i added def to say npc 19234. Then spawned him, he looks fine. But literally everyone of my npcs will not spawn, as if i deleted my npcspawning.java or w/e vencillio calls it