Thread: Some errors

Results 1 to 3 of 3
  1. #1 Some errors 
    InsidiaX RSPS
    Join Date
    Jun 2011
    Posts
    92
    Thanks given
    3
    Thanks received
    4
    Rep Power
    8
    Hey, I get these two errors.

    Firstly, I get this error within my ::yell command:

    Code:
    src\server\model\players\packets\Commands.java:256: unreachable statement
                                                            if (c.Jail == true){
                                                            ^
    Note: Some input files use unchecked or unsafe operations.
    Note: Recompile with -Xlint:unchecked for details.
    1 error
    Press any key to continue . . .
    Code for my yell command:
    Code:
    			if (playerCommand.startsWith("yell")) {
    				for (int j = 0; j < Server.playerHandler.players.length; j++) {
    					if (Server.playerHandler.players[j] != null) {
    						Client c2 = (Client)Server.playerHandler.players[j];
    							if (Connection.isMuted(c))
    							c.sendMessage("You are muted and cannot yell.");
    							return;
    							if (c.Jail == true){
    							c.sendMessage("You can't yell whilst in jail!");
    							return;
    							}
    							if (c.isDonator == 1 && (c.playerRights < 1 || c.playerRights > 3)){
    								c2.sendMessage("<shad=6081134>[Donator]</col><img=0>"+ Misc.optimizeText(c.playerName) +": "
    												+ Misc.optimizeText(playerCommand.substring(5)) +"");
    							}else if (c.playerRights == 1){
    								c2.sendMessage("<shad=123456>[Moderator]</col><img=1>"+ Misc.optimizeText(c.playerName) +": "
    												+ Misc.optimizeText(playerCommand.substring(5)) +"");
    							}else if (c.playerRights == 2){
    								c2.sendMessage("<shad=65535>[Admin]</col><img=2>"+ Misc.optimizeText(c.playerName) +": "
    												+ Misc.optimizeText(playerCommand.substring(5)) +"");
    							}else if (c.playerName.equalsIgnoreCase("Brandon") && c.playerName.equalsIgnoreCase("Theseus")){
    								c2.sendMessage("<shad=15695415>[Owner]</col><img=2>"+ Misc.optimizeText(c.playerName) +": "
    												+ Misc.optimizeText(playerCommand.substring(5)) +"");
    							}else if (c.playerRights == 3){
    								c2.sendMessage("<shad=255>[Co-Owner]</col><img=2>"+ Misc.optimizeText(c.playerName) +": "
    												+ Misc.optimizeText(playerCommand.substring(5)) +"");
    							}else if (c.playerRights == 5){
    								c2.sendMessage("<shad=6081134>[Super Donator]</col><img=0>"+ Misc.optimizeText(c.playerName) +": "
    												+ Misc.optimizeText(playerCommand.substring(5)) +"");
    							}else if (c.playerRights == 0 && c.isDonator == 0) {
    								c.sendMessage("<shad=6081134><img=0>You must be a Donator to use ::yell! Type ::Donate for more information.<img=0></col>");
    									
    							}
    						}
    					}
    				}
    And also, my next error - I get this when using a Christmas Cracker on another player:
    Code:
    [30/03/12 4:31 PM]: java.lang.ArrayIndexOutOfBoundsException: 512
    [30/03/12 4:31 PM]:     at server.model.players.packets.ItemOnPlayer.processPack
    et(ItemOnPlayer.java:16)
    [30/03/12 4:31 PM]:     at server.model.players.PacketHandler.processPacket(Pack
    etHandler.java:140)
    [30/03/12 4:31 PM]:     at server.model.players.Client.processQueuedPackets(Clie
    nt.java:1817)
    [30/03/12 4:31 PM]:     at server.model.players.PlayerHandler.process(PlayerHand
    ler.java:167)
    [30/03/12 4:31 PM]:     at server.Server.main(Server.java:190)
    Code for my ItemOnPlayer class:
    Code:
    package server.model.players.packets;
    
    import server.Server;
    import server.model.players.Client;
    import server.model.players.PacketType;
    import server.util.Misc;
    
    /**
     * @author JaydenD12/Jaydennn
     */
    
    public class ItemOnPlayer implements PacketType {
    	@Override
    	public void processPacket(Client c, int packetType, int packetSize) {
    		int playerId = c.inStream.readUnsignedWord();
    		int itemId = c.playerItems[c.inStream.readSignedWordBigEndian()] - 1;
    
    		switch (itemId) {
    		case 962:
    			handleCrackers(c, itemId, playerId);
    			break;
    		default:
    			c.sendMessage("Nothing interesting happens.");
    			break;
    		}
    
    	}
    
    	private void handleCrackers(Client c, int itemId, int playerId) {
    		Client usedOn = (Client) Server.playerHandler.players[playerId];
    		if (!c.getItems().playerHasItem(itemId))
    			return;
    		
    		if (usedOn.getItems().freeSlots() < 1) {
    			c.sendMessage("The other player doesn't have enough inventory space!");
    			return;
    		}
    		
    		c.sendMessage("You crack the cracker...");
    		c.getItems().deleteItem(itemId, 1);
    		
    		if (Misc.random(1) == 0) {
    			c.getItems().addItem(getRandomPhat(), 1);
    			c.sendMessage("You got the prize!");
    			usedOn.sendMessage("You didn't get the prize.");
    		} else {
    			usedOn.getItems().addItem(getRandomPhat(), 1);
    			usedOn.sendMessage("You got the prize!");
    			c.sendMessage("You didn't get the prize.");
    		}
    	}
    
    	private int getRandomPhat() {
    		int[] phats = { 1038, 1040, 1042, 1044, 1048 };
    		return phats[(int) Math.floor(Math.random() * phats.length)];
    	}
    	
    }

    Any help is appreciated and thanked, will rep to helpers.



    Spoiler for I Support RS317:

    Reply With Quote  
     

  2. #2  
    Registered Member

    Join Date
    Sep 2008
    Posts
    4,833
    Thanks given
    894
    Thanks received
    1,439
    Rep Power
    2924
    Unreachable statment means that that particular code can never be reached, as the method has been returned in all routes before reaching your (if jail blah blah blah).
    Code:
     if (Connection.isMuted(c))
    							c.sendMessage("You are muted and cannot yell.");
    							return;
    Must be contained.
    Use this
    Code:
     if (Connection.isMuted(c)) {
    							c.sendMessage("You are muted and cannot yell.");
    							return;
    }
    EDIT:

    For Error 2: Your itemId should be initialized as this.
    Code:
    int itemId = c.getInStream().readSignedWordA();
    "Know thy self, know thy enemy. A thousand battles, a thousand victories." - Sun Tzu
    GitHub: https://github.com/Faris-Mckay
    Reply With Quote  
     

  3. #3  
    InsidiaX RSPS
    Join Date
    Jun 2011
    Posts
    92
    Thanks given
    3
    Thanks received
    4
    Rep Power
    8
    Thanks Faris, repped



    Spoiler for I Support RS317:

    Reply With Quote  
     


Thread Information
Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)


User Tag List

Similar Threads

  1. Replies: 72
    Last Post: 01-24-2017, 02:03 PM
  2. 562 Loading 602 GE Errors 2 Errors
    By .Optimum in forum Help
    Replies: 1
    Last Post: 07-12-2011, 07:30 AM
  3. D claw tut errors 2 errors!
    By T-Sex in forum Help
    Replies: 17
    Last Post: 12-30-2010, 06:25 PM
  4. Replies: 11
    Last Post: 11-07-2009, 08:43 PM
  5. Replies: 1
    Last Post: 09-24-2009, 12:39 AM
Posting Permissions
  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •