Thread: [PI]Adding pickup command..

Results 1 to 9 of 9
  1. #1 [PI]Adding pickup command.. 
    Registered Member
    Join Date
    Dec 2011
    Posts
    128
    Thanks given
    17
    Thanks received
    3
    Rep Power
    18
    Yeah, I dont understand what im doing wrong here, this is the code im using:

    Code:
     			if (command.startsWith("pickup") && playerRights >2) {
    				String[] args = command.split("");
    			if(args.length ==3) {
    				int newItemID = Interger.parseInt(args[1]);
    				int newItemAmount = Interger.parseInt(args[2]);
    				if (newItemID <= 160000 && newItemID >= ) {
    					addItem(newItemID, newItemAmount);
    				} else {
    					sendMessage("No such item.");
    					}
    				} else {
    					sendMessage("Try as ::pickup 995 100");
    					}
    This is the error im getting...

    Code:
    src\server\model\players\packets\Commands.java:42: error: illegal start of expre
    ssion
                                    if (newItemID <= 160000 && newItemID >= ) {
                                                                                                    ^
    1 error
    Press any key to continue . . .
     

  2. #2  


    RS Wiki's Avatar
    Join Date
    Mar 2011
    Age
    29
    Posts
    9,688
    Thanks given
    1,752
    Thanks received
    3,103
    Rep Power
    5000
    Code:
    			if (playerCommand.startsWith("item") && c.playerRights >= 3) {
    				try {
    					String[] args = playerCommand.split(" ");
    					if (args.length == 3) {
    						int newItemID = Integer.parseInt(args[1]);
    						int newItemAmount = Integer.parseInt(args[2]);
    						if ((newItemID <= 20000) && (newItemID >= 0)) {
    							c.getItems().addItem(newItemID, newItemAmount);		
    						} else {
    							c.sendMessage("No such item.");
    						}
    					} else {
    						c.sendMessage("Use as ::item 995 200 for example 200 gp");
    					}
    				} catch(Exception e) {
    					
    				}
    			}
    yellow = player rights.
    0 player, 1 mod, 2 admin, 3 owner.
    All the best,
    Wiki




    coming soon
     

  3. #3  
    Registered Member
    Join Date
    Dec 2011
    Posts
    128
    Thanks given
    17
    Thanks received
    3
    Rep Power
    18
    Quote Originally Posted by RS Wiki View Post
    Code:
    			if (playerCommand.startsWith("item") && c.playerRights >= 3) {
    				try {
    					String[] args = playerCommand.split(" ");
    					if (args.length == 3) {
    						int newItemID = Integer.parseInt(args[1]);
    						int newItemAmount = Integer.parseInt(args[2]);
    						if ((newItemID <= 20000) && (newItemID >= 0)) {
    							c.getItems().addItem(newItemID, newItemAmount);		
    						} else {
    							c.sendMessage("No such item.");
    						}
    					} else {
    						c.sendMessage("Use as ::item 995 200 for example 200 gp");
    					}
    				} catch(Exception e) {
    					
    				}
    			}
    yellow = player rights.
    0 player, 1 mod, 2 admin, 3 owner.
    Thanks for the attempt, but i have this error now:

    Code:
     
    src\server\model\players\packets\Commands.java:580: error: class, interface, or
    enum expected
    }
    ^
    1 error
    Press any key to continue . . .
     

  4. #4  
    Registered Member
    Join Date
    Oct 2009
    Posts
    62
    Thanks given
    0
    Thanks received
    0
    Rep Power
    0
    Spoiler for Working item command flawless.:
    [SPOIL][SPOIL][SPOIL][SPOIL][SPOIL][SPOIL][SPOIL]
    Code:
    if (playerCommand.startsWith("item")) 
    			{
    				if  c.inWild() 
    					return;
    				try {
    					String[] args = playerCommand.split(" ");
    					if (args.length == 3) {
    						int newItemID = Integer.parseInt(args[1]);
    						int newItemAmount = Integer.parseInt(args[2]);
    						for (int i = 0; i < Config.UNSPAWNABLE.length; i++) {
    							if (c.getItems().getItemName(newItemID).toLowerCase().contains(Config.UNSPAWNABLE[i]) && c.playerRights < 2) {
    								c.sendMessage("This item is currently unspawnable.");
    								return;
    							}
    						}
    						if ((newItemID <= 20073) && (newItemID >= 0)) {
    							c.getItems().addItem(newItemID, newItemAmount);		
    						} else {
    							c.sendMessage("That item does not exist.");
    						}
    					} else {
    						c.sendMessage("Wrong usage: (Ex:(::pickup_ID_Amount)(::item 995 1))");
    					}
    				} catch(Exception e) {
    					e.printStackTrace();
    				}
    			}
    [/SPOIL][/SPOIL][/SPOIL][/SPOIL][/SPOIL][/SPOIL][/SPOIL]



    or,
    Spoiler for another working item command:
    Code:
    if (playerCommand.startsWith("item")) 
    			{
    				if  c.inWild() 
    					return;
    				try {
    					String[] args = playerCommand.split(" ");
    					if (args.length == 3) {
    						int newItemID = Integer.parseInt(args[1]);
    						int newItemAmount = Integer.parseInt(args[2]);
    						for (int i = 0; i < Config.UNSPAWNABLE.length; i++) {
    							if (c.getItems().getItemName(newItemID).toLowerCase().contains(Config.UNSPAWNABLE[i]) && c.playerRights < 2) {
    								c.sendMessage("This item is currently unspawnable.");
    								return;
    							}
    						}
    						if ((newItemID <= 20073) && (newItemID >= 0)) {
    							c.getItems().addItem(newItemID, newItemAmount);		
    						} else {
    							c.sendMessage("That item does not exist.");
    						}
    					} else {
    						c.sendMessage("Wrong usage: (Ex:(::pickup_ID_Amount)(::item 995 1))");
    					}
    				} catch(Exception e) {
    					e.printStackTrace();
    				}
    			}
     

  5. #5  
    Registered Member
    Join Date
    Dec 2011
    Posts
    128
    Thanks given
    17
    Thanks received
    3
    Rep Power
    18
    Quote Originally Posted by Happy<small>Tm</small> View Post
    Spoiler for Working item command flawless.:
    [SPOIL][SPOIL][SPOIL][SPOIL][SPOIL][SPOIL][SPOIL]
    Code:
    if (playerCommand.startsWith("item")) 
    			{
    				if  c.inWild() 
    					return;
    				try {
    					String[] args = playerCommand.split(" ");
    					if (args.length == 3) {
    						int newItemID = Integer.parseInt(args[1]);
    						int newItemAmount = Integer.parseInt(args[2]);
    						for (int i = 0; i < Config.UNSPAWNABLE.length; i++) {
    							if (c.getItems().getItemName(newItemID).toLowerCase().contains(Config.UNSPAWNABLE[i]) && c.playerRights < 2) {
    								c.sendMessage("This item is currently unspawnable.");
    								return;
    							}
    						}
    						if ((newItemID <= 20073) && (newItemID >= 0)) {
    							c.getItems().addItem(newItemID, newItemAmount);		
    						} else {
    							c.sendMessage("That item does not exist.");
    						}
    					} else {
    						c.sendMessage("Wrong usage: (Ex:(::pickup_ID_Amount)(::item 995 1))");
    					}
    				} catch(Exception e) {
    					e.printStackTrace();
    				}
    			}
    [/SPOIL][/SPOIL][/SPOIL][/SPOIL][/SPOIL][/SPOIL][/SPOIL]
    Thanks for the attempt lol but Im still getting errors:
    Code:
    src\server\model\players\packets\Commands.java:39: error: '(' expected
                                    if  c.inWild()
                                      ^
    src\server\model\players\packets\Commands.java:39: error: ')' expected
                                    if  c.inWild()
                                                  ^
    src\server\model\players\packets\Commands.java:589: error: class, interface, or
    enum expected
    }
    ^
    3 errors
    Press any key to continue . . .
     

  6. #6  
    Extreme Donator


    Join Date
    May 2010
    Posts
    1,344
    Thanks given
    961
    Thanks received
    132
    Rep Power
    216
    Code:
    if (c.inWild())
     

  7. #7  
    I built Grand Exchange :)
    dark-natural's Avatar
    Join Date
    Mar 2011
    Posts
    178
    Thanks given
    30
    Thanks received
    6
    Rep Power
    9
    Quote Originally Posted by Vivvvid View Post
    Yeah, I dont understand what im doing wrong here, this is the code im using:

    Code:
     			if (command.startsWith("pickup") && playerRights >2) {
    				String[] args = command.split("");
    			if(args.length ==3) {
    				int newItemID = Interger.parseInt(args[1]);
    				int newItemAmount = Interger.parseInt(args[2]);
    				if (newItemID <= 160000 && newItemID >= ) {
    					addItem(newItemID, newItemAmount);
    				} else {
    					sendMessage("No such item.");
    					}
    				} else {
    					sendMessage("Try as ::pickup 995 100");
    					}
    This is the error im getting...

    Code:
    src\server\model\players\packets\Commands.java:42: error: illegal start of expre
    ssion
                                    if (newItemID <= 160000 && newItemID >= ) {
                                                                                                    ^
    1 error
    Press any key to continue . . .

     

  8. #8  
    Registered Member
    Join Date
    Oct 2009
    Posts
    62
    Thanks given
    0
    Thanks received
    0
    Rep Power
    0
    Ugh seriously that means add or remove a bracket and remove the wildy part.
     

  9. #9  
    GANGNAM STYLE!

    Ohad's Avatar
    Join Date
    Aug 2011
    Posts
    3,179
    Thanks given
    152
    Thanks received
    352
    Rep Power
    1671
    From what i understood you just need to add this..
    Code:
    if (newItemID <= 160000 && newItemID >= 1) {
     


Thread Information
Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)


User Tag List

Similar Threads

  1. Pickup Command
    By Smyth in forum Help
    Replies: 1
    Last Post: 09-24-2011, 01:00 PM
  2. Replies: 6
    Last Post: 12-03-2009, 11:50 PM
  3. Pickup command(::Pickup magic shortbow)
    By hoodlom in forum Snippets
    Replies: 6
    Last Post: 03-26-2009, 07:39 AM
  4. Can't Pickup Items - Not Pickup Command
    By tucybro in forum Help
    Replies: 10
    Last Post: 01-23-2009, 03:30 PM
Posting Permissions
  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •