Thread: [PI] Possible Memory Leak -- GetLevel4Xp

Results 1 to 2 of 2
  1. #1 [PI] Possible Memory Leak -- GetLevel4Xp 
    Registered Member
    Join Date
    Jan 2011
    Posts
    41
    Thanks given
    0
    Thanks received
    0
    Rep Power
    1
    Base: SoulSplit PI Base

    Problem: Possiibly Memory Leak in getlevelforxp variable

    Errors(Compiling Errors): none

    Other Information/Media(Pictures, etc):
    I looked through visualVM to see if their was any other memory leaks and i saw it was using 13% for GetLevelForXp in player.java and i was told that it should be under 10% so can anyone please help me, ill pay if necessary.

    This is my variable i use in player.java
    Code:
    			int mag = (int) ((getLevelForXP(playerXP[6])) * 1.5);
    			int ran = (int) ((getLevelForXP(playerXP[4])) * 1.5);
    			int attstr = (int) ((double) (getLevelForXP(playerXP[0])) + (double) (getLevelForXP(playerXP[2])));
    			combatLevel = 0;
    			if (!newCmb)
    			{
    				if (ran > attstr) {
    					combatLevel = (int) (((getLevelForXP(playerXP[1])) * 0.25)
    					+ ((getLevelForXP(playerXP[3])) * 0.25)
    					+ ((getLevelForXP(playerXP[5])) * 0.125) + ((getLevelForXP(playerXP[4])) * 0.4875));
    				} else if (mag > attstr) {
    					combatLevel = (int) (((getLevelForXP(playerXP[1])) * 0.25)
    					+ ((getLevelForXP(playerXP[3])) * 0.25)
    					+ ((getLevelForXP(playerXP[5])) * 0.125) + ((getLevelForXP(playerXP[6])) * 0.4875));
    				} else {
    					combatLevel = (int) (((getLevelForXP(playerXP[1])) * 0.25)
    					+ ((getLevelForXP(playerXP[3])) * 0.25)
    					+ ((getLevelForXP(playerXP[5])) * 0.125)
    					+ ((getLevelForXP(playerXP[0])) * 0.325) + ((getLevelForXP(playerXP[2])) * 0.325));
    				}
    			}
    			else if (newCmb)
    			{
    				combatLevel = newCombat;
    			}
    			playerProps.writeByte(combatLevel);		// combat level		
    			playerProps.writeWord(0);		
    			str.writeByteC(playerProps.currentOffset);		
    			str.writeBytes(playerProps.buffer, playerProps.currentOffset, 0);
    		//}
    	}
    Reply With Quote  
     

  2. #2  
    Banned

    Join Date
    Jan 2009
    Age
    31
    Posts
    2,661
    Thanks given
    66
    Thanks received
    207
    Rep Power
    0
    getLevelForExp(playerXP[StatId]);

    is a very retarded way to handle obtaining the actual level the player is at.

    however i doubt it would cause a "memory leak" seeing as its not doing tooo much but calling it 1000's of times may cause some lag.

    also i would hope that this method only gets called when a player levels a "combat skill"

    so your not doing something like

    someString = "Opponents Combat Level: "+player.getCombat();

    instead storing the level to a variable like

    public byte combatLevel = 3;
    Reply With Quote  
     


Thread Information
Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)


User Tag List

Similar Threads

  1. Memory leak? Yes/no?
    By Crispytoast in forum Help
    Replies: 1
    Last Post: 02-20-2011, 11:43 AM
  2. Memory leak? Yes/no?
    By Crispytoast in forum Help
    Replies: 5
    Last Post: 02-20-2011, 03:00 AM
  3. [PI] Memory Leak... $45 For Fix! [PI]
    By `Eclipse™ in forum Help
    Replies: 2
    Last Post: 02-12-2011, 11:17 AM
  4. [PI] Memory Leak
    By Clockwork in forum Help
    Replies: 11
    Last Post: 02-08-2011, 07:33 AM
  5. $25 for a memory leak fix.
    By The Situationist in forum Help
    Replies: 4
    Last Post: 12-05-2010, 10:56 PM
Posting Permissions
  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •