Fishing(Event) Issue

**Galkon** · 06-23-2010, 08:50 AM

I finished my fishing skill, fixed all issues with it, except for one.

If you mass click the fishing spot, it "mass fishes". In other words, click it twice, it fishes two times as fast, basically starting a second event. But, I have this when you click a spot:

Code:

				if(!c.isFishing) {
					//Fishing.fishingEvent.stop();
					Fishing.doFishingEvent(c, npcType, 2);
				} else {
					Fishing.fishingEvent.stop();
				}

This is the event itself:

Code:

	public static Event fishingEvent = new Event(){
		@Override
		public void execute(EventContainer cont) {
			if(client.isFishing) {
				if(!runFishingCheck(client, fishingSpot, clickedSpot)) {
					cont.stop();
					return;
				}
				int checkedFish = checkFish(client, getFish(fishingSpot, clickedSpot));
				client.startAnimation(getAnim(fishingSpot, clickedSpot));
				client.getItems().addItem(checkedFish, 1);
				client.sendMessage("You catch " + getString(client.getItems().getItemName(checkedFish).toLowerCase()) + ".");
				if(getSpotBait(fishingSpot, clickedSpot) > 0)
					client.getItems().deleteItem(getSpotBait(fishingSpot, clickedSpot), 1);
				client.getPA().addSkillXP(getXP(checkedFish) * Config.XP_RATE, 10);
				client.getPA().refreshSkill(10);
				cont.setTick(20 * (300 - reducedTime(client, checkedFish)));
			}
		}
		@Override
		public void stop() {
			client.isFishing = false;
		}
	};

And where the event is initialized:

Code:

			if(!c.isFishing) {
				c.isFishing = true;
				EventManager.getSingleton().addEvent(fishingEvent, 20 * 200);
			}

I honestly can't figure it out. I've tried everything.

EDIT: Here is the event related stuff in Fishing.java

Spoiler for Fishing.java:

Code:

package server.model.players.skills;

import server.event.*;
import server.model.players.Client;
import server.Constants;

public class Fishing {

	public static int fishingSpot;
	public static int clickedSpot;
	public static Client client;

	public static void doFishingEvent(final Client c, final int spot, final int click) {
		try {
			fishingSpot = spot;
			clickedSpot = click;
			client = c;
			if(c.isFishing) {
				c.isFishing = false;
				return;
			}
			if(!runFishingCheck(c, spot, click)) {
				return;
			}
			c.startAnimation(getAnim(spot, click));
			if(!c.isFishing) {
				c.isFishing = true;
				EventManager.getSingleton().addEvent(fishingEvent, 4000);
			}
		} catch(Exception e) {
			e.printStackTrace();
		}
	}

	public static Event fishingEvent = new Event() {
		@Override
		public void execute(EventContainer cont) {
			if(client.isFishing) {
				if(!runFishingCheck(client, fishingSpot, clickedSpot)) {
					cont.stop();
					return;
				}
				int checkedFish = checkFish(client, getFish(fishingSpot, clickedSpot));
				client.startAnimation(getAnim(fishingSpot, clickedSpot));
				client.getItems().addItem(checkedFish, 1);
				client.sendMessage("You catch " + getString(client.getItems().getItemName(checkedFish).toLowerCase()) + ".");
				if(getSpotBait(fishingSpot, clickedSpot) > 0)
					client.getItems().deleteItem(getSpotBait(fishingSpot, clickedSpot), 1);
				client.getPA().addSkillXP(getXP(checkedFish) * Constants.XP_RATE, 10);
				client.getPA().refreshSkill(10);
				cont.setTick(20 * (300 - reducedTime(client, checkedFish)));
			}
		}
		@Override
		public void stop() {
			client.isFishing = false;
		}
	};

	public static boolean runFishingCheck(Client c, int spot, int click) {
		if(c.playerLevel[c.playerFishing] < getSpotLevel(spot, click)) {
			c.sendMessage("You need a fishing level of " + getSpotLevel(spot, click) + " to fish here.");
			return false;
		}
		if(!c.getItems().playerHasItem(getSpotItem(spot, click), 1) && getSpotItem(spot, click) != -1) {
			c.sendMessage("You need a " + c.getItems().getItemName(getSpotItem(spot, click)).toLowerCase() + " to fish here.");
			return false;
		}
		if(getSpotBait(spot, click) != -1 && !c.getItems().playerHasItem(getSpotBait(spot, click), 1)){
			c.sendMessage("You need some bait to fish here.");
			return false;
		}
		if(c.getItems().freeSlots() <= 0){
			c.sendMessage("You can't carry anymore fish.");
			return false;
		}
		return true;
	}

}

**hybrent** · 06-23-2010, 09:08 AM

Can't tell very well without looking at the whole thing, but why do you do:

Fishing.doFishingEvent(c, npcType, 2);

AND

EventManager.getSingleton().addEvent(fishingEvent, 20 * 200);

Wouldn't that be starting 2 events? (Unless that's not what doFishingEvent does)

Again, kinda hard to tell much from just lookin at snippets.

EDIT: One more question:
Does this glitch happen everytime you use events, or just with fishing?

**Galkon** · 06-23-2010, 09:16 AM

Originally Posted by hybrent

Can't tell very well without looking at the whole thing, but why do you do:

Fishing.doFishingEvent(c, npcType, 2);

AND

EventManager.getSingleton().addEvent(fishingEvent, 20 * 200);

Wouldn't that be starting 2 events? (Unless that's not what doFishingEvent does)

Again, kinda hard to tell much from just lookin at snippets.

EDIT: One more question:
Does this glitch happen everytime you use events, or just with fishing?

I've only ever really used Events for my Fishing skill. I have it for cooking as well, but cooking has no problems whatsoever.

And;

Code:

Fishing.doFishingEvent(c, npcType, 2);

contains

Code:

EventManager.getSingleton().addEvent(fishingEvent, 20 * 200);

in it.

Nothing is being initialized twice unless you click twice. But it shouldn't.

EDIT: I added the main methods of Fishing.java to the first post(in the spoiler).

**Lmctruck30** · 06-23-2010, 09:21 AM

check if the event is even working at the right times...

then check if its making new events....

**hybrent** · 06-23-2010, 09:23 AM

Ah mmk...

In the doFishingEvent method, try putting the c.isFishing = true after the event starts.
That way it doesn't think it's fishing before it actually is?

Probably won't change anything, but
MEH.

**Galkon** · 06-23-2010, 09:23 AM

Originally Posted by Lmctruck30

check if the event is even working at the right times...

then check if its making new events....

The event works at the right time...? You click the spot, it waits a bit before you can catch a fish(starts animation), then it starts catching fish with a timer between each fish based on your level and the fish you're fishing.

What do you mean check if it's making new events? How. Rofl.

**Stewie** · 06-23-2010, 09:26 AM

I think he means once the event starts, check to see if its trying to start another fishing event, and if it is, stop the extra event.

**Galkon** · 06-23-2010, 09:30 AM

Originally Posted by Bing

I think he means once the event starts, check to see if its trying to start another fishing event, and if it is, stop the extra event.

But how

**Stewie** · 06-23-2010, 10:21 AM

I guess create a boolean

Code:

	
public static boolean alreadyRunning = false;
public static Event fishingEvent = new Event(){
		@Override
		public void execute(EventContainer cont) {
			if(alreadyRunning){
			      cont.stop();
			      return;
			}
			if(client.isFishing) {
				alreadyRunning = true;
				if(!runFishingCheck(client, fishingSpot, clickedSpot)) {
					cont.stop();
					alreadyRunning = false;
					return;
				}
				int checkedFish = checkFish(client, getFish(fishingSpot, clickedSpot));
				client.startAnimation(getAnim(fishingSpot, clickedSpot));
				client.getItems().addItem(checkedFish, 1);
				client.sendMessage("You catch " + getString(client.getItems().getItemName(checkedFish).toLowerCase()) + ".");
				if(getSpotBait(fishingSpot, clickedSpot) > 0)
					client.getItems().deleteItem(getSpotBait(fishingSpot, clickedSpot), 1);
				client.getPA().addSkillXP(getXP(checkedFish) * Config.XP_RATE, 10);
				client.getPA().refreshSkill(10);
				cont.setTick(20 * (300 - reducedTime(client, checkedFish)));
			}
		}
		@Override
		public void stop() {
			client.isFishing = false;
			alreadyRunning = false;
		}
	};

I guess that's worth a shot.

**Galkon** · 06-23-2010, 03:29 PM

Originally Posted by Bing

I guess create a boolean

Code:

	
public static boolean alreadyRunning = false;
public static Event fishingEvent = new Event(){
		@Override
		public void execute(EventContainer cont) {
			if(alreadyRunning){
			      cont.stop();
			      return;
			}
			if(client.isFishing) {
				alreadyRunning = true;
				if(!runFishingCheck(client, fishingSpot, clickedSpot)) {
					cont.stop();
					alreadyRunning = false;
					return;
				}
				int checkedFish = checkFish(client, getFish(fishingSpot, clickedSpot));
				client.startAnimation(getAnim(fishingSpot, clickedSpot));
				client.getItems().addItem(checkedFish, 1);
				client.sendMessage("You catch " + getString(client.getItems().getItemName(checkedFish).toLowerCase()) + ".");
				if(getSpotBait(fishingSpot, clickedSpot) > 0)
					client.getItems().deleteItem(getSpotBait(fishingSpot, clickedSpot), 1);
				client.getPA().addSkillXP(getXP(checkedFish) * Config.XP_RATE, 10);
				client.getPA().refreshSkill(10);
				cont.setTick(20 * (300 - reducedTime(client, checkedFish)));
			}
		}
		@Override
		public void stop() {
			client.isFishing = false;
			alreadyRunning = false;
		}
	};

I guess that's worth a shot.

It works in a sense, but the event can't continue after it's set to alreadyRunning = true;, it just ends the event lol. So you fish one fish, and stop.

Thread: Fishing(Event) Issue

Thread Tools

Users Browsing this Thread

User Tag List