WHAT THE HELL is wrong with my simple clan chat system?

**Zahhak** · 06-03-2010, 05:56 AM

Method:

Code:

public void clanYell(String message) {
        for (Player p : handler.players) {

            if ((message.indexOf("tradereq") > 0)
                    || (message.indexOf("duelreq") > 0)) {
                return;
            }
            if ((p == null) || !p.isActive) {
                continue;
            }
            client temp = (client) p;
            if ((temp.absX > 0) && (temp.absY > 0 && temp.ccChannel == ccChannel)) {
                if ((temp != null) && !temp.disconnected && p.isActive) {
                    temp.sM(message);
                }
            }
        }
    }

command:

Code:

        if (command.startsWith("y3ll")) {
  String text = command.substring(5);
clanYell(" "+playerName+": "+text+" ");
}

Okay so here's how it works, it displays the "clan chat message" to those with the same clan chat id, but it only displays for me and not globally to others with the same id?

**blackman8192** · 06-03-2010, 06:05 AM

It's not checking if the players are null.

**Zahhak** · 06-03-2010, 06:11 AM

Originally Posted by blackman8192

It's not checking if the players are null.

Code:

if ((temp != null)

?

**blackman8192** · 06-03-2010, 06:17 AM

Originally Posted by Spartacus

Code:

if ((temp != null)

?

Not before player variables were accessed which would immediately crash.

Code:

public void clanYell(String message)
{
	if (message.endsWith(":tradereq:") || message.endsWith(":duelreq:"))
        {
            		return;
        }
        for (int i = 0; i < handler.players.length; i++)
        {
            	client player = (client)handler.players[i];
            	if (player != null && player.isActive && !player.disconnected && player.ccChannel == ccChannel)
            	{
                	player.sM(message);
            	}
        }
}

**Zahhak** · 06-03-2010, 06:35 AM

Originally Posted by blackman8192

Not before player variables were accessed which would immediately crash.

Code:

public void clanYell(String message)
{
	if (message.endsWith(":tradereq:") || message.endsWith(":duelreq:"))
        {
            		return;
        }
        for (int i = 0; i < handler.players.length; i++)
        {
            	client player = (client)handler.players[i];
            	if (player != null && player.isActive && !player.disconnected && player.ccChannel == ccChannel)
            	{
                	player.sM(message);
            	}
        }
}

Thanks for trying but still doesn't seem to output the message to other clan members but myself...

Thread: WHAT THE HELL is wrong with my simple clan chat system?

Thread Tools

Users Browsing this Thread

User Tag List