Thread: Teleport Interface Released.

Page 2 of 3 FirstFirst 123 LastLast
Results 11 to 20 of 30
  1. #11  
    Registered Member

    Join Date
    Oct 2017
    Age
    23
    Posts
    215
    Thanks given
    211
    Thanks received
    113
    Rep Power
    300
    Quote Originally Posted by _Patrick_ View Post
    Also why are you adding numbers in your naming?
    TelportData1 and TeleportType1, can just be TeleportData and TeleportType same for the other classes.

    There is room for improvement, for instance in ur enum:

    Code:
    private int x;
    
    	private int y;
    
    	private int z;
    Can just use the Location/Position class instead.

    Why is everything in brackets?

    Code:
    this.buttonId = (buttonId);
    		this.clickingid = (clickingid);
    		this.name = (name);
    		this.fullname = (fullname);
    		this.health = (health);
    		this.teamsize = (teamsize);
    		this.attackstyles = (attackstyles);
    		this.difficulty = (difficulty);
    		this.type = (type);
    		this.x = (x);
    		this.y = (y);
    		this.z = (z);
    		this.cblvl = (cblvl);
    		this.wildy = (wildy);
    		this.npcId = (npcId);
    		this.item = (item);
    Player variables have odd naming aswell "setTeleportType1".

    Other then that looks okay, alot of the naming doesn't make sense .


    Initially i was using the Position class, but the base i was using was retarded and had its teleport method use specific x, y , z for its parameters.
    unsure as to why it was like that, but i was hired to add the interface and did that but seller was taking to long to respond.


    and the reason behind brackets on them so there is so its more accurate I guess, was suggested to do it like that.


    However the enum can defo be cleaned up in general, there's alot of stuff i don't use in that enum
    appreciate it the advice
    Spoiler for signature too large:
    end me
    Attached image
    Attached image
    Reply With Quote  
     

  2. #12  
    Banned

    Join Date
    Oct 2012
    Posts
    4,710
    Thanks given
    1,679
    Thanks received
    1,105
    Rep Power
    0
    Quote Originally Posted by Bitshifting View Post
    Initially i was using the Position class, but the base i was using was retarded and had its teleport method use specific x, y , z for its parameters.
    unsure as to why it was like that, but i was hired to add the interface and did that but seller was taking to long to respond.


    and the reason behind brackets on them so there is so its more accurate I guess, was suggested to do it like that.

    "and the reason behind brackets on them so there is so its more accurate I guess" makes no sense, i suggest you don't do that anymore.

    Code:
    Parentheses are used for two purposes: (1) to control the order of operations in an expression, and (2) to supply parameters to a constructor or method.
    In no means am i trying to put you down or anything just giving you feedback on what you should change.
    Even if it was just for the release, otherwise shit code will always rule this forum.

    Thanks for the release btw, might use the interface if i ever start another project.
    Reply With Quote  
     

  3. Thankful user:


  4. #13  
    The Jedi Council


    Join Date
    Dec 2014
    Posts
    543
    Thanks given
    188
    Thanks received
    134
    Rep Power
    195
    thanks for release
    [IMG][/IMG]



    "Not everyhing that counts can be counted
    and not everything that's counted truly counts."
    Reply With Quote  
     

  5. #14  


    Omar's Avatar
    Join Date
    Dec 2007
    Posts
    279
    Thanks given
    640
    Thanks received
    783
    Rep Power
    5000
    Quote Originally Posted by Bitshifting View Post
    Code:
    	private static void NiggerInterface(TextDrawingArea[] tda) {
                ...
            }
    dog, how old are you
    Attached image
    Reply With Quote  
     

  6. Thankful user:


  7. #15  
    Registered Member

    Join Date
    Oct 2017
    Age
    23
    Posts
    215
    Thanks given
    211
    Thanks received
    113
    Rep Power
    300
    Quote Originally Posted by arseny View Post
    dog, how old are you
    honestly i was supposed to change the naming but forgot before releasing its been changed now.
    Apologies if it offended you

    Quote Originally Posted by _Patrick_ View Post
    "and the reason behind brackets on them so there is so its more accurate I guess" makes no sense, i suggest you don't do that anymore.

    Code:
    Parentheses are used for two purposes: (1) to control the order of operations in an expression, and (2) to supply parameters to a constructor or method.
    In no means am i trying to put you down or anything just giving you feedback on what you should change.
    Even if it was just for the release, otherwise shit code will always rule this forum.

    Thanks for the release btw, might use the interface if i ever start another project.
    gotcya, yeah an old buddy was like wrap them around brackets, but ye thanks appreciate it, currently cleaning it up and adding your suggestions to improve it.
    Spoiler for signature too large:
    end me
    Attached image
    Attached image
    Reply With Quote  
     

  8. #16  
    Banned

    Join Date
    Oct 2013
    Posts
    570
    Thanks given
    3
    Thanks received
    60
    Rep Power
    0
    thanks for this.
    Reply With Quote  
     

  9. #17  
    Registered Member
    RageOZA's Avatar
    Join Date
    Apr 2017
    Posts
    188
    Thanks given
    9
    Thanks received
    64
    Rep Power
    125
    This originally was suppose to be a paid service that I was getting from him.... But after days of not answering he responds that he had released it....
    The reason he improved this interface to what it is now with different tabs etc to be used was because I requested it. He wouldn't respond to implement,
    then finally today responds and tells me that he released it to rune-server for anyone to get they're hands on.

    Not pissed that others can use it, not at all. I'm more pissed at the way that he did business. The fact he had me waiting and showing me progress for
    this interface and then when it came time to implement he turns around and throws it in Run-server.... not going to bother showing the conversation..
    Very nice.
    Enjoy if you use....
    Reply With Quote  
     

  10. #18  
    Registered Member

    Join Date
    Oct 2017
    Age
    23
    Posts
    215
    Thanks given
    211
    Thanks received
    113
    Rep Power
    300
    Quote Originally Posted by Kai_Rsps View Post
    This originally was suppose to be a paid service that I was getting from him.... But after days of not answering he responds that he had released it....
    The reason he improved this interface to what it is now with different tabs etc to be used was because I requested it. He wouldn't respond to implement,
    then finally today responds and tells me that he released it to rune-server for anyone to get they're hands on.

    Not pissed that others can use it, not at all. I'm more pissed at the way that he did business. The fact he had me waiting and showing me progress for
    this interface and then when it came time to implement he turns around and throws it in Run-server.... not going to bother showing the conversation..
    Very nice.
    Enjoy if you use....
    you took too long.
    within the same day i had everything ready.
    as soon as you're online as the same time as me, you specifically told me to wait a day because you're switching bases.

    Attached image

    Not that it was an issue, really isn't hard to convert it to suit a different base, just didn't feel like it was worth the effort
    instead others could utilise it.

    Note: I was waiting on the payment and it wasn't received, besides i figured i'd release this publicly because I really couldn't be asked waiting on you
    no issue's with you at all, just couldn't be asked waiting especially when i was getting only 20$
    Spoiler for signature too large:
    end me
    Attached image
    Attached image
    Reply With Quote  
     

  11. #19  
    Donator


    Join Date
    Jan 2010
    Age
    29
    Posts
    4,122
    Thanks given
    274
    Thanks received
    551
    Rep Power
    738
    Quote Originally Posted by _Patrick_ View Post
    Why does it matter anyone with a brain can use this.

    @OP why are most of ur methods starting with a capital?

    "ItemGroup"
    Ngl thats what there learning here at the school too 'Pascal casing', i told them am just gonna stick to camel casing my methods.
    Reply With Quote  
     

  12. #20  
    The Jedi Council


    Join Date
    Dec 2014
    Posts
    543
    Thanks given
    188
    Thanks received
    134
    Rep Power
    195
    Quote Originally Posted by Bitshifting View Post
    you took too long.
    within the same day i had everything ready.
    as soon as you're online as the same time as me, you specifically told me to wait a day because you're switching bases.

    Attached image

    Not that it was an issue, really isn't hard to convert it to suit a different base, just didn't feel like it was worth the effort
    instead others could utilise it.

    Note: I was waiting on the payment and it wasn't received, besides i figured i'd release this publicly because I really couldn't be asked waiting on you
    no issue's with you at all, just couldn't be asked waiting especially when i was getting only 20$
    hey man is it possible to post your addbutton and modelviewer method?
    [IMG][/IMG]



    "Not everyhing that counts can be counted
    and not everything that's counted truly counts."
    Reply With Quote  
     

Page 2 of 3 FirstFirst 123 LastLast

Thread Information
Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)


User Tag List

Similar Threads

  1. Teleport interface release
    By _Patrick_ in forum Snippets
    Replies: 57
    Last Post: 06-19-2018, 12:09 PM
  2. Teleport Interface Release
    By Owain in forum Snippets
    Replies: 14
    Last Post: 01-06-2018, 02:05 PM
  3. My teleport interface release [PI]
    By TheTameer400 in forum Graphics
    Replies: 14
    Last Post: 06-09-2017, 01:57 PM
  4. Final version of teleport gfx - released
    By Outcast in forum Models
    Replies: 13
    Last Post: 09-17-2008, 12:45 AM
  5. Item on interface release
    By peterbjornx in forum RS 503+ Client & Server
    Replies: 12
    Last Post: 09-12-2008, 11:48 PM
Posting Permissions
  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •