Thread: [Elvarg] Deadman Mode Raiding

Page 2 of 4 FirstFirst 1234 LastLast
Results 11 to 20 of 34
  1. #11  
    Respected Member


    Kris's Avatar
    Join Date
    Jun 2016
    Age
    26
    Posts
    3,638
    Thanks given
    820
    Thanks received
    2,642
    Rep Power
    5000
    Quote Originally Posted by trees View Post
    Problem is with the way your have done it, your gunna run into errors checking a key id that is null, I have it broken down in order to prevent exactly that. If you hit an null key, it won’t continue and try and check the other options. Opposed to the way you are trying to demonstrate, so no I wouldn’t suggest that.
    No you're not. The code is in a logical order. The very first check is 'player.getBankKey()[i] == null', if this is true, it will continue the loop to the next entry. It will not check for the other conditions in it. The same applies for every single one, going in a logical order one by one.
    Attached image
    Reply With Quote  
     

  2. Thankful users:


  3. #12  
    Banned

    Join Date
    Apr 2013
    Posts
    1,614
    Thanks given
    410
    Thanks received
    475
    Rep Power
    0
    Quote Originally Posted by Kris View Post
    No you're not. The code is in a logical order. The very first check is 'player.getBankKey()[i] == null', if this is true, it will continue the loop to the next entry. It will not check for the other conditions in it. The same applies for every single one, going in a logical order one by one.
    Regardless your just making code habit opinions that have no real affect on what the code does so by all means, I just don’t suggest it becuase I still think your going to run into null issues.
    Reply With Quote  
     

  4. #13  
    §ecurity Ⱥnalyst
    Noele's Avatar
    Join Date
    Dec 2016
    Posts
    527
    Thanks given
    291
    Thanks received
    572
    Rep Power
    2203
    Quote Originally Posted by trees View Post
    Regardless your just making code habit opinions that have no real affect on what the code does so by all means, I just don’t suggest it becuase I still think your going to run into null issues.
    I can assure you that you will not run into a null pointer.
    Attached image
    Join the Zenyte discord below to keep up with the development, and grow with our community! 2000+ members and 7000+ registered in one week!
    Attached image
    Reply With Quote  
     

  5. Thankful users:


  6. #14  
    Banned

    Join Date
    Apr 2013
    Posts
    1,614
    Thanks given
    410
    Thanks received
    475
    Rep Power
    0
    Your more than welcome to update what I released, I spent a long time making this from scratch I’m not looking to work on it longer obviously. lol
    Reply With Quote  
     

  7. #15  
    Extreme Donator


    Join Date
    Oct 2010
    Posts
    2,853
    Thanks given
    1,213
    Thanks received
    1,622
    Rep Power
    5000
    Quote Originally Posted by Mardi Grass View Post
    Just for personal curiosity, is the only difference of having if statements opposed to || to make it cleaner, it does it effect the performance?
    Nested if-statements are often ugly and hard to read
    Reply With Quote  
     

  8. Thankful users:


  9. #16  
    Registered Member

    Join Date
    May 2012
    Posts
    326
    Thanks given
    44
    Thanks received
    43
    Rep Power
    96
    Quote Originally Posted by trees View Post
    Regardless your just making code habit opinions that have no real affect on what the code does so by all means, I just don’t suggest it becuase I still think your going to run into null issues.
    Its called being conventional.
    CS Major
    Inspired and reared originally in the RSPS scene.
    Reply With Quote  
     

  10. #17  
    Banned

    Join Date
    Apr 2013
    Posts
    1,614
    Thanks given
    410
    Thanks received
    475
    Rep Power
    0
    Quote Originally Posted by Professor Oak View Post
    Nested if-statements are often ugly and hard to read
    Quote Originally Posted by Dev David View Post
    Its called being conventional.
    Things can be improved, I’m aware thanks for the opinions. Maybe who ever puts it to use will care to do so.
    Reply With Quote  
     

  11. #18  
    Rune-Server Affiliate

    Join Date
    Aug 2015
    Posts
    431
    Thanks given
    55
    Thanks received
    114
    Rep Power
    126
    Nice trees
    Reply With Quote  
     

  12. #19  
    Banned

    Join Date
    Apr 2013
    Posts
    1,614
    Thanks given
    410
    Thanks received
    475
    Rep Power
    0
    Quote Originally Posted by Dex View Post
    Nice trees
    thxx
    Reply With Quote  
     

  13. #20  
    Donator

    RSPSSam's Avatar
    Join Date
    Aug 2015
    Posts
    484
    Thanks given
    158
    Thanks received
    99
    Rep Power
    87
    Looks good, I'm hoping we'll see a successful deadman mode server in the coming months.

    Each one that's been released thus far has done one or two things right, but failed due to doing everything else sub-par.
    Quote Originally Posted by Songoty View Post
    in the beginning there was npcdrops.cfg. and xero said let there be drops, and he wrote in some drops.
    Selling YouTube advertisements! 2k+ subs and 600k+ RSPS views
    Reply With Quote  
     

Page 2 of 4 FirstFirst 1234 LastLast

Thread Information
Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)


User Tag List

Similar Threads

  1. Replies: 4
    Last Post: 06-29-2017, 03:05 PM
  2. Replies: 100
    Last Post: 07-10-2016, 12:51 PM
  3. Replies: 61
    Last Post: 05-29-2016, 09:17 PM
  4. [PI] Deadman mode Bank Key/Bank Raid System
    By 2nubs1cup in forum Buying
    Replies: 5
    Last Post: 02-07-2016, 01:54 AM
  5. Deadman mode bank raid interface
    By Pandemia in forum Graphics
    Replies: 7
    Last Post: 02-02-2016, 12:33 PM
Posting Permissions
  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •