Thread: Map icon fix [OSRS Rev #143+]

Page 3 of 6 FirstFirst 12345 ... LastLast
Results 21 to 30 of 54
  1. #21  
    Rune-Server Affiliate

    Join Date
    Apr 2014
    Posts
    1,761
    Thanks given
    75
    Thanks received
    714
    Rep Power
    1073
    Quote Originally Posted by i dds you View Post
    nice share, thanks man.

    Still slightly scarmbled for me @ varrock mid, even with the snippet you mentioned on page 2 it's a good enough start though
    Can you show me where abouts?
    Reply With Quote  
     

  2. #22  
    Donator

    i dds you's Avatar
    Join Date
    Jun 2013
    Posts
    831
    Thanks given
    678
    Thanks received
    160
    Rep Power
    92
    Quote Originally Posted by Zion View Post
    Can you show me where abouts?
    Attached image

    for me right now, Seems trees, fishing spots and some others are mixed.

    Taken into consideration I may have misplaced the snippet, so within method24:

    Code:
    		aRSImageProducer_1165.initDrawingArea();
    		anInt1071 = 0;
    		for (int k2 = 0; k2 < 104; k2++) {
    			for (int l2 = 0; l2 < 104; l2++) {
    				int i3 = worldController.method303(plane, k2, l2);
    				if (i3 != 0) {
    					i3 = i3 >> 14 & 0x7fff;
    					int j3 = ObjectDef.forID(i3).anInt746;
    					if (j3 >= 0) {
    						if (i >= 15 && i <= 67) {	
    							i -= 2;
    						} else if (i >= 68 && i <= 84) {
    							i -= 1;
    						}							
    						int k3 = k2;
    						int l3 = l2;
    						aClass30_Sub2_Sub1_Sub1Array1140[anInt1071] = mapFunctions[j3];
    						anIntArray1072[anInt1071] = k3;
    						anIntArray1073[anInt1071] = l3;
    						anInt1071++;
    					}

    Reply With Quote  
     

  3. #23  
    Typical Swede


    Join Date
    Jul 2008
    Posts
    1,162
    Thanks given
    204
    Thanks received
    154
    Rep Power
    217
    Quote Originally Posted by i dds you View Post
    Attached image

    for me right now, Seems trees, fishing spots and some others are mixed.

    Taken into consideration I may have misplaced the snippet, so within method24:

    Code:
            aRSImageProducer_1165.initDrawingArea();
            anInt1071 = 0;
            for (int k2 = 0; k2 < 104; k2++) {
                for (int l2 = 0; l2 < 104; l2++) {
                    int i3 = worldController.method303(plane, k2, l2);
                    if (i3 != 0) {
                        i3 = i3 >> 14 & 0x7fff;
                        int j3 = ObjectDef.forID(i3).anInt746;
                        if (j3 >= 0) {
                            if (i >= 15 && i <= 67) {    
                                i -= 2;
                            } else if (i >= 68 && i <= 84) {
                                i -= 1;
                            }                            
                            int k3 = k2;
                            int l3 = l2;
                            aClass30_Sub2_Sub1_Sub1Array1140[anInt1071] = mapFunctions[j3];
                            anIntArray1072[anInt1071] = k3;
                            anIntArray1073[anInt1071] = l3;
                            anInt1071++;
                        }
    Here you go:
    Code:
            aRSImageProducer_1165.initDrawingArea();
            anInt1071 = 0;
            for (int k2 = 0; k2 < 104; k2++) {
                for (int l2 = 0; l2 < 104; l2++) {
                    int i3 = worldController.method303(plane, k2, l2);
                    if (i3 != 0) {
                        i3 = i3 >> 14 & 0x7fff;
                        int j3 = ObjectDef.forID(i3).anInt746;
                        if (j3 >= 0) {
                            if (j3 >= 15 && j3 <= 67) {    
                                j3 -= 2;
                            } else if (j3 >= 68 && j3 <= 84) {
                                j3 -= 1;
                            }                            
                            int k3 = k2;
                            int l3 = l2;
                            aClass30_Sub2_Sub1_Sub1Array1140[anInt1071] = mapFunctions[j3];
                            anIntArray1072[anInt1071] = k3;
                            anIntArray1073[anInt1071] = l3;
                            anInt1071++;
                        }

    'Strange things did happen here no stranger would it be'
    ______________________________________________
    Reply With Quote  
     

  4. Thankful user:


  5. #24  
    Rune-Server Affiliate

    Join Date
    Apr 2014
    Posts
    1,761
    Thanks given
    75
    Thanks received
    714
    Rep Power
    1073
    Quote Originally Posted by i dds you View Post
    Attached image

    for me right now, Seems trees, fishing spots and some others are mixed.

    Taken into consideration I may have misplaced the snippet, so within method24:

    Code:
    		aRSImageProducer_1165.initDrawingArea();
    		anInt1071 = 0;
    		for (int k2 = 0; k2 < 104; k2++) {
    			for (int l2 = 0; l2 < 104; l2++) {
    				int i3 = worldController.method303(plane, k2, l2);
    				if (i3 != 0) {
    					i3 = i3 >> 14 & 0x7fff;
    					int j3 = ObjectDef.forID(i3).anInt746;
    					if (j3 >= 0) {
    						if (i >= 15 && i <= 67) {	
    							i -= 2;
    						} else if (i >= 68 && i <= 84) {
    							i -= 1;
    						}							
    						int k3 = k2;
    						int l3 = l2;
    						aClass30_Sub2_Sub1_Sub1Array1140[anInt1071] = mapFunctions[j3];
    						anIntArray1072[anInt1071] = k3;
    						anIntArray1073[anInt1071] = l3;
    						anInt1071++;
    					}
    you just didn't name it properly.. id = j3
    Reply With Quote  
     

  6. Thankful user:


  7. #25  
    Donator

    i dds you's Avatar
    Join Date
    Jun 2013
    Posts
    831
    Thanks given
    678
    Thanks received
    160
    Rep Power
    92
    facepalming right now, must be asleep hahaha cheers boys

    Reply With Quote  
     

  8. #26  
    Rune-Server Affiliate

    Join Date
    Apr 2014
    Posts
    1,761
    Thanks given
    75
    Thanks received
    714
    Rep Power
    1073
    no problem
    Reply With Quote  
     

  9. #27  
    Owner of Ghreborn new and old.


    Join Date
    Nov 2009
    Posts
    916
    Thanks given
    47
    Thanks received
    155
    Rep Power
    273
    Attached image < are messed up
    Im back and working on reborn,
    Reply With Quote  
     

  10. #28  
    Rune-Server Affiliate

    Join Date
    Apr 2014
    Posts
    1,761
    Thanks given
    75
    Thanks received
    714
    Rep Power
    1073
    Quote Originally Posted by Sgsrocks View Post
    Attached image < are messed up
    did you do my snippet for the id fixes? dont think you did lol
    Reply With Quote  
     

  11. #29  
    Owner of Ghreborn new and old.


    Join Date
    Nov 2009
    Posts
    916
    Thanks given
    47
    Thanks received
    155
    Rep Power
    273
    i did
    Code:
       private void method24(int i) {
           int ai[] = minimapImage.myPixels;
           int j = ai.length;
           for (int k = 0; k < j; k++)
               ai[k] = 0;
    
           for (int l = 1; l < 103; l++) {
               int i1 = 24628 + (103 - l) * 512 * 4;
               for (int k1 = 1; k1 < 103; k1++) {
                   if ((byteGroundArray[i][k1][l] & 0x18) == 0)
                       worldController.method309(ai, i1, i, k1, l);
                   if (i < 3 && (byteGroundArray[i + 1][k1][l] & 8) != 0)
                       worldController.method309(ai, i1, i + 1, k1, l);
                   i1 += 4;
               }
    
           }
    
           int j1 = 0xFFFFFF;
           int l1 = 0xEE0000;
           minimapImage.method343(0);
           for (int i2 = 1; i2 < 103; i2++) {
               for (int j2 = 1; j2 < 103; j2++) {
                   if ((byteGroundArray[i][j2][i2] & 0x18) == 0)
                       method50(i2, j1, j2, l1, i);
                   if (i < 3 && (byteGroundArray[i + 1][j2][i2] & 8) != 0)
                       method50(i2, j1, j2, l1, i + 1);
               }
    
           }
    
           aRSImageProducer_1165.initDrawingArea();
           anInt1071 = 0;
           for (int k2 = 0; k2 < 104; k2++) {
               for (int l2 = 0; l2 < 104; l2++) {
                   int i3 = worldController.method303(plane, k2, l2);
                   if (i3 != 0) {
                       i3 = i3 >> 14 & 0x7fff;
                       int j3 = ObjectDef.forID(i3).mapFunctionID;
                       if (j3 >= 0) {
                    	   if (j3 >= 15 && j3 <= 67) {	
                    		   j3 -= 2;
                   		} else if (j3 >= 68 && j3 <= 84) {
                   			j3 -= 1;
                   		}
                           int k3 = k2;
                           int l3 = l2;
                           aSpriteArray1140[anInt1071] = aSpriteArray1033[j3];
                           anIntArray1072[anInt1071] = k3;
                           anIntArray1073[anInt1071] = l3;
                           anInt1071++;
                       }
                   }
               }
    
           }
    
       }
    i might not have packed the right sprite its fixed everywhere else Attached image
    Im back and working on reborn,
    Reply With Quote  
     

  12. #30  
    Banned

    Join Date
    Mar 2011
    Posts
    657
    Thanks given
    105
    Thanks received
    75
    Rep Power
    0
    Quote Originally Posted by Zion View Post
    Either download & use this updated data dumper to grab your own revision of objects (rev 143+)
    https://mega.nz/#!E4MyAKZA!poUZnmp_L...91PRK-gPmEGGaw

    or download these rev 145 object configs
    https://mega.nz/#!dw9lQTbL!yA1OR9cWW...RgMy6LXlTm9-ZQ

    ObjedtDef:
    Code:
    opcode 60 to opcode 82
    After doing that your icons will appear, but they may seem scrambled. here's a fix for that:

    method24:
    Code:
    if (id >= 15 && id <= 67) {	
    							id -= 2;
    						} else if (id >= 68 && id <= 84) {
    							id -= 1;
    						}
    That should be all the ids that needed fixed. I could be wrong, if so let me know and i'll fix it here.

    Here's a before and after if you do the cheap code above.

    Before:
    Attached image

    After:
    Attached image

    Credits:
    Myself - Added support for opcode 82 in the data dumper
    Ian (from another website) - providing the open source version of the dumper, changing the ui & fixing other various bugs.

    I am confused on

    'opcode 60 to opcode 82'

    Not really sure on what I am supposed to do with this information. Excuse the ignorance.
    Reply With Quote  
     

Page 3 of 6 FirstFirst 12345 ... LastLast

Thread Information
Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)


User Tag List

Similar Threads

  1. Replies: 17
    Last Post: 06-02-2022, 04:18 PM
  2. Replies: 11
    Last Post: 06-20-2017, 02:48 PM
  3. 143 loc map icons fixed
    By DragonSmith in forum Downloads
    Replies: 3
    Last Post: 06-06-2017, 08:01 PM
  4. Replies: 5
    Last Post: 02-22-2015, 08:36 PM
  5. How to fix the Map icons for 667 maps?
    By ST1211 in forum Help
    Replies: 8
    Last Post: 07-19-2012, 08:29 PM
Posting Permissions
  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •