Thread: Universal Launcher - Simple Client Loader

Page 2 of 2 FirstFirst 12
Results 11 to 20 of 20
  1. #11  
    touched like seafood
    Tyluur's Avatar
    Join Date
    Jun 2010
    Age
    23
    Posts
    4,836
    Thanks given
    1,676
    Thanks received
    1,565
    Discord
    View profile
    Rep Power
    1388
    Quote Originally Posted by Ryley View Post
    [Only registered and activated users can see links. ]
    why are u trying to make this async at all when u immediately block and call future.get?

    this offers no security what so ever, this will download and execute anything i want it to assuming i have gained control of wherever your assets are hosted

    why are we still using URLConnection & legacy file apis?

    [Only registered and activated users can see links. ]
    this is not a one-size-fits-all solution, this only works if the user has java installed and their java environment is properly set which is not the case in an overwhelming number of players situation. you will have many more issues trying to get people to play if this is your only method available

    also.. assuming this is made for the user who doesn't really wanna edit any source code, your configuration shouldn't be in source code..
    That can all be improved on. This is a great starting point. Valuable points though.
    [Only registered and activated users can see links. ] | [Only registered and activated users can see links. ] | [Only registered and activated users can see links. ] (official dog of rune-server)
    Quote Originally Posted by blakeman8192 View Post
    Keep trying. Quitting is the only true failure.
    Reply With Quote  
     

  2. #12  
    Renown Programmer & Respected Member

    Ryley's Avatar
    Join Date
    Aug 2011
    Posts
    597
    Thanks given
    253
    Thanks received
    520
    Discord
    View profile
    Rep Power
    1332
    Quote Originally Posted by Patrity View Post
    I would hope people are using best practices when hosting any file. If a malicious person gained control of any service, it would be detrimental.
    irrelevant, pretty much all reputable sources offer checksums for files they offer to ensure the integrity of the files coming from their hosts as well as signing files to ensure they have not been tampered with. ideally imo the file you upload to your host should be signed and your launcher should verify the signature which ensures that the file was never modified by an attacker at any point in the process. this is "best practice" not "making sure" that your website can't be compromised, that's ridiculous. how can you possibly be 100% confident that there is absolutely no way into whatever system you have hosting your files? you can't. assume the worst. prepare for failure

    Quote Originally Posted by Patrity View Post
    Offer an alternative. Your comment is meaningless.
    ideally something with http2 support, either java9 httpclient, okhttp, retrofit, etc and nio for files, its much less error prone, more robust error handling to know when something with your file xfer went wrong


    Quote Originally Posted by Patrity View Post
    That's correct. A better alternative is to package Java with the launcher however, this is not the purpose of this release.
    then maybe you shouldn't call it "ANY UNIVERSAL LAUNCHER"
    Reply With Quote  
     

  3. Thankful users:


  4. #13  
    єχтяємє яαт

    Zombie's Avatar
    Join Date
    Sep 2009
    Posts
    311
    Thanks given
    101
    Thanks received
    99
    Discord
    View profile
    Rep Power
    3720
    nice release patrity, keep making leecher proof stuff :'D




    Reply With Quote  
     

  5. #14  
    touched like seafood
    Tyluur's Avatar
    Join Date
    Jun 2010
    Age
    23
    Posts
    4,836
    Thanks given
    1,676
    Thanks received
    1,565
    Discord
    View profile
    Rep Power
    1388
    Quote Originally Posted by Ryley View Post
    irrelevant, pretty much all reputable sources offer checksums for files they offer to ensure the integrity of the files coming from their hosts as well as signing files to ensure they have not been tampered with. ideally imo the file you upload to your host should be signed and your launcher should verify the signature which ensures that the file was never modified by an attacker at any point in the process. this is "best practice" not "making sure" that your website can't be compromised, that's ridiculous. how can you possibly be 100% confident that there is absolutely no way into whatever system you have hosting your files? you can't. assume the worst. prepare for failure


    ideally something with http2 support, either java9 httpclient, okhttp, retrofit, etc and nio for files, its much less error prone, more robust error handling to know when something with your file xfer went wrong



    then maybe you shouldn't call it "ANY UNIVERSAL LAUNCHER"
    ok then go make a PR? Whats all this conversation for?
    [Only registered and activated users can see links. ] | [Only registered and activated users can see links. ] | [Only registered and activated users can see links. ] (official dog of rune-server)
    Quote Originally Posted by blakeman8192 View Post
    Keep trying. Quitting is the only true failure.
    Reply With Quote  
     

  6. #15  
    WVWVWVWVWVWVWVW

    _jordan's Avatar
    Join Date
    Nov 2012
    Age
    23
    Posts
    2,865
    Thanks given
    62
    Thanks received
    1,529
    Discord
    View profile
    Rep Power
    5000
    Keep up the good work

    Spoiler for signature:
    When your vision is crystal clear, they say it's razor-sharp
    A focused mind is said to be like a knife, but the scalpel is wisdom
    All one can do is accept that life is a double-edged sword
    Stay on the edge

    -



    Reply With Quote  
     

  7. #16  
    nice


    Join Date
    Jul 2014
    Posts
    665
    Thanks given
    288
    Thanks received
    341
    Discord
    View profile
    Rep Power
    2952
    Quote Originally Posted by Tyluur View Post
    ok then go make a PR? Whats all this conversation for?
    apparently him giving constructive criticism & helping him improve the code means he has to make a PR, ight fella, wish i could neg u twice
    Reply With Quote  
     

  8. Thankful users:


  9. #17  
    touched like seafood
    Tyluur's Avatar
    Join Date
    Jun 2010
    Age
    23
    Posts
    4,836
    Thanks given
    1,676
    Thanks received
    1,565
    Discord
    View profile
    Rep Power
    1388
    Quote Originally Posted by Suic View Post
    apparently him giving constructive criticism & helping him improve the code means he has to make a PR, ight fella, wish i could neg u twice
    Thats okay. Nobody speaks up to programmer ranks and they feel like its okay to do this.
    [Only registered and activated users can see links. ] | [Only registered and activated users can see links. ] | [Only registered and activated users can see links. ] (official dog of rune-server)
    Quote Originally Posted by blakeman8192 View Post
    Keep trying. Quitting is the only true failure.
    Reply With Quote  
     

  10. #18  
    Registered Member

    Join Date
    Feb 2010
    Posts
    3,187
    Thanks given
    1,124
    Thanks received
    834
    Discord
    View profile
    Rep Power
    1514
    Quote Originally Posted by Tyluur View Post
    Thats okay. Nobody speaks up to programmer ranks and they feel like its okay to do this.
    Undoubtedly some of them have an ego larger than the Deltascape client.java but I'd pick a fight with someone who isn't actually making reasonable suggestions. Should be plenty in discord to pick on.
    Reply With Quote  
     

  11. Thankful user:


  12. #19  
    Mikan Fanboy



    Omar's Avatar
    Join Date
    Dec 2007
    Posts
    217
    Thanks given
    425
    Thanks received
    590
    Discord
    View profile
    Rep Power
    4734
    Keep it on-topic guys. Please don't derail the thread any further.
    [Only registered and activated users can see links. ]

    Spoiler for aaaa:




    [Only registered and activated users can see links. ]
    Reply With Quote  
     

  13. #20  
    Community Veteran

    George's Avatar
    Join Date
    Mar 2009
    Posts
    7,059
    Thanks given
    2,100
    Thanks received
    2,939
    Rep Power
    5000
    Very nice release pat.


    Reply With Quote  
     

  14. Thankful users:


Page 2 of 2 FirstFirst 12

Thread Information
Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)


User Tag List

Similar Threads

  1. Any Version Website (Game Launcher) + Client Loader
    By Kiissmyswagb in forum Snippets
    Replies: 9
    Last Post: 01-25-2016, 06:33 PM
  2. Replies: 2
    Last Post: 12-31-2015, 07:07 PM
  3. Replies: 15
    Last Post: 08-13-2015, 05:50 PM
  4. A good simple client base?
    By Dynamik in forum RS2 Client
    Replies: 1
    Last Post: 07-06-2008, 02:01 AM
  5. Replies: 14
    Last Post: 12-13-2007, 12:39 AM
Posting Permissions
  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •