Originally Posted by
Major
I'm quite surprised you've found some dummy parameters (maybe somewhere in Model that I missed?)
I honestly can't remember if I started with srcalldummysremoved or not, I started refactoring this client way back in 2012 (which is also why some of the names have 'FIXME' etc... parts are very old); what's your reasoning for thinking I didn't start with it?
My reasoning is actually that stopMidi(int) method that I saw was named wrong. I noticed that the parameter was always 1. I just checked the MITB dummies removed client and the method was
Code:
private void resetImageProducers2()
{
if(aRSImageProducer_1166 != null)
return;
nullLoader();
super.fullGameScreen = null;
aRSImageProducer_1107 = null;
aRSImageProducer_1108 = null;
aRSImageProducer_1109 = null;
aRSImageProducer_1110 = null;
aRSImageProducer_1111 = null;
aRSImageProducer_1112 = null;
aRSImageProducer_1113 = null;
aRSImageProducer_1114 = null;
aRSImageProducer_1115 = null;
aRSImageProducer_1166 = new RSImageProducer(479, 96, getGameComponent());
aRSImageProducer_1164 = new RSImageProducer(172, 156, getGameComponent());
DrawingArea.setAllPixelsToZero();
mapBack.method361(0, 0);
aRSImageProducer_1163 = new RSImageProducer(190, 261, getGameComponent());
aRSImageProducer_1165 = new RSImageProducer(512, 334, getGameComponent());
DrawingArea.setAllPixelsToZero();
aRSImageProducer_1123 = new RSImageProducer(496, 50, getGameComponent());
aRSImageProducer_1124 = new RSImageProducer(269, 37, getGameComponent());
aRSImageProducer_1125 = new RSImageProducer(249, 45, getGameComponent());
welcomeScreenRaised = true;
}
Rather than yours
Code:
public final void stopMidi(int i) {
if (aClass15_1166 != null) {
return;
}
method118();
super.frameGraphicsBuffer = null;
aClass15_1107 = null;
aClass15_1108 = null;
aClass15_1109 = null;
aClass15_1110 = null;
aClass15_1111 = null;
aClass15_1112 = null;
aClass15_1113 = null;
aClass15_1114 = null;
aClass15_1115 = null;
aClass15_1166 = new ProducingGraphicsBuffer(getFrame(), 479, 96);
aClass15_1164 = new ProducingGraphicsBuffer(getFrame(), 172, 156);
Raster.reset();
mapBackground.draw(0, 0);
aClass15_1163 = new ProducingGraphicsBuffer(getFrame(), 190, 261);
aClass15_1165 = new ProducingGraphicsBuffer(getFrame(), 512, 334);
Raster.reset();
aClass15_1123 = new ProducingGraphicsBuffer(getFrame(), 496, 50);
if (i != 1) {
load();
}
aClass15_1124 = new ProducingGraphicsBuffer(getFrame(), 269, 37);
aClass15_1125 = new ProducingGraphicsBuffer(getFrame(), 249, 45);
aBoolean1255 = true;
}
And yes. I am leaving proof of that method name here on this thread forever! Muahuahua