Thread: Almost fully refactored 317 client

Page 2 of 7 FirstFirst 1234 ... LastLast
Results 11 to 20 of 66
  1. #11  


    Major's Avatar
    Join Date
    Jan 2011
    Posts
    2,997
    Thanks given
    1,293
    Thanks received
    3,556
    Rep Power
    5000
    Quote Originally Posted by Advocatus View Post
    I might rename this abit more in places and throw it up on github. Would you mind linking to the repository if I did that?
    Sure, let me upload my current version of the client.
    Reply With Quote  
     

  2. #12  
    Chemist

    Advocatus's Avatar
    Join Date
    Dec 2009
    Posts
    2,622
    Thanks given
    201
    Thanks received
    813
    Rep Power
    1462
    Quote Originally Posted by Major View Post
    Sure, let me upload my current version of the client.
    By the by, I know the MITB client had some fugly naming, but it also had a very large amount of dummy parameters removed. Why didn't you start with it for this client?
    Quote Originally Posted by blakeman8192 View Post
    Quitting is the only true failure.
    Reply With Quote  
     

  3. #13  


    Major's Avatar
    Join Date
    Jan 2011
    Posts
    2,997
    Thanks given
    1,293
    Thanks received
    3,556
    Rep Power
    5000
    Quote Originally Posted by Advocatus View Post
    By the by, I know the MITB client had some fugly naming, but it also had a very large amount of dummy parameters removed. Why didn't you start with it for this client?
    I'm quite surprised you've found some dummy parameters (maybe somewhere in Model that I missed?)

    I honestly can't remember if I started with srcalldummysremoved or not, I started refactoring this client way back in 2012 (which is also why some of the names have 'FIXME' etc... parts are very old); what's your reasoning for thinking I didn't start with it?

    Updated version
    Reply With Quote  
     

  4. #14  
    Chemist

    Advocatus's Avatar
    Join Date
    Dec 2009
    Posts
    2,622
    Thanks given
    201
    Thanks received
    813
    Rep Power
    1462
    Quote Originally Posted by Major View Post
    I'm quite surprised you've found some dummy parameters (maybe somewhere in Model that I missed?)

    I honestly can't remember if I started with srcalldummysremoved or not, I started refactoring this client way back in 2012 (which is also why some of the names have 'FIXME' etc... parts are very old); what's your reasoning for thinking I didn't start with it?
    My reasoning is actually that stopMidi(int) method that I saw was named wrong. I noticed that the parameter was always 1. I just checked the MITB dummies removed client and the method was

    Code:
    	private void resetImageProducers2()
    	{
    		if(aRSImageProducer_1166 != null)
    			return;
    		nullLoader();
    		super.fullGameScreen = null;
    		aRSImageProducer_1107 = null;
    		aRSImageProducer_1108 = null;
    		aRSImageProducer_1109 = null;
    		aRSImageProducer_1110 = null;
    		aRSImageProducer_1111 = null;
    		aRSImageProducer_1112 = null;
    		aRSImageProducer_1113 = null;
    		aRSImageProducer_1114 = null;
    		aRSImageProducer_1115 = null;
    		aRSImageProducer_1166 = new RSImageProducer(479, 96, getGameComponent());
    		aRSImageProducer_1164 = new RSImageProducer(172, 156, getGameComponent());
    		DrawingArea.setAllPixelsToZero();
    		mapBack.method361(0, 0);
    		aRSImageProducer_1163 = new RSImageProducer(190, 261, getGameComponent());
    		aRSImageProducer_1165 = new RSImageProducer(512, 334, getGameComponent());
    		DrawingArea.setAllPixelsToZero();
    		aRSImageProducer_1123 = new RSImageProducer(496, 50, getGameComponent());
    		aRSImageProducer_1124 = new RSImageProducer(269, 37, getGameComponent());
    		aRSImageProducer_1125 = new RSImageProducer(249, 45, getGameComponent());
    		welcomeScreenRaised = true;
    	}
    Rather than yours
    Code:
    	public final void stopMidi(int i) {
    		if (aClass15_1166 != null) {
    			return;
    		}
    		method118();
    		super.frameGraphicsBuffer = null;
    		aClass15_1107 = null;
    		aClass15_1108 = null;
    		aClass15_1109 = null;
    		aClass15_1110 = null;
    		aClass15_1111 = null;
    		aClass15_1112 = null;
    		aClass15_1113 = null;
    		aClass15_1114 = null;
    		aClass15_1115 = null;
    		aClass15_1166 = new ProducingGraphicsBuffer(getFrame(), 479, 96);
    		aClass15_1164 = new ProducingGraphicsBuffer(getFrame(), 172, 156);
    		Raster.reset();
    		mapBackground.draw(0, 0);
    		aClass15_1163 = new ProducingGraphicsBuffer(getFrame(), 190, 261);
    		aClass15_1165 = new ProducingGraphicsBuffer(getFrame(), 512, 334);
    		Raster.reset();
    		aClass15_1123 = new ProducingGraphicsBuffer(getFrame(), 496, 50);
    		if (i != 1) {
    			load();
    		}
    		aClass15_1124 = new ProducingGraphicsBuffer(getFrame(), 269, 37);
    		aClass15_1125 = new ProducingGraphicsBuffer(getFrame(), 249, 45);
    		aBoolean1255 = true;
    	}
    And yes. I am leaving proof of that method name here on this thread forever! Muahuahua
    Quote Originally Posted by blakeman8192 View Post
    Quitting is the only true failure.
    Reply With Quote  
     

  5. #15  


    Major's Avatar
    Join Date
    Jan 2011
    Posts
    2,997
    Thanks given
    1,293
    Thanks received
    3,556
    Rep Power
    5000
    Quote Originally Posted by Advocatus View Post
    My reasoning is actually that stopMidi(int) method that I saw was named wrong. I noticed that the parameter was always 1. I just checked the MITB dummies removed client and the method was - snip -
    Yeah looks like you're right, I'm not entirely sure why I didn't start with it but I vaguely remember thinking there was a problem related to overhead icons in the MITB client (no idea if that's actually true, it was a long time ago).

    I've posted an updated link to the client.
    Reply With Quote  
     

  6. #16  
    Chemist

    Advocatus's Avatar
    Join Date
    Dec 2009
    Posts
    2,622
    Thanks given
    201
    Thanks received
    813
    Rep Power
    1462
    Quote Originally Posted by Major View Post
    Yeah looks like you're right, I'm not entirely sure why I didn't start with it but I vaguely remember thinking there was a problem related to overhead icons in the MITB client (no idea if that's actually true, it was a long time ago).
    I honestly don't remember that.

    I really don't know whether this supports the 377 cache out of the box. I'll have to check. If it doesn't Ill either set up a branch that does or just another repo for one. I really hate that people mismatch the client and caches, but that is a lesser evil than people using poor naming conventions imho.

    Quote Originally Posted by Major View Post
    I've posted an updated link to the client.
    Yeah. Just downloaded.
    Quote Originally Posted by blakeman8192 View Post
    Quitting is the only true failure.
    Reply With Quote  
     

  7. Thankful user:


  8. #17  


    Major's Avatar
    Join Date
    Jan 2011
    Posts
    2,997
    Thanks given
    1,293
    Thanks received
    3,556
    Rep Power
    5000
    Quote Originally Posted by Advocatus View Post
    I really don't know whether this supports the 377 cache out of the box. I'll have to check. If it doesn't Ill either set up a branch that does or just another repo for one. I really hate that people mismatch the client and caches, but that is a lesser evil than people using poor naming conventions imho.
    It doesn't, I've never been a fan of this practice either.
    Reply With Quote  
     

  9. #18  
    Chemist

    Advocatus's Avatar
    Join Date
    Dec 2009
    Posts
    2,622
    Thanks given
    201
    Thanks received
    813
    Rep Power
    1462
    Quote Originally Posted by Major View Post
    It doesn't, I've never been a fan of this practice either.
    Likewise, it is worth considering though.
    Repository: https://github.com/MatthewBishop/rs317
    Download: https://github.com/MatthewBishop/rs3...ive/master.zip
    Quote Originally Posted by blakeman8192 View Post
    Quitting is the only true failure.
    Reply With Quote  
     

  10. #19  


    Major's Avatar
    Join Date
    Jan 2011
    Posts
    2,997
    Thanks given
    1,293
    Thanks received
    3,556
    Rep Power
    5000
    Updated (now has packaging and lots of changes i can't remember)

    Edit: completely refactored the Widget class
    Last edited by Major; 03-30-2015 at 04:52 PM.
    Reply With Quote  
     

  11. Thankful users:


  12. #20  
    Rune Synergy


    Dane's Avatar
    Join Date
    Jan 2007
    Posts
    189
    Thanks given
    110
    Thanks received
    337
    Rep Power
    2323
    I just wanted to point out in your Rasterizer class that

    Code:
    		for (int i = 1; i < 512; i++) {
    			anIntArray1468[i] = 32768 / i;
    		}
    
    		for (int j = 1; j < 2048; j++) {
    			anIntArray1469[j] = 0x10000 / j;
    		}
    anIntArray1468 is a look-up table for 17.15 fixed-point fractions, and anIntArray1469 is for 16.16. I've had issues thinking of a fancy name for them so I'm curious to see what you come up with.

    edit: I would also like to point out this snippet in the Rasterizer

    Code:
    				ai[4096 + i1] = i2 - (i2 >>> 3) & 0xf8f8ff;
    				ai[8192 + i1] = i2 - (i2 >>> 2) & 0xf8f8ff;
    				ai[12288 + i1] = i2 - (i2 >>> 2) - (i2 >>> 3) & 0xf8f8ff;
    0xF8F8F8 is clearing the 3 least significant bits for the red and green channels so when the right bit shift is performed there is no underflow of the color channels in the following right bit shifts. That allows the channels to be divided (darkened) at the cost of color accuracy from the original image (which is barely any color lost anyway).

    The array this operation is being performed on contains 4 copies of the texture. The first being the original, and each one consecutively getting darker (from the snippet above). It's just a 128x512 image basically.
    Reply With Quote  
     

  13. Thankful user:


Page 2 of 7 FirstFirst 1234 ... LastLast

Thread Information
Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)


User Tag List

Similar Threads

  1. Galkon's Refactored 317 fully loading 667
    By Shaloxis in forum Help
    Replies: 1
    Last Post: 03-12-2014, 11:06 PM
  2. Galkon's Refactored 317 client help!
    By und3ad in forum Help
    Replies: 4
    Last Post: 12-01-2011, 09:13 AM
  3. Replies: 4
    Last Post: 08-07-2011, 10:50 AM
  4. Replies: 14
    Last Post: 05-15-2010, 08:11 PM
  5. Fully Refactored 503 Stream Class + Further Refactored Client
    By TeleNubby in forum RS 503+ Client & Server
    Replies: 36
    Last Post: 03-18-2010, 12:10 PM
Posting Permissions
  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •