Thread: 317refactor - the most usable 317 client

Page 4 of 4 FirstFirst ... 234
Results 31 to 36 of 36
  1. #31  
    Registered Member

    Join Date
    Feb 2009
    Age
    27
    Posts
    2,861
    Thanks given
    127
    Thanks received
    226
    Rep Power
    700
    Quote Originally Posted by nihil dignum View Post
    Not sure how old the thread is, but you Github repository seems to still be active. I'm downloading this so I can get familiar with the rs2 client. Thanks OP
    Thanks, I hope you like it. I am still working on it today, four years later!
    Reply With Quote  
     

  2. Thankful user:


  3. #32  
    Registered Member

    Join Date
    Feb 2009
    Age
    27
    Posts
    2,861
    Thanks given
    127
    Thanks received
    226
    Rep Power
    700
    This may be 8 years too late, but I've noticed a bug in this.

    Textures don't seem to be lit correctly, you can see the symptoms in the image below.

    I'll see if I can fix this issue and push it to the Github repo.

    Attached image

    ------------
    ------------

    edit: This is now fixed, it wasn't too hard to find.

    The bug was introduced in 2014! You can see the fix here:

    https://github.com/Jameskmonger/317r...47de064e16b1d2

    Attached image
    Reply With Quote  
     

  4. Thankful user:


  5. #33  
    Registered Member Grubby's Avatar
    Join Date
    Feb 2022
    Posts
    32
    Thanks given
    3
    Thanks received
    6
    Rep Power
    0
    This is actually very useful thanks alot for this!
    Reply With Quote  
     

  6. #34  
    Registered Member
    thing1's Avatar
    Join Date
    Aug 2008
    Posts
    2,111
    Thanks given
    131
    Thanks received
    1,099
    Rep Power
    2402
    Quote Originally Posted by jameskmonger View Post
    This may be 8 years too late, but I've noticed a bug in this.

    Textures don't seem to be lit correctly, you can see the symptoms in the image below.

    I'll see if I can fix this issue and push it to the Github repo.

    Attached image

    ------------
    ------------

    edit: This is now fixed, it wasn't too hard to find.

    The bug was introduced in 2014! You can see the fix here:

    fix: fix incorrect refactoring in `mergeNormals` Jameskmonger/317refactor@68d8f1d GitHub

    Attached image
    Although I don't personally use this, I respect you coming back and fixing it after the time has passed. Thanks for your contribution of a refactored client on this forum!
    Reply With Quote  
     

  7. Thankful user:


  8. #35  
    Registered Member
    Join Date
    Dec 2022
    Posts
    1
    Thanks given
    0
    Thanks received
    0
    Rep Power
    0
    As a beginner I really appreciate this, thank you!
    Reply With Quote  
     

  9. #36  
    Registered Member

    Join Date
    Nov 2022
    Posts
    65
    Thanks given
    106
    Thanks received
    59
    Rep Power
    1327
    Good fix. I still reference this thanks.
    Reply With Quote  
     

Page 4 of 4 FirstFirst ... 234

Thread Information
Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)


User Tag List

Similar Threads

  1. Replies: 3
    Last Post: 07-16-2011, 06:49 PM
  2. Most renamed 317 client download here
    By Clienthax in forum Downloads
    Replies: 8
    Last Post: 09-30-2010, 04:17 PM
  3. Most renamed 317 client (packaged)
    By Nuevo in forum Downloads
    Replies: 2
    Last Post: 04-25-2010, 04:11 AM
  4. The most stable Client and Server (#317)
    By Zonchord in forum Requests
    Replies: 9
    Last Post: 12-19-2009, 06:56 PM
  5. Replies: 39
    Last Post: 05-05-2008, 12:40 PM
Posting Permissions
  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •