Thread: 508 Prayer using eventmanager

Page 1 of 2 12 LastLast
Results 1 to 10 of 11
  1. #1 508 Prayer using eventmanager 
    Registered Member
    Join Date
    Dec 2013
    Posts
    6
    Thanks given
    0
    Thanks received
    0
    Rep Power
    0
    I dont know if this has been posted before but here.
    I WOULD LIKE SOME CONSTRUCTIVE CRITICISM PLEASE, I ACCEPT ALL THE HELP POSSIBLE TO IMPROVE =]

    AND YES I KNOW THIS IS EASY(FOR THE NON BEGINNERS) BUT YAH I'M A BEGINNER

    ~ lets begin

    1. create a new class called Prayer and add this to it.
    Code:
    /**
     * Class Prayer
     *
     * Version 1.0
     *
     * Wednesday, Feb 12 , 2014
     *
     * Created by josue
     **/
    
    package palidino76.rs2.players.skills;
    
    import palidino76.rs2.players.Player;
    import palidino76.rs2.players.items.PlayerItems;
    import palidino76.rs2.EventManager.*;
    import palidino76.rs2.Engine;
    
    public class Prayer {
    
    	PlayerItems pi = new PlayerItems();
    
    	public int [] bones = {526,532,534,536}; // other bones can be add here
    	public double [] exp = {4.5,15,30,72}; // exp here
    	public String [] boneNames = {"bone", "big bone", "baby dragon", "dragon"}; // bones name here
    
    	public void startBurying(final Player p, final int itemId){
    	EventManager.getSingleton().addEvent(250,new Event() {
                public void execute(EventContainer c) {
    			for (int i = 0 ; i < bones.length; i++){
    			if (itemId == bones[i]){
    				Engine.playerItems.deleteItem(p, bones[i], pi.getItemSlot(p, bones[i]), 1);
    				p.requestAnim(827, 0);
    				p.addSkillXP(exp[i]*5, 5);// im doing my server base off rs but w/e rs give its x5 on my server
    				p.frames.sendMessage(p, "you dig a hole and bury the "+boneNames[i]+ " into the ground");
    					}
    					}
    					c.stop();
    				}
    			});
    		}
    	
    	
    	
    	
    }
    2. next in itemSelect add this
    Code:
    	Prayer prayerObject = new Prayer();
    3. Now in itemSelect under the switch add this.
    Code:
                     
                                    case 526:
    				case 532:
    				case 534:
    				case 536:
    				prayerObject.startBurying(p,itemId);
    				break;
    4. dont forget to import where ever u add the Prayer class
    Hello
    Reply With Quote  
     

  2. #2  
    Registered Member huch's Avatar
    Join Date
    Jul 2013
    Age
    29
    Posts
    128
    Thanks given
    4
    Thanks received
    6
    Rep Power
    20
    1. For Prayer data better use Enum.
    It would be more viewable and easier to use.

    Code:
    BONES(526, 5, "Bones"),
            BURNT_BONES(528, 5, "Burnt Bones"),
            MONKEY_BONES(3179, 5, "Monkey Bones"),
            BIG_BONES(532, 15, "Big Bones"),
    2. Don't use cases for 3rd part. It messes up the code. Better use boolean that check's if the item is bone and then do the code.

    Anyway, gj
    Reply With Quote  
     

  3. #3  
    Banned

    Join Date
    Mar 2010
    Posts
    2,218
    Thanks given
    170
    Thanks received
    262
    Rep Power
    0
    Looks decent an enum would of been better though but good job.
    Reply With Quote  
     

  4. #4  
    Registered Member
    Join Date
    Dec 2013
    Posts
    6
    Thanks given
    0
    Thanks received
    0
    Rep Power
    0
    thanks guys will do.
    Hello
    Reply With Quote  
     

  5. #5  
    Soon to be a Blaziken

    Torchic's Avatar
    Join Date
    Mar 2011
    Age
    29
    Posts
    1,711
    Thanks given
    14
    Thanks received
    452
    Rep Power
    529
    interesting to still see 508's being developed.

    OT: good job, like said, an enum would be better

    Quote Originally Posted by huchevsky View Post
    2. Don't use cases for 3rd part. It messes up the code. Better use boolean that check's if the item is bone and then do the code.
    LOL.

    Reply With Quote  
     

  6. #6  
    Registered Member huch's Avatar
    Join Date
    Jul 2013
    Age
    29
    Posts
    128
    Thanks given
    4
    Thanks received
    6
    Rep Power
    20
    Quote Originally Posted by Torchic View Post
    interesting to still see 508's being developed.

    OT: good job, like said, an enum would be better



    LOL.
    What's wrong what i said?
    Reply With Quote  
     

  7. #7  
    Registered Member
    Join Date
    Jun 2012
    Posts
    467
    Thanks given
    216
    Thanks received
    79
    Rep Power
    0
    You can just add prayerObject.startBurying(p,itemId); above the switch statement because you already have an array of bones in your method which is being checked.

    Good attempt anyway
    Reply With Quote  
     

  8. #8  
    Registered Member
    danimals br0's Avatar
    Join Date
    Aug 2010
    Posts
    885
    Thanks given
    64
    Thanks received
    94
    Rep Power
    109
    Quote Originally Posted by huchevsky View Post
    1. For Prayer data better use Enum.
    It would be more viewable and easier to use.

    Code:
    BONES(526, 5, "Bones"),
            BURNT_BONES(528, 5, "Burnt Bones"),
            MONKEY_BONES(3179, 5, "Monkey Bones"),
            BIG_BONES(532, 15, "Big Bones"),
    2. Don't use cases for 3rd part. It messes up the code. Better use boolean that check's if the item is bone and then do the code.

    Anyway, gj
    "Burnt Bones" no need for it (name in the enum) just override toString method and do getName().replaceAll("_", " ").toLowerCase(); did this here so yeah, i bet you know what i did.
    Reply With Quote  
     

  9. #9  
    Registered Member Tricky's Avatar
    Join Date
    Feb 2014
    Posts
    87
    Thanks given
    15
    Thanks received
    15
    Rep Power
    12
    Sweet
    Reply With Quote  
     

  10. #10  
    Super Donator


    Join Date
    Mar 2009
    Age
    28
    Posts
    1,388
    Thanks given
    316
    Thanks received
    408
    Rep Power
    608
    this isnt 2008 anymore buddy
    Reply With Quote  
     

Page 1 of 2 12 LastLast

Thread Information
Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)


User Tag List

Similar Threads

  1. [508+] Adding Agility using EventManager
    By Dark Regen in forum Tutorials
    Replies: 34
    Last Post: 01-02-2011, 02:45 AM
  2. [508] Teletabs using EventManager
    By Corby in forum Tutorials
    Replies: 19
    Last Post: 08-14-2010, 12:47 PM
  3. [508] Prayer training[508]
    By ghostrevan in forum Help
    Replies: 5
    Last Post: 03-28-2009, 03:51 PM
  4. [508]Some useful buttons!:d
    By GaMePaPa in forum Configuration
    Replies: 12
    Last Post: 01-27-2009, 02:00 AM
  5. [508] Prayer Implementing
    By XRay in forum Requests
    Replies: 0
    Last Post: 10-27-2008, 01:19 AM
Posting Permissions
  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •