Thread: Dialogue System(Easy usage)

lol a new instance per dialog..

Originally Posted by nemesis

Make a new class to model folder called DialogueQueue

Code:

package com.rs2hd.model;

import com.rs2hd.definitionhandling.DefinitionHandler;

public class DialogueQueue {
	/**
	*	Whos dialogues are we dealing with?
	*/
	private Player player;
	/**
	*	The id of dialogue that's currently being displayed
	*/
	private int currentId;
	/**
	*	Array where all dialogues are stored.
	*/
	private Dialogue[] dialogueArray = new Dialogue[100];

	public DialogueQueue(Player player) {
		this.player = player;
	}
	
	public void add(Dialogue d) {
		dialogueArray[getId()] = d;
		display(d);
	}
	
	public void add(Dialogue[] d) {
		dialogueArray = d;
		currentId = 0;
		display(dialogueArray[currentId]);
	}
	
	public Dialogue getNext() {
		currentId += 1;
		if(currentId >= dialogueArray.length) {
			currentId = -1;
			clear();
			return null;
		}
		display(dialogueArray[currentId]);
		return dialogueArray[currentId];
	}
	
	public int getId() {
		for(int i = 0; i < dialogueArray.length;i++) {
			if(dialogueArray[i] == null) {
				return i;
			}
		}
		return -1;
	}
	public void display(Dialogue d) {
		if(d.getNpcId() > -1) {
			String npcName = DefinitionHandler.getNPCDef(d.getNpcId()).getName() == null ? "Unknown" : DefinitionHandler.getNPCDef(d.getNpcId()).getName();
			player.getActionSender().sendNpcHead(d.getNpcId(), 241, 2);
			player.getActionSender().sendString(npcName, 241, 3);
		} else {
			player.getActionSender().sendString(player.getUsername(), 241, 3);
			player.getActionSender().sendPlayerHead(241, 2);
		}
		player.getActionSender().sendChatboxInterface(241);
		player.getActionSender().animateInterface(9847, 241, 2);
		player.getActionSender().sendString(d.getText(), 241, 4);
	}
	public void clear() {
		dialogueArray = null;
	}
}

And a class called Dialogue

Code:

package com.rs2hd.model;

public class Dialogue {

	private Player owner;
	private String text;
	private int npcId;
	
	public Dialogue(Player p, String str, int npcId) {
		this.owner = p;
		this.text = str;
		this.npcId = npcId;
	}
	
	public String getText() {
		return text;
	}
	
	public int getNpcId() {
		return npcId;
	}
	
	public Player getOwner() {
		return owner;
	}
}

Add this to player class:

Code:

	/**
	*	Dialogues
	*/
	private transient DialogueQueue dialogueQueue;
	/**
	 * Handles player dialogues.
	 */
	public DialogueQueue getDialogueQueue() {
		return dialogueQueue;
	}

Declare this where you set constructors:

Code:

dialogueQueue = new DialogueQueue(this);

Add this to where you handle buttons for interfaces/chatboxinterfaces

Code:

			case 241:
				if(button == 5) {
					player.getActionSender().sendCloseChatboxInterface();
					player.getDialogueQueue().getNext();
				}
				break;

Have fun.

Usage:

Code:

		player.getDialogueQueue().add(new Dialogue[]{
		new Dialogue(player, "Hello!",  -1),
		new Dialogue(player, "Hi!", affectedNpc.getId()),
		new Dialogue(player, "How's it going?", -1),
		new Dialogue(player, "I'm fine thank you.",	affectedNpc.getId())});

or single dialogue:

Code:

		player.getDialogueQueue().add(new Dialogue(player, "Hello!",  -1));

I'm confused....a dialogue...queue? Wtf? Can't you just write the text instead of putting it in a queue? Not to mention you are making a new Dialogue Object ARRAY each time someone clicks on an NPC that supports dialogue, which is asking for a crash.

And why did you make some variables transient? Lolol I don't see any serialization going on

Originally Posted by 'Conner

I'm confused....a dialogue...queue? Wtf? Can't you just write the text instead of putting it in a queue? Not to mention you are making a new Dialogue Object ARRAY each time someone clicks on an NPC that supports dialogue, which is asking for a crash.

And why did you make some variables transient? Lolol I don't see any serialization going on

you fucking moron you heard somehting someone else says and you got to repeat it?
you think your a hotshot cause you think you can be a pro programmer in 3 months? and why is it asking for a crash!? i doenst so know what you talk about before making this nonesence aquisation. and a queue is much better then your "putting text on". want me to keep on raggin on you? then continu your course of action, cause every post you make has something about it that aint right of somesort.

Originally Posted by nemesis

This can be easily converted ,plus I highly recommend to switch from the if statement shit to this, since when you start making quests, this will come in handy.

I dont use if statements.

I use prestored integer arrays in the player class, and use a method to just append dialog onto the player, instead of:

Code:

if (questId == 1) {
    if (dStage == 0) {
        if (hasItem(995, 1000)) {
            npcOneLine(p, "You have at least 1k.")
        } else {
            npcTwoLine(p, "You have less than 1k?", "You are poor!");
        }
    }
}

Mine is like this:

Code:

        Engine.dialog.appendNDialog1(p, 0, 9850, "Weclome to RuneScape!", n);
        Engine.dialog.appendPDialog1(p, 1, 9832, "Ok, have a good day.");
        Engine.dialog.appendNDialog1(p, 2, 9850, "Goodbye!", n);

Originally Posted by pivotgamer84

I dont use if statements.

I use prestored integer arrays in the player class, and use a method to just append dialog onto the player, instead of:

Code:

if (questId == 1) {
    if (dStage == 0) {
        if (hasItem(995, 1000)) {
            npcOneLine(p, "You have at least 1k.")
        } else {
            npcTwoLine(p, "You have less than 1k?", "You are poor!");
        }
    }
}

Mine is like this:

Code:

        Engine.dialog.appendNDialog1(p, 0, 9850, "Weclome to RuneScape!", n);
        Engine.dialog.appendPDialog1(p, 1, 9832, "Ok, have a good day.");
        Engine.dialog.appendNDialog1(p, 2, 9850, "Goodbye!", n);

then a queue/ dequeu list is better.

Originally Posted by 'Conner

I'm confused....a dialogue...queue? Wtf? Can't you just write the text instead of putting it in a queue? Not to mention you are making a new Dialogue Object ARRAY each time someone clicks on an NPC that supports dialogue, which is asking for a crash.

And why did you make some variables transient? Lolol I don't see any serialization going on

Asking for crash? What the fuck are you talking about, there's no way this could crash if it's used correctly.

Write text instead of putting it in to queue? Jesus you're a fucking dumbass.

It's transient so the RS2HD saving system don't save the dialogues into player file, like I sayed on previous posts.

You're pointing out same things as Encour' did, which makes me think...That you don't have any idea what you're talking about.

Originally Posted by Serenity

then a queue/ dequeu list is better.

I know a list is better, but I wanted to keep it simple. I dont care for speed or power, just simplicity.

Nice I'll look at this.