Thread: Matrix Decanting [667/718/*]

why did u write a book for this though

maybe i'm missing something but wouldn't a simple method replacing one vial with another do the job?

edit: synchronized blocks for decanting? is this a joke Tyluur

Cool release, I was just looking at the code and a question:

Code:

List<Item> items = null;

This gets re-initialized at every iteration in your while loop. So the previous iterations are not getting cached. You then after the while loop, foreach over that items list and check if the players inventory contains the item.

Does each

Code:

Entry<String, List<Item>> entry = it$.next();

contain the entire inventory (or at least the items we want) or is this a bug in the code?

I haven't looked at the rest of the code.

thanks will use rep++

Originally Posted by Kiissmyswagb

Cool release, I was just looking at the code and a question:

Code:

List<Item> items = null;

This gets re-initialized at every iteration in your while loop. So the previous iterations are not getting cached. You then after the while loop, foreach over that items list and check if the players inventory contains the item.

Does each

Code:

Entry<String, List<Item>> entry = it$.next();

contain the entire inventory (or at least the items we want) or is this a bug in the code?

I haven't looked at the rest of the code.

If that's the case, there's some improvements that can be made . I didn't really go over all of it indepth, just thought it would be valuable to somebody, rather than sit in my archives.

Originally Posted by Fire Cape

why did u write a book for this though

maybe i'm missing something but wouldn't a simple method replacing one vial with another do the job?

edit: synchronized blocks for decanting? is this a joke Tyluur

Well you have to take into account every vial in the runescape universe. There's emptying, putting one vial with another, checking compatibility. I manipulated strings [used item names] for these functions. You can do it in lots more ways though. The cache is a very helpful resource once decoded.

Originally Posted by Fire Cape

why did u write a book for this though

maybe i'm missing something but wouldn't a simple method replacing one vial with another do the job?

edit: synchronized blocks for decanting? is this a joke Tyluur

Well you have to take into account every vial in the runescape universe. There's emptying, putting one vial with another, checking compatibility. I manipulated strings [used item names] for these functions. You can do it in lots more ways though. The cache is a very helpful resource once decoded.

Do you even know how to use synchronized locks properly?

You are creating a new lock object every time u call the method, which means the lock is redundant. Also multiple threads dont hit ur synchronized blocks which makes it 2x redundant.
Shit code srry

Code:

		Object lock = new Object();
		for (Item item : player.getInventory().getItems().toArray()) {
			if (item == null || item.getDefinitions().isNoted() || !isPotion(item.getName())) {
				continue;
			}
			synchronized (lock) {
				String name = item.getName();
				String base = Decanting.getBaseName(name);
				int doses = getPotionDoses(name.split(" "));
				if (map.containsKey(base)) {
					int amt = map.get(base);
					map.remove(base);
					map.put(base, amt + doses);
				} else {
					map.put(base, doses);
				}
			}
		}

This should be a bannable offence in rune-server.

Originally Posted by Kris

Code:

		Object lock = new Object();
		for (Item item : player.getInventory().getItems().toArray()) {
			if (item == null || item.getDefinitions().isNoted() || !isPotion(item.getName())) {
				continue;
			}
			synchronized (lock) {
				String name = item.getName();
				String base = Decanting.getBaseName(name);
				int doses = getPotionDoses(name.split(" "));
				if (map.containsKey(base)) {
					int amt = map.get(base);
					map.remove(base);
					map.put(base, amt + doses);
				} else {
					map.put(base, doses);
				}
			}
		}

This should be a bannable offence in rune-server.

Are you spamming or are you going to post something meaningful?

--- EDIT ---

It's been two years, Kris. Give something back.

Originally Posted by Tyluur

Are you spamming or are you going to post something meaningful?

--- EDIT ---

It's been two years, Kris. Give something back.

I mean all your giving back here is a bunch of technical debt prob worse than giving nothing back