Thread: Daily Investment System

If all the methods are static, why is this an Action?

Code:

	 public static int getDay() {
		  switch (dayOfWeek()) {
		  case 1:
			  return 1;
		  case 2:
			  return 2;
		  case 3:
			  return 3;
		  case 4:
			  return 4;
		  case 5:
			  return 5;
		  case 6:
			  return 6;
		  case 7:
			  return 7;
		  }
		return 0;
	  }

Just return dayOfWeek()

Originally Posted by Cody_

If all the methods are static, why is this an Action?

Code:

	 public static int getDay() {
		  switch (dayOfWeek()) {
		  case 1:
			  return 1;
		  case 2:
			  return 2;
		  case 3:
			  return 3;
		  case 4:
			  return 4;
		  case 5:
			  return 5;
		  case 6:
			  return 6;
		  case 7:
			  return 7;
		  }
		return 0;
	  }

Just return dayOfWeek()

This. And the Player variables being added are a bit strangely named.

i mean, i like the idea, but the execution is a bit......

nice

will use

Originally Posted by Cody_

If all the methods are static, why is this an Action?

Code:

	 public static int getDay() {
		  switch (dayOfWeek()) {
		  case 1:
			  return 1;
		  case 2:
			  return 2;
		  case 3:
			  return 3;
		  case 4:
			  return 4;
		  case 5:
			  return 5;
		  case 6:
			  return 6;
		  case 7:
			  return 7;
		  }
		return 0;
	  }

Just return dayOfWeek()

Tried this, but with the return of the dayofWeek, it wouldnt parse to an int for the system to understand. I tried a few different ways to parse it as an integer to set, but everytime it threw it as 0 as it wasnt converted to a variable for some strange reason.

Originally Posted by Makar

This. And the Player variables being added are a bit strangely named.

Player variables are done weirdly because there are already variables in my system that are in use for more common names.

Originally Posted by Luke132

i mean, i like the idea, but the execution is a bit......

do you have any suggestions? i am orginally a php developer, so i been leaning towards that structure and havent learned quite everything with java, in terms of shortening code or other helpful ways. if you have something that would help, i would appreciate help to improve!

Originally Posted by TheQuantum

Tried this, but with the return of the dayofWeek, it wouldnt parse to an int for the system to understand. I tried a few different ways to parse it as an integer to set, but everytime it threw it as 0 as it wasnt converted to a variable for some strange reason.



Player variables are done weirdly because there are already variables in my system that are in use for more common names.



do you have any suggestions? i am orginally a php developer, so i been leaning towards that structure and havent learned quite everything with java, in terms of shortening code or other helpful ways. if you have something that would help, i would appreciate help to improve!

The variable names should at least be camelCased/snake_cased. And having invest, investt, and investtt regardless of whether they are used for something else is very non-descriptive and confusing.

Originally Posted by Makar

The variable names should at least be camelCased/snake_cased. And having invest, investt, and investtt regardless of whether they are used for something else is very non-descriptive and confusing.

to be honest, the only thing not named accordingly is investtt, the rest are named accordingly to their reason. savings, lastreturn, dailyinvest and streak all labelled to what they are doing, it wouldnt take more than 5 seconds to swap that investtt to something casual. i guess i probably should've camel cased lastReturn and dailyInvest, i can change those small additions. to be fair, this is one of 3 investment systems i have built and/or building, and I'm used to php syntax naming.

I really like the idea, stealing this and converting it, going to improve on this but thank you for the contribution!