Thread: [614] Adding NPC Thieving (Decent)

Results 1 to 7 of 7
  1. #1 [614] Adding NPC Thieving (Decent) 
    Registered Member
    Join Date
    Aug 2014
    Posts
    101
    Thanks given
    8
    Thanks received
    1
    Rep Power
    0
    ....
    Reply With Quote  
     

  2. #2  
    Just a Finn

    Join Date
    Jul 2015
    Posts
    121
    Thanks given
    17
    Thanks received
    4
    Rep Power
    13
    Next time use [CODE] tags, so it's easier to read. Otherwise nice job.
    Reply With Quote  
     

  3. #3  
    Registered Member
    Join Date
    Aug 2014
    Posts
    101
    Thanks given
    8
    Thanks received
    1
    Rep Power
    0
    Quote Originally Posted by Dewwie View Post
    Next time use [CODE] tags, so it's easier to read. Otherwise nice job.
    Added !!!
    Reply With Quote  
     

  4. #4  
    Registered Member

    Join Date
    Dec 2012
    Posts
    2,999
    Thanks given
    894
    Thanks received
    921
    Rep Power
    2555
    • Why are you using the combat delay to determine if a player can thieve?
    • Use a listener for reaching a position
    • Clean up the usage for walking
    • You don't need to call your random method twice, call it once
    • Your variable naming sucks
    • Don't handle all your interactions via a switch
    Attached image
    Reply With Quote  
     

  5. #5  
    Registered Member
    Join Date
    Aug 2014
    Posts
    101
    Thanks given
    8
    Thanks received
    1
    Rep Power
    0
    Quote Originally Posted by Kaleem View Post
    • Why are you using the combat delay to determine if a player can thieve?
    • Use a listener for reaching a position
    • Clean up the usage for walking
    • You don't need to call your random method twice, call it once
    • Your variable naming sucks
    • Don't handle all your interactions via a switch
    Thanks for notice, I was just tryin what I can do.
    Reply With Quote  
     

  6. #6  
    Registered Member
    Join Date
    Mar 2014
    Posts
    32
    Thanks given
    2
    Thanks received
    0
    Rep Power
    11
    That's already added in spawnscape source.

    Good job though i guess
    Reply With Quote  
     

  7. #7  
    Extreme Donator

    Join Date
    Jul 2011
    Posts
    546
    Thanks given
    31
    Thanks received
    18
    Rep Power
    39
    Quote Originally Posted by Kaleem View Post
    • Your variable naming sucks
    • Don't handle all your interactions via a switch
    Both of those things are personal preference so what does it matter? Also variable names are called "identifiers". If you do not mind me asking, what basis do you have for telling him his identifiers suck?
    Attached image
    Reply With Quote  
     


Thread Information
Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)


User Tag List

Similar Threads

  1. Adding NPC drops to Dementhium 614
    By Cried Upon in forum Help
    Replies: 1
    Last Post: 06-09-2011, 04:16 PM
  2. 613/614 Adding npc combat
    By Juggalo Family in forum Tutorials
    Replies: 4
    Last Post: 08-18-2010, 05:16 PM
  3. Full Npc Thieving! [Handler]
    By Ferret in forum Tutorials
    Replies: 30
    Last Post: 08-31-2008, 03:31 PM
  4. [NEW]Adding npc and player gfx block[NEW]
    By XxXFoRbIdDeNXxX in forum Tutorials
    Replies: 23
    Last Post: 10-07-2007, 10:25 AM
  5. Full Npc Thieving!
    By Ferret in forum Tutorials
    Replies: 13
    Last Post: 09-29-2007, 07:25 PM
Tags for this Thread

View Tag Cloud

Posting Permissions
  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •