Thread: 718 Fixing QuickChat Packet Exploit

Any reason you chose 1163? You know that isn't the limit for quickchat. You are restricting a TON of messages by doing this. Get the real value lol

Originally Posted by TitanPK

Any reason you chose 1163? You know that isn't the limit for quickchat. You are restricting a TON of messages by doing this. Get the real value lol

No, that is the limit.

Originally Posted by rangin santa

No, that is the limit.

It's not the limit.

Code:

if (fileId > 1163) {
return;
}

That is the same as doing this:

Code:

if (fileId > 1163)
return;

Results are stull the same regardless, but you won't be able put anything in between the statement and the return without the brackets. Otherwise, you get an unreachable code error on the next line down.

Originally Posted by King J Scape

could always do this..

Code:

		} else if (packetId == SEND_FRIEND_QUICK_CHAT_PACKET) {
		/**	if (!player.hasStarted())
				return;
			String username = stream.readString();
			int fileId = stream.readUnsignedShort();
			byte[] data = null;
			if (length > 3 + username.length()) {
				data = new byte[length - (3 + username.length())];
				stream.readBytes(data);
			}
			data = Utils.completeQuickMessage(player, fileId, data);
			Player p2 = World.getPlayerByDisplayName(username);
			if (p2 == null)
				return;
			player.getFriendsIgnores().sendQuickChatMessage(p2,
					new QuickChatMessage(fileId, data));**/
		} else if (packetId == PUBLIC_QUICK_CHAT_PACKET) {
		/**	if (!player.hasStarted())
				return;
			if (player.getLastPublicMessage() > Utils.currentTimeMillis())
				return;
			player.setLastPublicMessage(Utils.currentTimeMillis() + 300);
			// just tells you which client script created packet
			@SuppressWarnings("unused")
			boolean secondClientScript = stream.readByte() == 1;// script 5059
			// or 5061
			int fileId = stream.readUnsignedShort();
			byte[] data = null;
			if (length > 3) {
				data = new byte[length - 3];
				stream.readBytes(data);
			}
			data = Utils.completeQuickMessage(player, fileId, data);
			if (chatType == 0)
				player.sendPublicChatMessage(new QuickChatMessage(fileId, data));
			else if (chatType == 1)
				player.sendFriendsChannelQuickMessage(new QuickChatMessage(
						fileId, data));
			else if (Settings.DEBUG)
				Logger.log(this, "Unknown chat type: " + chatType);**/

And this is the cancer that lurks in the Rune-Server community.

When I found this exploit and used it on servers, only one of them responded with this fix, and I just laughed my ass off with my friends for quite a while. The fact that we were able to make an owner remove an entire feature from the game instead of simply fixing it the way it should be fixed just made me laugh.