Thread: GlitchScape 742 - The introduction

Originally Posted by Java100

Cool that you show snippets of infrastructure. Whats the 'e' prefacing names? "Eitems" supposed to be enum items?

Yea, tried without but thought it was too easy to confuse with "Item".

Originally Posted by clem585

Yea, tried without but thought it was too easy to confuse with "Item".

r u gona have an open beta or something?

btw you can spam a spell on an opponent with staff of light and eventually u will cast it without having any runes in inventory-forgot that check

Originally Posted by ddvvyy

r u gona have an open beta or something?

btw you can spam a spell on an opponent with staff of light and eventually u will cast it without having any runes in inventory-forgot that check

It's called glitchscape, what do you expect

Originally Posted by ddvvyy

r u gona have an open beta or something?

btw you can spam a spell on an opponent with staff of light and eventually u will cast it without having any runes in inventory-forgot that check

Fixed, moved the check to removeRunes which is called after verifying the player has the runes. Also disabled it for now since it's only supose to work for combat spells and idk how I will do them yet. Thanks ;p

Originally Posted by Tesla

It's called glitchscape, what do you expect ;)

Shhh it's an hidden feature ^^

Originally Posted by Joris

Looks pretty good, i like this revision =)

<3

just something i randomly noticed

Code:

if (hasStaffOfLightEffect()) {
            staffOfLight = true;
            player.message("Your spell draws its power completely from your weapon.");
            return true;
        }

this part and the method isnt very efficient

Code:

this.staffOfLight = false;

by default this is already false and....

Code:

Combinations enchants = getCombinations(level);

you forgot to check if enchants is set or nulled and....

Code:

enchantSapphires

your naming is kinda weird, no offense, but naming for this case should be singular so e.g "enchantOnyx" cause i assume its a single action however it happens multiple times.

sorry but anyway goodluck with your project!

Originally Posted by _jordan

just something i randomly noticed

Code:

if (hasStaffOfLightEffect()) {
            staffOfLight = true;
            player.message("Your spell draws its power completely from your weapon.");
            return true;
        }

this part and the method isnt very efficient

Code:

this.staffOfLight = false;

by default this is already false and....

Yea, already refactored it to be called during removeRunes() so staffOfLight doesn't exist anymore.

Originally Posted by _jordan

Code:

Combinations enchants = getCombinations(level);

you forgot to check if enchants is set or nulled and....

Never going to be nulled as long as I don't add new routes for new enchants (which I don't think I'll ever do). And even if I did do that, I don't mind getting an error since I'll be testing it anyway ;p

Originally Posted by _jordan

Code:

enchantSapphires

your naming is kinda weird, no offense, but naming for this case should be singular so e.g "enchantOnyx" cause i assume its a single action however it happens multiple times.

sorry but anyway goodluck with your project! :)

Yea, you're right I should probably change that. Thanks for the feedback