NPC Examine npc drops?667

hi, so ive tried adding this - [Only registered and activated users can see links. Click Here To Register...]
to my 667 server, ive converted it added it with no compiler errors, but when it comes to examining the npc no drop table comes up, does anybody have any ideas, or even show me a differant way of adding npc drops? thanks

EDIT: messed around with this code, when i right click the npc it now opens up the interface, but shows no drops., now getting this error

java.lang.NullPointerException: Cannot invoke "com.rs.game.item.ItemsContainer.clear()" because the return value of "com.rs.game.player.Player.getNpcDrops()" is null
at com.rs.game.player.content.ViewNPCDrops.sendInterf ace(ViewNPCDrops.java:35)
at com.rs.net.decoders.handlers.NPCHandler$2.run(NPCH andler.java:275)
at com.rs.game.player.CoordsEvent.processEvent(Coords Event.java:53)
at com.rs.game.player.Player.processEntity(Player.jav a:642)
at com.rs.cores.WorldThread.run(WorldThread.java:48)

Quote:

---

Originally Posted by dubantbadman [Only registered and activated users can see links. Click Here To Register...]

hi, so ive tried adding this - [Only registered and activated users can see links. Click Here To Register...]
to my 667 server, ive converted it added it with no compiler errors, but when it comes to examining the npc no drop table comes up, does anybody have any ideas, or even show me a differant way of adding npc drops? thanks

EDIT: messed around with this code, when i right click the npc it now opens up the interface, but shows no drops., now getting this error

java.lang.NullPointerException: Cannot invoke "com.rs.game.item.ItemsContainer.clear()" because the return value of "com.rs.game.player.Player.getNpcDrops()" is null
at com.rs.game.player.content.ViewNPCDrops.sendInterf ace(ViewNPCDrops.java:35)
at com.rs.net.decoders.handlers.NPCHandler$2.run(NPCH andler.java:275)
at com.rs.game.player.CoordsEvent.processEvent(Coords Event.java:53)
at com.rs.game.player.Player.processEntity(Player.jav a:642)
at com.rs.cores.WorldThread.run(WorldThread.java:48)

---

NPCDrops::getDrops is returning null for the NPC you are trying to examine. Just add a null check in your ViewNPCDrops or make sure your NPCDrops::getDrops method is returning an empty array when there is no drops.

Quote:

---

Originally Posted by clem585 [Only registered and activated users can see links. Click Here To Register...]

NPCDrops::getDrops is returning null for the NPC you are trying to examine. Just add a null check in your ViewNPCDrops or make sure your NPCDrops::getDrops method is returning an empty array when there is no drops.

---

hmm, im abit new to java etc so idk how to do that lol, what do i need to add to this code? sorry for these stupid questions :/


public static void sendInterface(Player player, int npcId) {
Drop[] drops = getSortedList(player, NPCDrops.getDrops(npcId));

if (drops == null) {
player.getPackets().sendGameMessage("The " + NPCDefinitions.getNPCDefinitions(npcId).name + " doesn't have any drops to offer.");
return;
}

player.getInterfaceManager().sendInterface(671);
player.getPackets().sendIComponentText(671, 14, "Drops for " + NPCDefinitions.getNPCDefinitions(npcId).name + ".");

this is line 35-player.getNpcDrops().clear();


for (int i = 0; i < drops.length; i++) {
if (i > 30) //Maximum of 30 items on the interface
break;
player.getNpcDrops().add(new Item(drops[i].getItemId(), ItemDefinitions.getItemDefinitions(drops[i].getItemId()).isStackable() ? drops[i].getMaxAmount() : 1));
}