Thread: Mining Pickaxes (Fixed)

Code:

public enum Pickaxes {

		BRONZE_PICKAXE(1265, 625, 1, 1),
		IRON_PICKAXE(1267, 626, 2, 1),
		STEEL_PICKAXE(1269, 627, 3, 6),
		MITHRIL_PICKAXE(1273, 629, 5, 21),
		ADAMANT_PICKAXE(1271, 628, 7, 31),
		RUNE_PICKAXE(1275, 624, 10, 41),
		DRAGON_PICKAXE(15259, 12189, 13, 61); // Animation may be incorrect.
		
		private int pickaxeId, animationId, pickaxeTime, level;
		
		private Pickaxes(int pickaxeId, int animationId, int pickaxeTime, int level) {
			this.pickaxeId = pickaxeId;
			this.animationId = animationId;
			this.pickaxeTime = pickaxeTime;
			this.level = level;
		}

                //cache		
                public static final EnumSet<Pickaxes> PICKAXES = EnumSet.allOf(Pickaxes.class);

		public int getPickaxeId() {
			return pickaxeId;
		}
		
		public int getAnimationId() {
			return animationId;
		}
		
		public int getPickaxeTime() {
			return pickaxeTime;
		}
		
		public int getLevel() {
			return level;
		}
	}

Code:

public static Pickaxes getPickaxe(Player player) {
		for (int i = Pickaxes.PICKAXES.size() - 1; i < 7; i--) {
			Pickaxes pickaxe = Pickaxes.values()[i];
			if (player.getInventory().containsItemToolBelt(1265) || player.getEquipment().getWeaponId() == pickaxe.getPickaxeId()) {
				if (player.getSkills().getLevel(Skills.MINING) < pickaxe.getLevel()) {
					return pickaxe;
				}
			}
		}
		return null;

I believe this should work, if not, change size() -1 to size().
Also, cached values for you as repeatedly calling #values is just a waste of memory and performance.

Code:

        BRONZE(1265, 1, 625, 8),
	BRONZE_G(20780, 1, 234, 8),
	IRON(1267, 1, 626, 7),
	IRON_G(20781, 1, 235, 7),
	STEEL(1269, 6, 627, 6),
	STEEL_G(20782, 6, 236, 6),
	MITHRIL(1273, 21, 629, 5),
	MITHRIL_G(20784, 21, 238, 5),
	ADAMANT(1271, 31, 628, 4),
	ADAMANT_G(20783, 31, 237, 4),
	RUNE(1275, 41, 624, 3),
	RUNE_G(20785, 41, 249, 3),
	DRAGON(15259, 61, 12189, 3),
	DRAGON_G(20786, 61, 250, 3),
	INFERNO_ADZE(13661, 61, 10222, 3);
	
	private int itemId, level, ticks;
	private Animation animation;
	
	private Pickaxe(int itemId, int level, int animId, int ticks) {
		this.itemId = itemId;
		this.level = level;
		this.animation = new Animation(animId);
		this.ticks = ticks;
	}

Real RS pickaxes have a tick speed that determines how fast the mining process rolls for success by the way. Dragon has a 25% chance to be 2 tick instead of 3 tick.

Originally Posted by Stimulant

I was looking for this, couldn't find anything on the wiki, thanks

Jmod twitters have more than the wiki in most cases unfortunately lol