718 Bank - Equipment Interface Issue

**clem585** · 05-06-2020, 01:56 AM

Been getting PMs for this, so little gravedig:

Code:

 // send this 1 tick after opening the interface (reason explained below)

player.getPackets().sendConfigByFile(8348, 0); // 0 when opening bank, 1 when opening equipment I think
player.getPackets().sendRunScript(2319); // refresh the bank/equip interface depending on the value of varbit 8348

**Displee** · 05-06-2020, 08:07 PM

The proper way to fix this is to send script 2319 one game tick after you send the equipment interface.

**clem585** · 05-06-2020, 08:44 PM

Originally Posted by Admiral Slee

The proper way to fix this is to send script 2319 one game tick after you send the equipment interface.

The script needs the value of this config to be set:

Code:

void script_2319() {
	if (((boolean)bitconfig_8348)) {
		setWidgetIsHidden(true, new WidgetPointer(762,0));
		setWidgetIsHidden(true, new WidgetPointer(763,0));
		setWidgetIsHidden(false, new WidgetPointer(667,0));
		setWidgetIsHidden(false, new WidgetPointer(763,1));
	} else {
		setWidgetIsHidden(false, new WidgetPointer(762,0));
		setWidgetIsHidden(false, new WidgetPointer(763,0));
		setWidgetIsHidden(true, new WidgetPointer(667,0));
		setWidgetIsHidden(true, new WidgetPointer(763,1));
	}
	script_722();
	return;
}

And since only setting the value of the config works, I'm pretty sure the script is called automatically.

**Displee** · 05-06-2020, 10:32 PM

Originally Posted by clem585

The script needs the value of this config to be set:

Code:

void script_2319() {
	if (((boolean)bitconfig_8348)) {
		setWidgetIsHidden(true, new WidgetPointer(762,0));
		setWidgetIsHidden(true, new WidgetPointer(763,0));
		setWidgetIsHidden(false, new WidgetPointer(667,0));
		setWidgetIsHidden(false, new WidgetPointer(763,1));
	} else {
		setWidgetIsHidden(false, new WidgetPointer(762,0));
		setWidgetIsHidden(false, new WidgetPointer(763,0));
		setWidgetIsHidden(true, new WidgetPointer(667,0));
		setWidgetIsHidden(true, new WidgetPointer(763,1));
	}
	script_722();
	return;
}

And since only setting the value of the config works, I'm pretty sure the script is called automatically.

That's correct, the varpbit is also needed. But there's no interface component that listens to this varpbit, you need to call the script.

**clem585** · 05-07-2020, 04:13 AM

Originally Posted by Admiral Slee

That's correct, the varpbit is also needed. But there's no interface component that listens to this varpbit, you need to call the script.

Oh yep my bad

Code:

	public void openBank() {
		bonestoOffer.stopOfferGod = true;
		if (player.getHitpoints() < player.getMaxHitpoints()) {
			player.applyHit(new Hit(player, (player.getHitpoints() + player.getMaxHitpoints() > player.getMaxHitpoints() ? (player.getMaxHitpoints()-player.getHitpoints()) : player.getMaxHitpoints()), HitLook.HEALED_DAMAGE));
		}
		player.getInterfaceManager().sendInterface(762);
		player.getInterfaceManager().sendInventoryInterface(763);
		player.getPackets().sendConfigByFile(8348, 0);
		player.getPackets().sendRunScript(2319);
		refreshViewingTab();
		refreshTabs();
		unlockButtons();
		sendItems();
		refreshLastX();
	}

Edited first answer

**hc747** · 05-07-2020, 04:31 AM

Originally Posted by Admiral Slee

The proper way to fix this is to send script 2319 one game tick after you send the equipment interface.

Out of curiosity, why does there have to be the one tick delay?

**Stimulant** · 05-07-2020, 04:55 AM

Originally Posted by clem585

Oh yep my bad

Code:

	public void openBank() {
		bonestoOffer.stopOfferGod = true;
		if (player.getHitpoints() < player.getMaxHitpoints()) {
			player.applyHit(new Hit(player, (player.getHitpoints() + player.getMaxHitpoints() > player.getMaxHitpoints() ? (player.getMaxHitpoints()-player.getHitpoints()) : player.getMaxHitpoints()), HitLook.HEALED_DAMAGE));
		}
		player.getInterfaceManager().sendInterface(762);
		player.getInterfaceManager().sendInventoryInterface(763);
		player.getPackets().sendConfigByFile(8348, 0);
		player.getPackets().sendRunScript(2319);
		refreshViewingTab();
		refreshTabs();
		unlockButtons();
		sendItems();
		refreshLastX();
	}

Edited first answer

I tested it, it seems you don't need to send the script when opening the bank, the varbit 8348 with value 0 will fix this part. Now I'm looking into fixing the equipment part from the tab.

Code:

public void openBank() {
		player.getInterfaceManager().sendInterface(762);
		player.getInterfaceManager().sendInventoryInterface(763);
		player.getPackets().sendVarBit(8348, 0);
		// player.getPackets().sendRunScript(2319);
		sendItems();
		unlockButtons();
		refreshViewingTab();
		refreshTabs();
		refreshLastX();
		refreshBankSpace();
	}

**Displee** · 05-07-2020, 05:02 AM

Originally Posted by hc747

Out of curiosity, why does there have to be the one tick delay?

Because the client may process your script call earlier than opening the interface. Opening the interface costs render power. A script call is extremely fast. The script must be called after the interface has been opened.

**clem585** · 05-07-2020, 07:50 AM

Originally Posted by Admiral Slee

Because the client may process your script call earlier than opening the interface. Opening the interface costs render power. A script call is extremely fast. The script must be called after the interface has been opened.

Ah, that explains why my dungeoneering party was messed up seemingly randomly and why some interfaces on actual RS have delays.

**Stimulant** · 05-07-2020, 09:22 PM

Originally Posted by Admiral Slee

Because the client may process your script call earlier than opening the interface. Opening the interface costs render power. A script call is extremely fast. The script must be called after the interface has been opened.

Thanks, learned something today, managed to fix it properly now.

Thread: 718 Bank - Equipment Interface Issue

Thread Tools

Thankful user:

Thankful user:

Thankful user:

Thankful users:

Users Browsing this Thread

User Tag List

Similar Threads

718 removing equipment from equipment interface

718 Interface issue.

bank pin interface issue

718 annoying interface issue WILL REP + THANK

bank interface issues