Thread: Overload NPC.

Results 1 to 5 of 5
  1. #1 Overload NPC. 
    Registered Member
    Join Date
    Nov 2014
    Posts
    147
    Thanks given
    15
    Thanks received
    3
    Rep Power
    6
    So I'm making this overload NPC, but somehow it doesn't check if the items are in your inventory.
    Does anyone see what I'm doing wrong?

    This is my NPCHandler.

    Code:
    else if (npc.getId() == 286) {
    					if (!player.getInventory().containsOneItem(15308)
    							|| !player.getInventory().containsOneItem(15312)
    							|| !player.getInventory().containsOneItem(15316)
    							|| !player.getInventory().containsOneItem(269)
    							|| !player.getInventory().containsOneItem(15320)
    							|| !player.getInventory().containsOneItem(15324)) {				
    						player.getInventory().deleteItem(15308, 1);
    						player.getInventory().deleteItem(15312, 1);
    						player.getInventory().deleteItem(15316, 1);
    						player.getInventory().deleteItem(15320, 1);
    						player.getInventory().deleteItem(15324, 1);
    						player.getInventory().deleteItem(269, 1);
    						player.getPackets().sendGameMessage("You've exchanged your ingredients for an Overload.");
    						player.getSkills().addXp(Skills.HERBLORE, 1000);
    						player.getInventory().addItem(23531, 1);
    					} else {
    						player.getPackets().sendGameMessage("You either don't have the required level, or ingredients to make Overloads.");
    					}
    					}
    Reply With Quote  
     

  2. #2  
    Registered Member

    Join Date
    Feb 2013
    Posts
    4,409
    Thanks given
    59
    Thanks received
    478
    Rep Power
    138
    ! = false
    !player.getInventory().containsOneItem(x) = checking if the player doesn't have the items
    Reply With Quote  
     

  3. Thankful user:


  4. #3  
    Registered Member
    Join Date
    Nov 2014
    Posts
    147
    Thanks given
    15
    Thanks received
    3
    Rep Power
    6
    Quote Originally Posted by Mayne View Post
    ! = false
    !player.getInventory().containsOneItem(x) = checking if the player doesn't have the items
    Now it will make an overload when you have 1 of the items, I'm trying to have it check for all items.

    Code:
    if (player.getInventory().containsItem(15308)
    							|| player.getSkills().getLevelForXp(Skills.HERBLORE) < 96
    							|| player.getInventory().containsItem(15312)
    							|| player.getInventory().containsItem(15316)
    							|| player.getInventory().containsItem(269)
    							|| player.getInventory().containsItem(15320)
    							|| player.getInventory().containsItem(15324)) {				
    						player.getInventory().deleteItem(15308, 1);
    						player.getInventory().deleteItem(15312, 1);
    						player.getInventory().deleteItem(15316, 1);
    						player.getInventory().deleteItem(15320, 1);
    						player.getInventory().deleteItem(15324, 1);
    						player.getInventory().deleteItem(269, 1);
    						player.getPackets().sendGameMessage("You've exchanged your ingredients for an Overload.");
    						player.getSkills().addXp(Skills.HERBLORE, 1000);
    						player.getInventory().addItem(23531, 1);
    					} else {
    						player.getPackets().sendGameMessage("You either don't have the required level, or ingredients to make Overloads.");
    					}
    					}
    Reply With Quote  
     

  5. Thankful user:


  6. #4  
    Registered Member
    Stratified's Avatar
    Join Date
    Nov 2012
    Age
    25
    Posts
    1,197
    Thanks given
    1,539
    Thanks received
    223
    Rep Power
    524
    Quote Originally Posted by xremcooo View Post
    Now it will make an overload when you have 1 of the items, I'm trying to have it check for all items.

    Code:
    if (player.getInventory().containsItem(15308)
                                || player.getSkills().getLevelForXp(Skills.HERBLORE) < 96
                                || player.getInventory().containsItem(15312)
                                || player.getInventory().containsItem(15316)
                                || player.getInventory().containsItem(269)
                                || player.getInventory().containsItem(15320)
                                || player.getInventory().containsItem(15324)) {                
                            player.getInventory().deleteItem(15308, 1);
                            player.getInventory().deleteItem(15312, 1);
                            player.getInventory().deleteItem(15316, 1);
                            player.getInventory().deleteItem(15320, 1);
                            player.getInventory().deleteItem(15324, 1);
                            player.getInventory().deleteItem(269, 1);
                            player.getPackets().sendGameMessage("You've exchanged your ingredients for an Overload.");
                            player.getSkills().addXp(Skills.HERBLORE, 1000);
                            player.getInventory().addItem(23531, 1);
                        } else {
                            player.getPackets().sendGameMessage("You either don't have the required level, or ingredients to make Overloads.");
                        }
                        }
    Use && instead of ||
    || or; && = and.
    Attached image
    Attached image
    Reply With Quote  
     

  7. #5  
    Registered Member
    Join Date
    Nov 2014
    Posts
    147
    Thanks given
    15
    Thanks received
    3
    Rep Power
    6
    Quote Originally Posted by Bagrov View Post
    Use && instead of ||
    || or; && = and.
    Yeah fixed it, I always thought || was the same as &&...
    Reply With Quote  
     


Thread Information
Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)


User Tag List

Similar Threads

  1. [tut]Poison Npcs (With green splat)..
    By Santa Clause in forum Tutorials
    Replies: 9
    Last Post: 05-21-2007, 03:55 AM
  2. All Lists - item, object and NPC
    By purepkownage in forum Tools
    Replies: 2
    Last Post: 05-11-2007, 09:46 AM
  3. NPC Magic Distance Bug Fix
    By Zekkalkan in forum Tutorials
    Replies: 5
    Last Post: 05-06-2007, 07:21 PM
  4. Replies: 8
    Last Post: 05-04-2007, 09:52 PM
  5. Replies: 4
    Last Post: 05-03-2007, 03:57 AM
Posting Permissions
  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •