Thread: Better way to write this?

Results 1 to 4 of 4
  1. #1 Better way to write this? 
    Registered Member Capsize's Avatar
    Join Date
    Jan 2011
    Posts
    373
    Thanks given
    71
    Thanks received
    35
    Rep Power
    0
    Current Code:

    Code:
    /**
    	 * Sends the reward when the achievement is completed.
    	 * @param player
    	 * 
    	 */
    	public static void sendReward(Player player) {
    		if (AxeManAchievement == 500) {
    		sendRewards(player);
    		}  else  if (TrawlerAchievement == 750) {
    		sendRewards(player);
    		} else if (CulinaryArtistAchievement == 500) {
    		sendRewards(player);
    		}
    	}
    I'm learning still, and I assume there's a better way to write this neater, so if anyone could give tips or help, that would be great.
    Reply With Quote  
     

  2. #2  
    Registered Member
    Join Date
    Feb 2012
    Posts
    376
    Thanks given
    87
    Thanks received
    82
    Rep Power
    56
    Code:
    /**
     * Sends the reward when the achievement is completed.
     * @param player
     * 
     */
    public static void sendReward(Player player) {
    	if(axeManAchievement == 500 || trawlerAchievement == 750 || culinaryArtistAchievement == 500 ) 
    		sendRewards(player);
    }
    Should use camelCase on the AxeManAchievement etc (Conventions)
    Reply With Quote  
     

  3. #3  
    Registered Member
    Zivik's Avatar
    Join Date
    Oct 2007
    Age
    28
    Posts
    4,421
    Thanks given
    891
    Thanks received
    1,527
    Rep Power
    3285
    You should utilize something like abstraction if you're intent is having an achievement system or something similar like quest.
    Reply With Quote  
     

  4. #4  
    Registered Member Capsize's Avatar
    Join Date
    Jan 2011
    Posts
    373
    Thanks given
    71
    Thanks received
    35
    Rep Power
    0
    Quote Originally Posted by abysspartyy View Post
    Code:
    /**
     * Sends the reward when the achievement is completed.
     * @param player
     * 
     */
    public static void sendReward(Player player) {
    	if(axeManAchievement == 500 || trawlerAchievement == 750 || culinaryArtistAchievement == 500 ) 
    		sendRewards(player);
    }
    Should use camelCase on the AxeManAchievement etc (Conventions)
    Yeah, I know that way too. I just wasn't sure if that way would be better or not, nonetheless thank you.

    Quote Originally Posted by Zivik View Post
    You should utilize something like abstraction if you're intent is having an achievement system or something similar like quest.
    I'll look into that, thanks.
    Reply With Quote  
     


Thread Information
Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)


User Tag List

Similar Threads

  1. Any way to write this more nicely? [python]
    By Mister Maggot in forum Application Development
    Replies: 1
    Last Post: 04-17-2013, 04:32 PM
  2. Better way to do this
    By Jamili in forum Help
    Replies: 5
    Last Post: 03-30-2012, 04:14 AM
  3. Better way to do this?
    By TheeRash in forum Help
    Replies: 6
    Last Post: 12-24-2011, 05:17 PM
  4. Replies: 2
    Last Post: 07-26-2010, 02:44 PM
  5. Better ways of writing this?
    By jameskmonger in forum Help
    Replies: 15
    Last Post: 05-05-2010, 05:23 AM
Posting Permissions
  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •