Use "else if" I think try that
Rep if that helped thanks :3
|
|
So I want to give donators and extreme donators more tokens and exp if they kill a certain npc, but the tokens and exp stack with a normal players. For example if I was a normal player I'd get 1750 tokens and 50k exp, if I was a donator id get 4125 tokens adn 75k exp. But what happened is if I was a donator I'd get 1750 tokens and 50k exp on top of the 4125 tokens and 75k exp. This is the code I have, please don't give me any hate I'm still learning,
Code:if (id == 11872 || id == 12878) { killer.getSkills().addXp(24, 50000); killer.dungpoints += 2750; killer.getPackets().sendGameMessage("You received 2750 Dungeoneering tokens for this kill."); if (killer.isDonator()){ killer.getSkills().addXp(24, 75000); killer.dungpoints += 4125; killer.getPackets().sendGameMessage("You received 4125 Dungeoneering tokens for this kill.");}} if (killer.isExtremeDonator()){ killer.getSkills().addXp(24, 100000); killer.dungpoints += 5500; killer.getPackets().sendGameMessage("You received 5500 Dungeoneering tokens for this kill."); }



Use "else if" I think try that
Rep if that helped thanks :3

For what revision is it?
Code:if (id == 11872 || id == 12878) { if (killer.isExtremeDonator()) { killer.getSkills().addXp(24, 100000); killer.dungpoints += 5500; killer.getPackets().sendGameMessage("You received 5500 Dungeoneering tokens for this kill."); } else if (killer.isDonator()) { killer.getSkills().addXp(24, 75000); killer.dungpoints += 4125; killer.getPackets().sendGameMessage("You received 4125 Dungeoneering tokens for this kill."); } killer.getSkills().addXp(24, 50000); killer.dungpoints += 2750; killer.getPackets().sendGameMessage("You received 2750 Dungeoneering tokens for this kill."); }
Try returning the statements...
Something sort of like this:OrCode:if (id == 11872 || id == 12878) { if (killer.isExtremeDonator()) { killer.getSkills().addXp(24, 100000); killer.dungpoints += 5500; killer.getPackets().sendGameMessage("You received 5500 Dungeoneering tokens for this kill."); return; } if (killer.isDonator()) { killer.getSkills().addXp(24, 75000); killer.dungpoints += 4125; killer.getPackets().sendGameMessage("You received 4125 Dungeoneering tokens for this kill."); return; } if (!killer.isDonator()) && (!killer.isExtremeDonator()) { killer.getSkills().addXp(24, 50000); killer.dungpoints += 2750; killer.getPackets().sendGameMessage("You received 2750 Dungeoneering tokens for this kill."); return; } }
Code:if (id == 11872 || id == 12878) { if (killer.isExtremeDonator()) { killer.getSkills().addXp(24, 100000); killer.dungpoints += 5500; killer.getPackets().sendGameMessage("You received 5500 Dungeoneering tokens for this kill."); return; } if (killer.isDonator()) { killer.getSkills().addXp(24, 75000); killer.dungpoints += 4125; killer.getPackets().sendGameMessage("You received 4125 Dungeoneering tokens for this kill."); return; } killer.getSkills().addXp(24, 50000); killer.dungpoints += 2750; killer.getPackets().sendGameMessage("You received 2750 Dungeoneering tokens for this kill."); }

Are you plain retarded or what, how the hell does the revision affect it?
And:
Clean and works, you should be using a switch statement thoughCode:if (id == 11872 || id == 12878) { int tokenAmount = 2750; int skillXP = 50000; if (killer.isDonator()) tokenAmount = 4125; skillXP = 75000; if (killer.isExtremeDonator()) tokenAmount = 5500; skillXP = 100000; killer.sendMessage("You recieved " + tokenAmount + " Dungeoneering tokens for this kill."); killer.getSkills().addXp(24, skillXP); }

| « need help with portforwd my rsps | [742] Switchitemslook help » |
| Thread Information |
Users Browsing this ThreadThere are currently 1 users browsing this thread. (0 members and 1 guests) |