[Espeon] What's wrong with my little pieces of code? [Rep++ for quik help, Espeon]

Hello,

I have added two new things to my server today, and both dont work:S

First of this is added to ObjectOption1.java:

Code:

---

        case 34384: //bake stall Coin's500 Lvl0
        p.clickDelay = 5;
        p.requestAnim(881, 0);
        Engine.playerItems.addItem(p, 995, 500);
        p.appendExperience(500, 17);
        p.getActionSender().sendMessage(p, "You stole 500 Coin's.");
        break;

        case 34383: //silk stall Coin's1000 Lvl15
        p.clickDelay = 5;
        if (p.skillLvl[17] <= 15);
        p.requestAnim(881, 0);
        Engine.playerItems.addItem(p, 995, 1000);
        p.appendExperience(750, 17);
        p.getActionSender().sendMessage(p, "You stole 1000 Coin's.");
        break;

        case 34387: //Fur stall Coin's2000 Lvl30
        p.clickDelay = 5;
        if (p.skillLvl[17] <= 30);
        p.requestAnim(881, 0);
        Engine.playerItems.addItem(p, 995, 2000);
        p.appendExperience(1250, 17);
        p.getActionSender().sendMessage(p, "You stole 2000 Coin's.");
        break;

        case 34382: //silver stall Coin's5000 Lvl50
        p.clickDelay = 5;
        if (p.skillLvl[17] <= 50);
        p.requestAnim(881, 0);
        Engine.playerItems.addItem(p, 995, 5000);
        p.appendExperience(1250, 17);
        p.getActionSender().sendMessage(p, "You stole 5000 Coin's.");
        break;

        case 34386: //spice stall Coin's10000 Lvl65
        p.clickDelay = 5;
        if (p.skillLvl[17] <= 65);
        p.requestAnim(881, 0);
        Engine.playerItems.addItem(p, 995, 10000);
        p.appendExperience(3250, 17);
        p.getActionSender().sendMessage(p, "You stole 10000 Coin's.");
        break;

        case 34385: //Gem stall Coin's15000 Lvl80
        p.clickDelay = 5;
        if (p.skillLvl[17] <= 80);
        p.requestAnim(881, 0);
        Engine.playerItems.addItem(p, 995, 15000);
        p.appendExperience(5000, 17);
        p.getActionSender().sendMessage(p, "You stole 15000 Coin's.");
        break;

---

Its for thieving stalls, should be working right?

than for NpcCombat.java:

Code:

---

        public void appendAttackPlayer() {
                Player p = Server.engine.players[n.playerIndex];
                if (n.npcType == 2783 || n.npcType == 1615) {
                        if (Misc.getDistance(n.absX, n.absY, p.absX, p.absY) > 7) {
                                n.resetAttack();
                                n.killingCount = 0;
                                n.requestFaceTo(65535);
                                n.randomWalk = true;
                                n.playerIndex = 0;
                                return;
                        }
                }
                if (p == null || n == null|| n.isDead || n.currentHP <= 0 || p.skillLvl[3] <= 0 || p.disconnected[0]) {
                        n.resetAttack();
                        return;
                }
                if (p.rangedPrayer == true || p.meleePrayer == true || p.magicPrayer == true) {
                n.appendHit(0, 0);
                }
                Player playerz = Server.engine.players[n.spawnedFor];
                for (int i = 0; i < n.animatedArmours.length; i++) {
                        if (playerz != null && n.npcType == n.animatedArmours[i]) {
                                if (playerz.isDead || playerz.deathDelay > 0 || playerz == null) {
                                        n.spawnedFor = 0;
                                        n.underAttack = false;
                                        n = null;
                                        return;
                                }
                        }
                }
                try {
                        if (n.faceToRequest != n.playerIndex + 32768) {
                                n.requestFaceCoords(p.absX, p.absY);
                                n.requestFaceTo(n.playerIndex + 32768);
                        }
                } catch (Exception e) {
                        e.printStackTrace();
                }
               
                if (n.npcType == 1615 || n.npcType == 2783) {
                        if (n.killingCount <= 0)
                                n.killingCount++;
                }

---

The Monsyer's should be hitting 0s when protecting right?
Well they dont.

No errors to.

Thanks for reading REP++ for quik help

Now, I'm not 100% sure on these, but just try them. :p

In your NPC combat one, it should be p not n as the hit is appearing on the player not npc.

The first one nothing looks wrong off the bat, are you putting it in the correct area and using switch(objectId) {

} or something similar?

Add a return; under the p.appendhit(0,0)
and you need to set the npc's attack delay again, so it doesn't just spam 0s

for the first. it should look like this

case 34384: //bake stall Coin's500 Lvl0
if (p.clickdelay <= 0)
{
p.clickDelay = 5;
p.requestAnim(881, 0);
Engine.playerItems.addItem(p, 995, 500);
p.appendExperience(500, 17);
p.getActionSender().sendMessage(p, "You stole 500 Coin's.");
}
break;


what are your errors exactly anyways? are they just syntax or logic?

For the stalls, i think there obj click 2.

Quote:

---

Originally Posted by IjavaI [Only registered and activated users can see links. Click Here To Register...]

For the stalls, i think there obj click 2.

---

Why would they be second click? There is only 1 first click option...

Stealing from stalls isnt Object1 or 2 it is its own packet

this id for the packet is 190 i think.

those two:

Code:

---

                if (p.rangedPrayer == true || p.meleePrayer == true || p.magicPrayer == true) {
                p.appendHit(0, 0);
                return;
                }

---

and

Code:

---

                if (p.rangedPrayer == true || p.meleePrayer == true || p.magicPrayer == true) {
                n.appendHit(0, 0);
                return;
                }

---

(n.appendHit(0,0); or n.appendHit(0,0); both dont work)
I added return;

They still hit.