Thread: whats wrong with this? [508]

Originally Posted by mige5

Code:

			if (npcType == ####)
			{
			for(Player pl : Engine.players) {
			if (pl != null) {
		pl.createGlobalObject(6951, p.heightLevel, absX, absY, 0, 10);
				return;
			}
			}
			}

Should

Code:

pl.createGlobalObject(6951, p.heightLevel, absX, absY, 0, 10);

be (I'm guessing)

Code:

pl.createGlobalObject(6951, p.heightLevel, p.absX, p.absY, 0, 10);

That should fix it, if you are trying to remove the object you created, but only if the players haven't moved.

I'm not exactly sure what you are trying to do, but if you want to remove all the objects you created, you would have to make some sort of list like an array or arraylist.

Also, if a player logs in after the object is created, they won't be able to see it, same with the NPC created.

PM me if that is what you want to do and you aren't sure how, I think I have a pretty good idea.

no i dont want to add it like this: p.absX and p.absY, because they mean player coordinates, and the current im using means NPC coordinates so it is good...

It isn't good, because it doesn't work. It was hard to understand what you were trying to do, you gave me 2 blocks of code and said fix it.
Your code does not remove the object from the killer, it removes it from the first valid player in the player list. I'll explain why.

Code:

if (npcType == ####)
			{
			for(Player pl : Engine.players) {
			if (pl != null) {
		pl.createGlobalObject(6951, p.heightLevel, absX, absY, 0, 10);
				return;
			}
			}
			}

"return" instructs the JVM to exit the current method and move on to the next one.
Anything under "return" is never reached.

If you deleted

Code:

return;

the loop should run through everyone as well as continue past the loop.

Originally Posted by Illuminate

It isn't good, because it doesn't work. It was hard to understand what you were trying to do, you gave me 2 blocks of code and said fix it.
Your code does not remove the object from the killer, it removes it from the first valid player in the player list. I'll explain why.

Code:

if (npcType == ####)
			{
			for(Player pl : Engine.players) {
			if (pl != null) {
		pl.createGlobalObject(6951, p.heightLevel, absX, absY, 0, 10);
				return;
			}
			}
			}

"return" instructs the JVM to exit the current method and move on to the next one.
Anything under "return" is never reached.

If you deleted

Code:

return;

the loop should run through everyone as well as continue past the loop.

THX! deleted the return and worked!